improve opening profiling url

Author: malytomas

sources/include/cage-core/process.h

@@ -36,6 +36,8 @@ namespace cage
 	CAGE_CORE_API void installSigTermHandler(Delegate<void()> handler);
 	CAGE_CORE_API void installSigIntHandler(Delegate<void()> handler);
 
+	// the url may need some preparation (replace spaces with %20)
+	// the function may silently fail
 	CAGE_CORE_API void openUrl(const String &url);
 }
 

sources/libcore/concurrent/openUrl.cpp

@@ -38,11 +38,13 @@ namespace cage
 
 	void openUrl(const String &url)
 	{
+		CAGE_LOG(SeverityEnum::Info, "openUrl", Stringizer() + "opening browser with url: " + url);
 #ifdef CAGE_SYSTEM_WINDOWS
 		if (!windowsTryFile(url))
 			ShellExecute(NULL, "open", url.c_str(), NULL, NULL, SW_SHOWNORMAL);
 #else
-		std::system((Stringizer() + "xdg-open " + url).value.c_str());
+		const String s = replace(url, "\"", "\\\"");
+		std::system((Stringizer() + "xdg-open \"" + s + "\"").value.c_str());
 #endif
 	}
 }

sources/libcore/profiling.cpp

@@ -8,6 +8,7 @@
 	#include <cage-core/concurrent.h>
 	#include <cage-core/concurrentQueue.h>
 	#include <cage-core/config.h>
+	#include <cage-core/string.h>
 	#include <cage-core/files.h>
 	#include <cage-core/math.h>
 	#include <cage-core/networkWebsocket.h>
@@ -202,7 +203,7 @@ namespace cage
 							try
 							{
 								writeFile("profiling.htm")->write(profiling_htm().cast<const char>());
-								const String baseUrl = pathWorkingDir() + "/profiling.htm";
+								const String baseUrl = replace(pathWorkingDir(), " ", "%20") + "/profiling.htm";
 								const String url = Stringizer() + "file://" + baseUrl + "?port=" + server->port();
 								openUrl(url);
 							}