Fix wizard end flow and backoffice payloads (#16)

AgustinPose · web-flow · commit e27626ae3ab7 · 2026-02-26T20:13:48.000-03:00
Este PR corrige fallos al finalizar el wizard de postulación y
estabiliza la integración con Backoffice.

Se elimina el envío duplicado al cierre del wizard, dejando un único
flujo de envío.
Se normaliza el payload de caso para hacerlo más robusto (descripcion,
consentimiento_datos, id_estado).
Se agrega id_convocatoria opcional vía configuración.
Se sanitiza datos_chatbot para evitar errores de serialización.
Se actualiza .env.example con nuevas variables de Backoffice.
Resultado: menos errores 500 al final del wizard y payloads consistentes
tanto para has_idea=NO como para has_idea=SI.
diff --git a/.env.example b/.env.example
@@ -17,6 +17,7 @@ BACKOFFICE_BASE_URL=http://localhost:8000
 BACKOFFICE_ADMIN_EMAIL=admin@ithaka.com
 BACKOFFICE_ADMIN_PASSWORD=admin123
 BACKOFFICE_INTEGRATION_ENABLED=true
+BACKOFFICE_DEFAULT_ID_ESTADO=1
 
 # Other environment variables (add as needed)
 # TWILIO_ACCOUNT_SID=your_twilio_sid
diff --git a/app/agents/wizard_node.py b/app/agents/wizard_node.py
@@ -1,5 +1,5 @@
 """
-WizardAgent -- routable node that guides users through the postulación flow.
+WizardAgent -- routable node that guides users through the postulacion flow.
 
 Wraps the wizard sub-graph (wizard_workflow/wizard_graph) behind the
 standard AgentNode interface so the supervisor can route to it by
@@ -13,14 +13,14 @@
 import yaml
 
 from .base import AgentNode
-from ..graph.state import ConversationState
-from .wizard_workflow.wizard_graph import wizard_graph
 from ..db.config.database import SessionLocal
-from ..services import conversation_service, postulation_service
+from ..graph.state import ConversationState
+from ..services import conversation_service
 from ..services.backoffice_service import (
     BackofficeIntegrationDisabled,
     send_postulation_to_backoffice,
 )
+from .wizard_workflow.wizard_graph import wizard_graph
 
 logger = logging.getLogger(__name__)
 
@@ -58,40 +58,28 @@ async def __call__(self, state: ConversationState) -> ConversationState:
             wizard_state = dict(wizard_state)
             wizard_state["messages"] = state.get("messages", [])
 
-        logger.debug(f"[WIZARD_NODE] Wizard state before sub-graph invoke:")
-        logger.debug(f"[WIZARD_NODE]   session_id={wizard_state.get('wizard_session_id')}")
-        logger.debug(f"[WIZARD_NODE]   current_question={wizard_state.get('current_question')}")
-        logger.debug(f"[WIZARD_NODE]   wizard_status={wizard_state.get('wizard_status')}")
-        logger.debug(f"[WIZARD_NODE]   awaiting_answer={wizard_state.get('awaiting_answer')}")
-        logger.debug(f"[WIZARD_NODE]   completed={wizard_state.get('completed')}")
-        logger.debug(f"[WIZARD_NODE]   answers count={len(wizard_state.get('answers', []))}")
-        logger.debug(f"[WIZARD_NODE]   messages count={len(wizard_state.get('messages', []))}")
-        for i, m in enumerate(wizard_state.get("messages", [])):
-            logger.debug(f"[WIZARD_NODE]   msg[{i}] type={m.type} content={m.content[:100]!r}...")
+        logger.debug("[WIZARD_NODE] Wizard state before sub-graph invoke:")
+        logger.debug("[WIZARD_NODE]   session_id=%s", wizard_state.get("wizard_session_id"))
+        logger.debug("[WIZARD_NODE]   current_question=%s", wizard_state.get("current_question"))
+        logger.debug("[WIZARD_NODE]   wizard_status=%s", wizard_state.get("wizard_status"))
+        logger.debug("[WIZARD_NODE]   awaiting_answer=%s", wizard_state.get("awaiting_answer"))
+        logger.debug("[WIZARD_NODE]   completed=%s", wizard_state.get("completed"))
+        logger.debug("[WIZARD_NODE]   answers count=%d", len(wizard_state.get("answers", [])))
+        logger.debug("[WIZARD_NODE]   messages count=%d", len(wizard_state.get("messages", [])))
+        for i, msg in enumerate(wizard_state.get("messages", [])):
+            logger.debug("[WIZARD_NODE]   msg[%d] type=%s content=%r...", i, msg.type, msg.content[:100])
 
         result = await wizard_graph.ainvoke(wizard_state)
 
         response_content = (
-            result.get("messages", [])[-1].content
-            if result.get("messages")
-            else ""
+            result.get("messages", [])[-1].content if result.get("messages") else ""
         )
 
-        logger.debug(f"[WIZARD_NODE] Sub-graph result:")
-        logger.debug(f"[WIZARD_NODE]   current_question={result.get('current_question')}")
-        logger.debug(f"[WIZARD_NODE]   completed={result.get('completed')}")
-        logger.debug(f"[WIZARD_NODE]   wizard_status={result.get('wizard_status')}")
-        logger.debug(f"[WIZARD_NODE]   response (first 200 chars): {response_content[:200]!r}")
-
-        # --- Envío a API externa ---
-        if result.get("completed"):
-            try:
-                submission = await postulation_service.submit_postulation(
-                    result.get("wizard_responses", {})
-                )
-                logger.info(f"[WIZARD_NODE] Postulation submitted to external API: {submission}")
-            except Exception as e:
-                logger.error(f"[WIZARD_NODE] Error submitting postulation to external API: {e}", exc_info=True)
+        logger.debug("[WIZARD_NODE] Sub-graph result:")
+        logger.debug("[WIZARD_NODE]   current_question=%s", result.get("current_question"))
+        logger.debug("[WIZARD_NODE]   completed=%s", result.get("completed"))
+        logger.debug("[WIZARD_NODE]   wizard_status=%s", result.get("wizard_status"))
+        logger.debug("[WIZARD_NODE]   response (first 200 chars): %r", response_content[:200])
 
         # --- Persistencia en DB ---
         conv_id = state.get("conversation_id")
@@ -133,41 +121,41 @@ async def __call__(self, state: ConversationState) -> ConversationState:
                 except Exception:
                     await db_session.rollback()
                     raise
-        except Exception as e:
-            logger.error(f"[WIZARD_NODE] Error al persistir en DB: {e}", exc_info=True)
+        except Exception as exc:
+            logger.error("[WIZARD_NODE] Error al persistir en DB: %s", exc, exc_info=True)
 
         # --- Enviar al Backoffice API cuando el wizard termina ---
         logger.info(
-            "[WIZARD_NODE] Evaluando envío al Backoffice: completed=%s, has_wizard_responses=%s, email=%s",
+            "[WIZARD_NODE] Evaluando envio al Backoffice: completed=%s, has_wizard_responses=%s, email=%s",
             bool(result.get("completed")),
             bool(wizard_responses),
             email,
         )
 
         if result.get("completed") and wizard_responses:
             logger.info(
-                "[WIZARD_NODE] Iniciando envío al Backoffice para email=%s con %d campos en wizard_responses",
+                "[WIZARD_NODE] Iniciando envio al Backoffice para email=%s con %d campos en wizard_responses",
                 email,
                 len(wizard_responses),
             )
             try:
                 id_emp, id_caso = await send_postulation_to_backoffice(wizard_responses)
                 logger.info(
-                    "[WIZARD_NODE] Postulación enviada al backoffice: id_emprendedor=%s, id_caso=%s",
+                    "[WIZARD_NODE] Postulacion enviada al backoffice: id_emprendedor=%s, id_caso=%s",
                     id_emp,
                     id_caso,
                 )
             except BackofficeIntegrationDisabled:
-                logger.debug("[WIZARD_NODE] Integración backoffice desactivada, omitiendo envío.")
-            except Exception as e:
+                logger.debug("[WIZARD_NODE] Integracion backoffice desactivada, omitiendo envio.")
+            except Exception as exc:
                 logger.error(
-                    "[WIZARD_NODE] Error al enviar postulación al backoffice: %s",
-                    e,
+                    "[WIZARD_NODE] Error al enviar postulacion al backoffice: %s",
+                    exc,
                     exc_info=True,
                 )
         else:
             logger.debug(
-                "[WIZARD_NODE] No se envía al Backoffice: completed=%s, has_wizard_responses=%s",
+                "[WIZARD_NODE] No se envia al Backoffice: completed=%s, has_wizard_responses=%s",
                 bool(result.get("completed")),
                 bool(wizard_responses),
             )
@@ -176,9 +164,7 @@ async def __call__(self, state: ConversationState) -> ConversationState:
             **state,
             "wizard_state": result,
             "messages": result.get("messages", []),
-            "agent_context": {
-                "response": response_content
-            },
+            "agent_context": {"response": response_content},
             "conversation_id": conv_id,
         }
 
@@ -191,5 +177,5 @@ async def __call__(self, state: ConversationState) -> ConversationState:
 
 
 async def handle_wizard_flow(state: ConversationState) -> ConversationState:
-    """Función wrapper para LangGraph."""
+    """Funcion wrapper para LangGraph."""
     return await wizard_agent(state)
diff --git a/app/services/backoffice_service.py b/app/services/backoffice_service.py
@@ -5,6 +5,7 @@
 Usado cuando el wizard de postulación termina (estado COMPLETED).
 """
 
+import json
 import logging
 import os
 from typing import Any
@@ -20,6 +21,21 @@
 BACKOFFICE_ADMIN_PASSWORD = os.getenv("BACKOFFICE_ADMIN_PASSWORD", "admin123")
 
 
+def _read_default_id_estado() -> int:
+    raw = (os.getenv("BACKOFFICE_DEFAULT_ID_ESTADO") or "1").strip()
+    try:
+        return int(raw)
+    except ValueError:
+        logger.warning(
+            "[BACKOFFICE] BACKOFFICE_DEFAULT_ID_ESTADO invalido=%r, se usa 1 por defecto.",
+            raw,
+        )
+        return 1
+
+
+BACKOFFICE_DEFAULT_ID_ESTADO = _read_default_id_estado()
+
+
 def _parse_full_name(full_name: str) -> tuple[str, str]:
     """Convierte 'Apellido, Nombre' o 'Nombre Apellido' en (nombre, apellido)."""
     if not (full_name or full_name.strip()):
@@ -38,7 +54,7 @@ def _parse_full_name(full_name: str) -> tuple[str, str]:
 
 def _parse_location(location: str) -> tuple[str, str]:
     """Intenta extraer país y ciudad de un string 'País, Ciudad' o similar."""
-    if not (location or location.strip()):
+    if not location or not location.strip():
         return "", ""
     s = location.strip()
     if "," in s:
@@ -47,6 +63,59 @@ def _parse_location(location: str) -> tuple[str, str]:
     return s, ""
 
 
+def _resolve_id_convocatoria(id_convocatoria: int | None) -> int | None:
+    """Resolve id_convocatoria from argument or env, if present and valid."""
+    if id_convocatoria is not None:
+        return id_convocatoria
+
+    raw = (os.getenv("BACKOFFICE_ID_CONVOCATORIA") or "").strip()
+    if not raw:
+        return None
+
+    try:
+        return int(raw)
+    except ValueError:
+        logger.warning(
+            "[BACKOFFICE] BACKOFFICE_ID_CONVOCATORIA invalido=%r, se ignora.",
+            raw,
+        )
+        return None
+
+
+def _build_caso_description(wizard_responses: dict[str, Any]) -> str:
+    """Build a non-empty case description from wizard fields."""
+    desc_parts = []
+    if wizard_responses.get("problem_description"):
+        desc_parts.append(f"Problema: {str(wizard_responses.get('problem_description'))[:1000]}")
+    if wizard_responses.get("solution_description"):
+        desc_parts.append(f"Solucion: {str(wizard_responses.get('solution_description'))[:1000]}")
+    if wizard_responses.get("motivation"):
+        desc_parts.append(f"Motivacion: {str(wizard_responses.get('motivation'))[:500]}")
+    if wizard_responses.get("additional_comments"):
+        desc_parts.append(f"Comentarios: {str(wizard_responses.get('additional_comments'))[:1000]}")
+
+    if desc_parts:
+        return "\n\n".join(desc_parts)
+    return "Postulacion generada desde ChatBot."
+
+
+def _sanitize_chatbot_data(wizard_responses: dict[str, Any]) -> dict[str, Any]:
+    """Keep JSON-serializable values for datos_chatbot."""
+    sanitized: dict[str, Any] = {}
+    for key, value in (wizard_responses or {}).items():
+        if value is None or value == "":
+            continue
+        if isinstance(value, (str, int, float, bool, list, dict)):
+            sanitized[key] = value
+            continue
+        try:
+            json.dumps(value)
+            sanitized[key] = value
+        except (TypeError, ValueError):
+            sanitized[key] = str(value)
+    return sanitized
+
+
 def build_emprendedor_payload(wizard_responses: dict[str, Any]) -> dict[str, Any]:
     """Mapea wizard_responses al body de POST /api/v1/emprendedores/."""
     full_name = (wizard_responses.get("full_name") or "").strip()
@@ -97,8 +166,8 @@ def build_caso_payload(
     id_convocatoria: int | None = None,
 ) -> dict[str, Any]:
     """Mapea wizard_responses al body de POST /api/v1/casos/."""
-    # nombre_caso: usar problema/idea si existe, sino nombre genérico
-    nombre_caso = "Postulación desde ChatBot"
+    # nombre_caso: usar problema/idea si existe, sino nombre generico
+    nombre_caso = "Postulacion desde ChatBot"
     if wizard_responses.get("problem_description"):
         raw = str(wizard_responses.get("problem_description"))[:200]
         nombre_caso = raw if raw else nombre_caso
@@ -109,26 +178,25 @@ def build_caso_payload(
     payload: dict[str, Any] = {
         "nombre_caso": nombre_caso[:200],
         "id_emprendedor": id_emprendedor,
+        "descripcion": _build_caso_description(wizard_responses),
+        "consentimiento_datos": True,
+        "id_estado": BACKOFFICE_DEFAULT_ID_ESTADO,
     }
-    # descripcion: resumen opcional
-    desc_parts = []
-    if wizard_responses.get("solution_description"):
-        desc_parts.append(str(wizard_responses.get("solution_description"))[:1000])
-    if wizard_responses.get("motivation"):
-        desc_parts.append(f"Motivación: {str(wizard_responses.get('motivation'))[:500]}")
-    if desc_parts:
-        payload["descripcion"] = "\n\n".join(desc_parts)
-    # datos_chatbot: respuestas estructuradas del wizard (recomendado por la integración)
-    datos: dict[str, Any] = {k: v for k, v in wizard_responses.items() if v is not None and v != ""}
+
+    # datos_chatbot: respuestas estructuradas del wizard (recomendado por la integracion)
+    datos = _sanitize_chatbot_data(wizard_responses)
     if datos:
         payload["datos_chatbot"] = datos
-    if id_convocatoria is not None:
-        payload["id_convocatoria"] = id_convocatoria
+
+    resolved_convocatoria = _resolve_id_convocatoria(id_convocatoria)
+    if resolved_convocatoria is not None:
+        payload["id_convocatoria"] = resolved_convocatoria
 
     logger.debug(
-        "[BACKOFFICE] build_caso_payload: id_emprendedor=%s, id_convocatoria=%s, keys=%s",
+        "[BACKOFFICE] build_caso_payload: id_emprendedor=%s, id_convocatoria=%s, id_estado=%s, keys=%s",
         id_emprendedor,
-        id_convocatoria,
+        resolved_convocatoria,
+        payload.get("id_estado"),
         list(payload.keys()),
     )
 
@@ -172,12 +240,14 @@ async def send_postulation_to_backoffice(
     """
     Ejecuta el flujo: login -> crear emprendedor -> crear caso.
     Devuelve (id_emprendedor, id_caso).
-    Lanza excepción si la API no está configurada o falla.
+    Lanza excepcion si la API no esta configurada o falla.
     """
+    resolved_convocatoria = _resolve_id_convocatoria(id_convocatoria)
+
     logger.info(
         "[BACKOFFICE] send_postulation_to_backoffice llamado: base_url=%s, id_convocatoria=%s, total_campos_respuestas=%s",
         BACKOFFICE_BASE_URL,
-        id_convocatoria,
+        resolved_convocatoria,
         len(wizard_responses or {}),
     )
     disabled = os.getenv("BACKOFFICE_INTEGRATION_ENABLED", "true").lower() in ("0", "false", "no")
@@ -192,7 +262,7 @@ async def send_postulation_to_backoffice(
     async with aiohttp.ClientSession() as session:
         token = await _get_access_token(session)
         headers["Authorization"] = f"Bearer {token}"
-        logger.debug("[BACKOFFICE] Autenticado contra Backoffice, iniciando creación de emprendedor.")
+        logger.debug("[BACKOFFICE] Autenticado contra Backoffice, iniciando creacion de emprendedor.")
 
         # 1) Crear emprendedor
         emprendedor_body = build_emprendedor_payload(wizard_responses)
@@ -223,7 +293,7 @@ async def send_postulation_to_backoffice(
         logger.info("[BACKOFFICE] Emprendedor creado id_emprendedor=%s", id_emprendedor)
 
         # 2) Crear caso
-        caso_body = build_caso_payload(wizard_responses, id_emprendedor, id_convocatoria)
+        caso_body = build_caso_payload(wizard_responses, id_emprendedor, resolved_convocatoria)
         url_caso = f"{BACKOFFICE_BASE_URL}{BACKOFFICE_API_PREFIX}/casos/"
         logger.debug(
             "[BACKOFFICE] POST /casos: url=%s, payload_keys=%s",
