Merge pull request #28 from ucudal/copilot/sub-pr-26

Fix duplicate conditional edge causing workflow routing failure

Author: NicoWagner2005

RAGManager/app/agents/graph.py

@@ -6,27 +6,27 @@
     agent_host,
     context_builder,
     fallback,
-    guard,
+    guard_inicial,
+    guard_final,
     parafraseo,
     retriever,
 )
 from app.agents.state import AgentState
-from app.agents.routing import route_after_guard
+from app.agents.routing import route_after_guard, route_after_guard_final
 
 def create_agent_graph() -> StateGraph:
     """
     Create and configure the LangGraph agent graph.
 
     The graph implements the following flow:
     1. START -> agent_host (Nodo 1)
-    2. agent_host -> guard (Nodo 2)
-    3. guard -> [conditional] -> fallback (Nodo 3) or END
-    4. fallback -> parafraseo (Nodo 4)
-    5. parafraseo -> retriever (Nodo 5)
-    6. retriever -> context_builder (Nodo 6)
-    7. context_builder -> generator (Nodo 7)
-    8. generator -> fallback (Nodo 8)
-    9. fallback -> [conditional] -> END (with final_response) or END (with error)
+    2. agent_host -> guard_inicial (Nodo 2)
+    3. guard_inicial -> [conditional] -> fallback (if malicious) or parafraseo (if valid)
+    4. parafraseo -> retriever (Nodo 5)
+    5. retriever -> context_builder (Nodo 6)
+    6. context_builder -> guard_final (Nodo 7)
+    7. guard_final -> [conditional] -> fallback (if risky/PII detected) or END (if valid)
+    8. fallback -> END
 
     Returns:
         Configured StateGraph instance ready for execution
@@ -36,7 +36,8 @@ def create_agent_graph() -> StateGraph:
 
     # Add nodes
     workflow.add_node("agent_host", agent_host)
-    workflow.add_node("guard", guard)
+    workflow.add_node("guard_inicial", guard_inicial)
+    workflow.add_node("guard_final", guard_final)
     workflow.add_node("fallback", fallback)
     workflow.add_node("parafraseo", parafraseo)
     workflow.add_node("retriever", retriever)
@@ -46,12 +47,12 @@ def create_agent_graph() -> StateGraph:
     # Start -> agent_host
     workflow.add_edge(START, "agent_host")
 
-    # agent_host -> guard
-    workflow.add_edge("agent_host", "guard")
+    # agent_host -> guard_inicial
+    workflow.add_edge("agent_host", "guard_inicial")
 
-    # guard -> conditional routing
+    # guard_inicial -> conditional routing (first guard check)
     workflow.add_conditional_edges(
-        "guard",
+        "guard_inicial",
         route_after_guard,
         {
             "malicious": "fallback",  # go to fallback if malicious
@@ -65,18 +66,20 @@ def create_agent_graph() -> StateGraph:
     # retriever -> context_builder
     workflow.add_edge("retriever", "context_builder")
 
-    # context_builder -> guard
-    workflow.add_edge("context_builder", "guard")
+    # context_builder -> guard_final
+    workflow.add_edge("context_builder", "guard_final")
 
-    # guard -> conditional routing
+    # guard_final -> conditional routing (second guard check for PII)
     workflow.add_conditional_edges(
-        "guard",
-        route_after_guard,
+        "guard_final",
+        route_after_guard_final,
         {
-            "malicious": "fallback",  # go to fallback if malicious
+            "risky": "fallback",  # go to fallback if risky (PII detected)
             "continue": END,  # if there's no error ends
         },
     )
+
+    # fallback -> END
     workflow.add_edge("fallback", END)
     # Compile the graph
     return workflow.compile()

RAGManager/app/agents/nodes/__init__.py

@@ -3,13 +3,15 @@
 from app.agents.nodes.agent_host import agent_host
 from app.agents.nodes.context_builder import context_builder
 from app.agents.nodes.fallback import fallback
-from app.agents.nodes.guard import guard
+from app.agents.nodes.guard_inicial import guard_inicial
+from app.agents.nodes.guard_final import guard_final
 from app.agents.nodes.parafraseo import parafraseo
 from app.agents.nodes.retriever import retriever
 
 __all__ = [
     "agent_host",
-    "guard",
+    "guard_inicial",
+    "guard_final",
     "fallback",
     "parafraseo",
     "retriever",

RAGManager/app/agents/nodes/guard.py

@@ -0,0 +1,5 @@
+"""Guard node - alias to guard_inicial for backward compatibility."""
+
+from app.agents.nodes.guard_inicial import guard_inicial as guard
+
+__all__ = ["guard"]

RAGManager/app/agents/routing.py

@@ -18,3 +18,20 @@ def route_after_guard(state: AgentState) -> str:
     if state.get("is_malicious", False):
         return "malicious"
     return "continue"
+
+
+def route_after_guard_final(state: AgentState) -> str:
+    """
+    Route after Guard Final node validation (PII detection in generated response).
+
+    Determines the next step based on whether the generated response was flagged as risky (PII detected).
+
+    Args:
+        state: Current agent state
+
+    Returns:
+        "risky" if the response contains PII, "continue" otherwise
+    """
+    if state.get("is_risky", False):
+        return "risky"
+    return "continue"