Skip to content

Conversation

@calebpitan
Copy link
Collaborator

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

@codesandbox
Copy link

codesandbox bot commented Jun 29, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2025

⚠️ No Changeset found

Latest commit: 82864d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 3:30pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. plugin:code-block labels Jun 29, 2025
@calebpitan
Copy link
Collaborator Author

calebpitan commented Jun 29, 2025

I'd love to explore a more maintainable way to do this as the classnames have become bloated for now.

I think a better approach will be to specify code theme colors in the tailwindcss stylesheet, for both light and dark scheme.

What do you think?

@zbeyens @felixfeng33

@zbeyens
Copy link
Member

zbeyens commented Jun 30, 2025

Thanks for the PR! That could work by updating the shadcn registry item.

@zbeyens
Copy link
Member

zbeyens commented Jun 30, 2025

@claude changelog + could you update -static version

@claude
Copy link
Contributor

claude bot commented Jun 30, 2025

Claude finished @zbeyens's task —— View job


I've completed the requested updates to the changelog and -static version for the dark theme code-block changes.

Todo List:

  • Read the code-block-node.tsx changes to understand the dark theme implementation
  • Check for a -static version of the component
  • Update docs/components/changelog.mdx with the new feature
  • Update the -static version to match the changes
  • Commit all changes

Changes Made:

  1. Updated docs/components/changelog.mdx:

  2. Updated apps/www/src/registry/ui/code-block-node-static.tsx:

    • Added dark theme classes to match the main component, including:
      • dark:**:[.hljs-addition]:bg-[#0d1117] dark:**:[.hljs-addition]:text-[#34d058]
      • And all other dark theme syntax highlighting colors

Note: Since this PR is from a fork, I cannot push these changes directly. The PR author (@calebpitan) or a maintainer will need to apply these changes to the PR branch.

@zbeyens zbeyens marked this pull request as draft June 30, 2025 11:41
@zbeyens zbeyens marked this pull request as ready for review June 30, 2025 15:21
@zbeyens zbeyens merged commit ac25821 into udecode:main Jun 30, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin:code-block size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants