Fix VerifyToken compilation under OTP 28 by allowing binary scheme_reg (#739)

Author: ptitmouton

lib/guardian/plug/verify_header.ex

@@ -108,8 +108,7 @@ if Code.ensure_loaded?(Plug) do
     end
 
     defp put_scheme_reg(scheme, opts) do
-      {:ok, reg} = Regex.compile("#{scheme}\:?\s+(.*)$", "i")
-      Keyword.put(opts, :scheme_reg, reg)
+      Keyword.put(opts, :scheme_reg, "#{scheme}\:?\s+(.*)$")
     end
 
     defp get_scheme(opts) do
@@ -163,7 +162,12 @@ if Code.ensure_loaded?(Plug) do
     defp fetch_token_from_header(_, _, []), do: :no_token_found
 
     defp fetch_token_from_header(conn, opts, [token | tail]) do
-      reg = Keyword.get(opts, :scheme_reg, ~r/^(.*)$/)
+      reg =
+        case Keyword.get(opts, :scheme_reg, ~r/^(.*)$/) do
+          %Regex{} = reg -> reg
+          reg_str -> Regex.compile!(reg_str, "i")
+        end
+
       trimmed_token = String.trim(token)
 
       case Regex.run(reg, trimmed_token) do

test/guardian/plug/verify_header_test.exs

@@ -129,10 +129,35 @@ defmodule Guardian.Plug.VerifyHeaderTest do
 
   test "getting the scheme config" do
     opts = VerifyHeader.init(scheme: "Bearer")
-    assert opts[:scheme_reg] == ~r/Bearer:? +(.*)$/i
+    assert opts[:scheme_reg] == "Bearer:? +(.*)$"
 
     opts = VerifyHeader.init(scheme: "Basic")
-    assert opts[:scheme_reg] == ~r/Basic:? +(.*)$/i
+    assert opts[:scheme_reg] == "Basic:? +(.*)$"
+  end
+
+  test "correctly reading the token from the header", ctx do
+    conn =
+      :get
+      |> conn("/")
+      |> put_req_header("authorization", "Basic #{ctx.token}")
+      |> VerifyHeader.call(
+        Keyword.merge(VerifyHeader.init(scheme: "Basic"), module: ctx.impl, error_handler: ctx.handler)
+      )
+
+    refute conn.status == 401
+    assert Guardian.Plug.current_token(conn) == ctx.token
+  end
+
+  test "ignoring token from header with non-matching scheme", ctx do
+    conn =
+      :get
+      |> conn("/")
+      |> put_req_header("authorization", "Bearer #{ctx.token}")
+      |> VerifyHeader.call(
+        Keyword.merge(VerifyHeader.init(scheme: "Basic"), module: ctx.impl, error_handler: ctx.handler)
+      )
+
+    refute Guardian.Plug.current_token(conn) == ctx.token
   end
 
   test "with a token and mismatching claims", ctx do