Most hook promise rejections are unhandled

[haines]

Description
Most of the hook invocations are not guarded with .catch() or try-await-catch, so promise rejections are unhandled. This causes a server crash by default.

Steps to reproduce the bug
Steps to reproduce the behavior:

1. Return a rejected promise from a hook e.g. onStoreDocument
2. Server process crashes due to unhandled rejection

Expected behavior
Errors should be handled appropriately.

[shincurry]

I also encountered a similar issue where I used a database extension to fetch and store Yjs document data from MySQL.

MySQL sometimes throws an error (unable to "insert on duplicate", "upsert"), which will cause the entire Node.js server instance to crash.

[timreinkeaxios]

I ran into this myself. Note that there's an undocumented escape hatch:

hocuspocus/packages/server/src/Hocuspocus.ts

Lines 538 to 540 in edd7034

	if (error?.message) {
	throw error
	}

If your error does not have a message field, it will be 'handled'. Of course, then you're left with an unsaved document and need to solve that somehow.

This is why the redis extension doesn't crash the server when it can't a lock for the document.

I'm not posting to discount the issue, just highlight something you might be able to use in the meantime. I agree there should be some documented way for hooks to fail without crashing. And, for onStoreDocument in particular, maybe there is some API / options for how to handle when a document fails to save (e.g. automatically scheduling a retry later).

[mahendra1390]

@timreinkeaxios @JannikStreek is there any fix for this I am getting this error

Caught error during storeDocumentHooks ExecutionError: The operation was unable to achieve a quorum during its retry window.
    at Redlock._execute (/home/mahendra/projects/yjs-collab-server/node_modules/@sesamecare-oss/redlock/src/index.ts:347:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5) {
  attempts: [
    Promise {
      [Object],
      [Symbol(async_id_symbol)]: 9011,
      [Symbol(trigger_async_id_symbol)]: 8996,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {
      [Object],
      [Symbol(async_id_symbol)]: 9038,
      [Symbol(trigger_async_id_symbol)]: 9031,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {
      [Object],
      [Symbol(async_id_symbol)]: 9053,
      [Symbol(trigger_async_id_symbol)]: 9046,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {
      [Object],
      [Symbol(async_id_symbol)]: 9068,
      [Symbol(trigger_async_id_symbol)]: 9061,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {
      [Object],
      [Symbol(async_id_symbol)]: 9175,
      [Symbol(trigger_async_id_symbol)]: 9151,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {
      [Object],
      [Symbol(async_id_symbol)]: 9245,
      [Symbol(trigger_async_id_symbol)]: 9186,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {
      [Object],
      [Symbol(async_id_symbol)]: 9269,
      [Symbol(trigger_async_id_symbol)]: 9261,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {
      [Object],
      [Symbol(async_id_symbol)]: 9284,
      [Symbol(trigger_async_id_symbol)]: 9277,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {
      [Object],
      [Symbol(async_id_symbol)]: 9336,
      [Symbol(trigger_async_id_symbol)]: 9329,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {
      [Object],
      [Symbol(async_id_symbol)]: 9358,
      [Symbol(trigger_async_id_symbol)]: 9351,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {
      [Object],
      [Symbol(async_id_symbol)]: 9402,
      [Symbol(trigger_async_id_symbol)]: 9394,
      [Symbol(kResourceStore)]: undefined
    }
  ]
}
node:internal/process/promises:394
    triggerUncaughtException(err, true /* fromPromise */);
    ^

ExecutionError: The operation was unable to achieve a quorum during its retry window.
    at Redlock._execute (/home/mahendra/projects/yjs-collab-server/node_modules/@sesamecare-oss/redlock/src/index.ts:347:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5) {
  attempts: [
    Promise {
      {
        membershipSize: 1,
        quorumSize: 1,
        votesFor: Set(0) {},
        votesAgainst: Map(1) {
          Commander {
            options: [Object],
            scriptsSet: [Object],
            addedBuiltinSet: Set(0) {},
            status: 'ready',
            isCluster: false,
            reconnectTimeout: null,
            connectionEpoch: 1,
            retryAttempts: 0,
            manuallyClosing: false,
            _autoPipelines: Map(0) {},
            _runningAutoPipelines: Set(0) {},
            _events: [Object: null prototype] {},
            _eventsCount: 0,
            _maxListeners: undefined,
            commandQueue: [Denque],
            offlineQueue: [Denque],
            connector: [StandaloneConnector],
            condition: [Object],
            stream: [Socket],
            acquireLock: [Function (anonymous)],
            acquireLockBuffer: [Function (anonymous)],
            extendLock: [Function (anonymous)],
            extendLockBuffer: [Function (anonymous)],
            releaseLock: [Function (anonymous)],
            releaseLockBuffer: [Function (anonymous)],
            [Symbol(shapeMode)]: false,
            [Symbol(kCapture)]: false
          } => ResourceLockedError: The operation was applied to: 0 of the 1 requested resources.
              at Redlock._attemptOperationOnClient (/home/mahendra/projects/yjs-collab-server/node_modules/@sesamecare-oss/redlock/src/index.ts:446:15)
              at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
        }
      },
      [Symbol(async_id_symbol)]: 9011,
      [Symbol(trigger_async_id_symbol)]: 8996,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {
      {
        membershipSize: 1,
        quorumSize: 1,
        votesFor: Set(0) {},
        votesAgainst: Map(1) {
          Commander {
            options: [Object],
            scriptsSet: [Object],
            addedBuiltinSet: Set(0) {},
            status: 'ready',
            isCluster: false,
            reconnectTimeout: null,
            connectionEpoch: 1,
            retryAttempts: 0,
            manuallyClosing: false,
            _autoPipelines: Map(0) {},
            _runningAutoPipelines: Set(0) {},
            _events: [Object: null prototype] {},
            _eventsCount: 0,
            _maxListeners: undefined,
            commandQueue: [Denque],
            offlineQueue: [Denque],
            connector: [StandaloneConnector],
            condition: [Object],
            stream: [Socket],
            acquireLock: [Function (anonymous)],
            acquireLockBuffer: [Function (anonymous)],
            extendLock: [Function (anonymous)],
            extendLockBuffer: [Function (anonymous)],
            releaseLock: [Function (anonymous)],
            releaseLockBuffer: [Function (anonymous)],
            [Symbol(shapeMode)]: false,
            [Symbol(kCapture)]: false
          } => ResourceLockedError: The operation was applied to: 0 of the 1 requested resources.
              at Redlock._attemptOperationOnClient (/home/mahendra/projects/yjs-collab-server/node_modules/@sesamecare-oss/redlock/src/index.ts:446:15)
              at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
        }
      },
      [Symbol(async_id_symbol)]: 9038,
      [Symbol(trigger_async_id_symbol)]: 9031,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {
      {
        membershipSize: 1,
        quorumSize: 1,
        votesFor: Set(0) {},
        votesAgainst: Map(1) {
          Commander {
            options: [Object],
            scriptsSet: [Object],
            addedBuiltinSet: Set(0) {},
            status: 'ready',
            isCluster: false,
            reconnectTimeout: null,
            connectionEpoch: 1,
            retryAttempts: 0,
            manuallyClosing: false,
            _autoPipelines: Map(0) {},
            _runningAutoPipelines: Set(0) {},
            _events: [Object: null prototype] {},
            _eventsCount: 0,
            _maxListeners: undefined,
            commandQueue: [Denque],
            offlineQueue: [Denque],
            connector: [StandaloneConnector],
            condition: [Object],
            stream: [Socket],
            acquireLock: [Function (anonymous)],
            acquireLockBuffer: [Function (anonymous)],
            extendLock: [Function (anonymous)],
            extendLockBuffer: [Function (anonymous)],
            releaseLock: [Function (anonymous)],
            releaseLockBuffer: [Function (anonymous)],
            [Symbol(shapeMode)]: false,
            [Symbol(kCapture)]: false
          } => ResourceLockedError: The operation was applied to: 0 of the 1 requested resources.
              at Redlock._attemptOperationOnClient (/home/mahendra/projects/yjs-collab-server/node_modules/@sesamecare-oss/redlock/src/index.ts:446:15)
              at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
        }
      },
      [Symbol(async_id_symbol)]: 9053,
      [Symbol(trigger_async_id_symbol)]: 9046,
      [Symbol(kResourceStore)]: undefined
    },
    Promise {