Skip to content

Possible crash after switching from fast-deep-equal to fast-equals #7482

@krehwell

Description

@krehwell

Affected Packages

@tiptap/react

Version(s)

3.12.1

Bug Description

Hi

On some pages (nextjs app router), the app crashes with the following error reported by Sentry:

RangeError: Maximum call stack size exceeded

It mentioned it is from fast-equals in @tiptap/react ever since the update on this commit:
5db9bc1

our solution so far is to patch @tiptap/react -> useEditorState to use circularDeepEqual as the equalityFn

-import { deepEqual } from 'fast-equals'
+import { circularDeepEqual } from 'fast-equals'

Browser Used

Chrome

Code Example URL

No response

Expected Behavior

The app should run just fine. No crashing

Additional Context (Optional)

No response

Dependency Updates

  • Yes, I've updated all my dependencies.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Open SourceThe issue or pull reuqest is related to the open source packages of Tiptap.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions