Merge branch 'SmallFixes_2025_01' into 'master'

Small unsorted fixes

See merge request ogs/ogs!5394

Author: Dmitri Naumov

Applications/DataExplorer/VtkVis/VtkCompositeContourFilter.cpp

@@ -51,7 +51,11 @@ void VtkCompositeContourFilter::init()
         vtkPointData* pointData = dataSet->GetPointData();
         if (pointData)
         {
-            pointData->GetScalars()->GetRange(range);
+            auto* scalars = pointData->GetScalars();
+            if (scalars)
+            {
+                scalars->GetRange(range);
+            }
         }
     }
     else

Applications/DataExplorer/VtkVis/VtkVisImageItem.cpp

@@ -63,20 +63,37 @@ VtkVisImageItem::~VtkVisImageItem()
 
 void VtkVisImageItem::Initialize(vtkRenderer* renderer)
 {
-    auto* img = dynamic_cast<vtkImageAlgorithm*>(_algorithm);
-    img->Update();
-    // VtkGeoImageSource* img = dynamic_cast<VtkGeoImageSource*>(_algorithm);
+    auto* image = dynamic_cast<vtkImageAlgorithm*>(_algorithm);
+    if (!image)
+    {
+        OGSError::box("Cast to image failed.");
+        return;
+    }
+    image->Update();
 
     double origin[3];
     double spacing[3];
     double range[2];
-    img->GetOutput()->GetOrigin(origin);
-    img->GetOutput()->GetSpacing(spacing);
-    // img->getRange(range);
-    img->GetOutput()->GetPointData()->GetScalars()->GetRange(range);
+    vtkImageData* image_data = image->GetOutput();
+    if (!image_data)
+    {
+        OGSError::box("GetOutput() - Image could not be initialized.");
+        return;
+    }
+    image_data->GetOrigin(origin);
+    image_data->GetSpacing(spacing);
+    vtkPointData* point_data = image_data->GetPointData();
+    if (point_data)
+    {
+        auto* scalars = point_data->GetScalars();
+        if (scalars)
+        {
+            scalars->GetRange(range);
+        }
+    }
     vtkImageShiftScale* scale = vtkImageShiftScale::New();
     scale->SetOutputScalarTypeToUnsignedChar();
-    scale->SetInputConnection(img->GetOutputPort());
+    scale->SetInputConnection(image->GetOutputPort());
     scale->SetShift(-range[0]);
     scale->SetScale(255.0 / (range[1] - range[0]));
 

BaseLib/Error.h

@@ -23,10 +23,11 @@
     }
 #else  // OGS_FATAL_ABORT
 #include <stdexcept>
-#define OGS_FATAL(...)                                                      \
-    {                                                                       \
-        BaseLib::console->critical("{}:{} {}() ", __FILE__, __LINE__,       \
-                                   __FUNCTION__, fmt::format(__VA_ARGS__)); \
-        throw std::runtime_error(fmt::format(__VA_ARGS__));                 \
+#define OGS_FATAL(...)                                                \
+    {                                                                 \
+        auto const formatted_va_args = fmt::format(__VA_ARGS__);      \
+        BaseLib::console->critical("{}:{} {}() ", __FILE__, __LINE__, \
+                                   __FUNCTION__, formatted_va_args);  \
+        throw std::runtime_error(formatted_va_args);                  \
     }
 #endif  // OGS_FATAL_ABORT

MeshLib/IO/XDMF/transformData.cpp

@@ -396,7 +396,6 @@ std::pair<std::vector<std::size_t>, ParentDataType> transformToXDMFTopology(
             {
                 values.push_back(2);
             }
-            // LINE3 maps to ParentDataType::EDGE_3 -> no special care required
             push_cellnode_ids_to_vector(cell);
         }
     }

MeshLib/IO/XDMF/transformData.h

@@ -52,7 +52,7 @@ XdmfHdfData transformGeometry(MeshLib::Mesh const& mesh, double const* data_ptr,
  * \brief  Create meta data for topology used for HDF5 and XDMF
  * \param values actual topology values to get size and memory location
  * \param parent_data_type XDMF topological element data types as listed in the
- * enum ParentDataTypei
+ * enum ParentDataType
  * \param n_files specifies the number of files. If greater
  * than 1 it groups the data of each process to n_files \param chunk_size_bytes
  * Data will be split into chunks. The parameter specifies the size (in bytes)

web/content/docs/benchmarks/liquid-flow/raster-parameter-based-boundary-conditions/index.md

@@ -37,14 +37,14 @@ condition based on the raster parameter. We start with homogeneous parabolic
 problem:
 $$
 \begin{equation}
-s\\;\frac{\partial p}{\partial t} + k\\; \Delta p = q(t,x) \quad \text{in }\Omega
+s\;\frac{\partial p}{\partial t} + k\; \Delta p = q(t,x) \quad \text{in }\Omega
 \end{equation}
 $$
 w.r.t boundary conditions
 $$
 \eqalign{
 p(t, x) = g_D(t, x) &\quad \text{on }\Gamma_D,\cr
-k\\;{\partial p(x) \over \partial n} = g_N(x) &\quad \text{on }\Gamma_N,
+k\;{\partial p(x) \over \partial n} = g_N(x) &\quad \text{on }\Gamma_N,
 }$$
 
 The domain $\Omega = [0,1]^3$ is a cube. Dirichlet-type boundary conditions are