Cannot upgrade due to TS1183: An implementation cannot be declared in ambient contexts.

[MichaelBitard]

I am trying to upgrade from 3.1.0 to the latest, but it does not work.

If I try the next version (3.2.0) the build fail with a bunch of

node_modules/stream-chain/src/typed-streams.d.ts:9:22 - error TS1183: An implementation cannot be declared in ambient contexts.                                                                     
                                                                                                                                                                                                    
9   __streamTypeR(): R {                                                                                                                                                                            
                       ~                                                                                                                                                                            
                                                                                                                                                                                                    
node_modules/stream-chain/src/typed-streams.d.ts:12:22 - error TS1183: An implementation cannot be declared in ambient contexts.                                                                    
                                                                                                                                                                                                    
12   __streamTypeW(): W {
                        ~                                                                         
                                                 
node_modules/stream-chain/src/typed-streams.d.ts:21:22 - error TS1183: An implementation cannot be declared in ambient contexts.

21   __streamTypeR(): R {  
                        ~
                                                 
node_modules/stream-chain/src/typed-streams.d.ts:30:22 - error TS1183: An implementation cannot be declared in ambient contexts.
                                                 
30   __streamTypeR(): R {                                                                         
                        ~                                                                         
                                                 
node_modules/stream-chain/src/typed-streams.d.ts:33:22 - error TS1183: An implementation cannot be declared in ambient contexts.
                                                 
33   __streamTypeW(): W {                                                                         
                        ~           
                                                                                                  
node_modules/stream-chain/src/typed-streams.d.ts:42:22 - error TS1183: An implementation cannot be declared in ambient contexts.
                                                 
42   __streamTypeW(): W {                  
          

From what I understand, these .d.ts files should not have implementations specs in it, but only be empty.

I can make the PR if that's ok, but maybe I'm missing something

It should look like this:

export declare class TypedTransform<W = any, R = W> extends Transform {
  __streamTypeR(): R
  __streamTypeW(): W
}

instead of

export declare class TypedTransform<W = any, R = W> extends Transform {
  __streamTypeR(): R {
    return null as R;
  }
  __streamTypeW(): W {
    return null as W;
  }
}

[uhop]

First of all: how to repro the issue? I plan to work on stream-chain next week and can address the issue.

[MichaelBitard]

My very bad, I usually try to be more precise on this kind of issue.

You can have a look here: https://www.typescriptlang.org/play/?#code/KYDwDg9gTgLgBAE2AYwDYEMrDm9BnPOAFQE8xgEip0A7PAM2gFsAeAdTgF45aSAaOACUucNgD44AbwBQcOAH15eGFnRNS5QQAoAlAC4hU2XLhYYAVyg04Nc6lQ9CggNzGAvscXLV6ssDa6BhwyJqbAFlY2dg74oq5yHm5AA

[uhop]

I committed my current version. Please test the master to see if it works for you now. It may require some trivial changes because I changed some any to unknown, so you may need to cast with as to your type.

If it fixes the problem, I'll release it as 3.4.1. If not, we'll iterate.

[MichaelBitard]

Thanks, I'll test it once it's released

[uhop]

Sure thing. a5282b8 is published as 3.4.1.

[MichaelBitard]

Thanks, stream-chain now does not have build errors anymore, but it conflicts with stream-json definitelytyped types 😢.

I'll look into the type definition.

../../node_modules/@types/stream-json/filters/Pick.d.ts:25:61 - error TS2709: Cannot use namespace 'Chain' as a type.
                                                 
25     function withParser(options: FilterBase.FilterOptions): Chain;
                                                               ~~~~~                                                                                                                                
                                                                                                  
../../node_modules/@types/stream-json/streamers/StreamArray.d.ts:25:62 - error TS2709: Cannot use namespace 'chain' as a type.
                                                                                                  
25     function withParser(options?: StreamBase.StreamOptions): chain;
                                                                ~~~~~
                                                                                                  
                                                                                                  
Found 2 errors in 2 files.                                                                        
                                                 
Errors  Files                                                                                     
     1  ../../node_modules/@types/stream-json/filters/Pick.d.ts:25                        
     1  ../../node_modules/@types/stream-json/streamers/StreamArray.d.ts:25          

[uhop]

Did you try not using definitelytyped types? They are for a different version. Like excluding them from your project?