chore: resolve all eslint errors

Author: christopherthielen

src/directives/uiSref.ts

@@ -168,7 +168,7 @@ export class UISref implements OnChanges {
     this.update();
   }
 
-  ngOnChanges(changes: SimpleChanges): void {
+  ngOnChanges(_changes: SimpleChanges): void {
     this.update();
   }
 

src/directives/uiSrefStatus.ts

@@ -17,7 +17,7 @@ import {
 } from '@uirouter/core';
 
 import { Subscription, Observable, BehaviorSubject, of, from, combineLatest, concat } from 'rxjs';
-import { switchMap, map, tap } from 'rxjs/operators';
+import { switchMap, map } from 'rxjs/operators';
 
 /** @internal */
 interface TransEvt {
@@ -66,7 +66,7 @@ const pathMatches = (target: TargetState): Predicate<PathNode[]> => {
   const paramSchema: Param[] = targetPath
     .map((node) => node.paramSchema)
     .reduce(unnestR, [])
-    .filter((param: Param) => targetParamVals.hasOwnProperty(param.id));
+    .filter((param: Param) => Object.prototype.hasOwnProperty.call(targetParamVals, param.id));
 
   return (path: PathNode[]) => {
     const tailNode = tail(path);

src/directives/uiView.ts

@@ -135,10 +135,12 @@ export class UIView implements OnInit, OnDestroy {
   /** The reference to the component currently inside the viewport */
   readonly _componentRef = signal<ComponentRef<any> | null>(null);
   /** Deregisters the ui-view from the view service */
-  private _deregisterUIView: Function;
-  /** Deregisters the master uiCanExit transition hook */
+  private _deregisterUIView: () => void;
+  /** Deregisters the master uiCanExit transition hook (returns Function from @uirouter/core) */
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   private _deregisterUiCanExitHook: Function;
-  /** Deregisters the master uiOnParamsChanged transition hook */
+  /** Deregisters the master uiOnParamsChanged transition hook (returns Function from @uirouter/core) */
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   private _deregisterUiOnParamsChangedHook: Function;
   /** Data about the this UIView */
   private _uiViewData: ActiveUIView = <any>{};

src/lazyLoad/lazyLoadNgModule.ts

@@ -244,7 +244,7 @@ export function applyComponent<T>(
   const current = stateObject.component;
   stateObject.component = component || current;
   const removed = registry.deregister(stateObject).map((child) => child.self);
-  const children = removed.filter((i) => i.name != stateObject.name);
+  const children = removed.filter((i) => i.name !== stateObject.name);
 
   return { states: [stateObject, ...children] };
 }

src/location/locationConfig.ts

@@ -9,7 +9,7 @@ export class Ng2LocationConfig extends BrowserLocationConfig {
     super(router, is(PathLocationStrategy)(_locationStrategy));
   }
 
-  baseHref(href?: string): string {
+  baseHref(_href?: string): string {
     return this._locationStrategy.getBaseHref();
   }
 }

src/statebuilders/lazyLoad.ts

@@ -1,4 +1,3 @@
-import { LazyLoadResult, Transition, StateDeclaration } from '@uirouter/core'; // has or is using
 import { BuilderFunction, StateObject } from '@uirouter/core';
 import { loadComponent, loadNgModule } from '../lazyLoad/lazyLoadNgModule';
 
@@ -45,7 +44,7 @@ import { loadComponent, loadNgModule } from '../lazyLoad/lazyLoadNgModule';
  * ```
  *
  */
-export function ng2LazyLoadBuilder(state: StateObject, parent: BuilderFunction) {
+export function ng2LazyLoadBuilder(state: StateObject, _parent: BuilderFunction) {
   const loadComponentFn = state['loadComponent'];
   const loadNgModuleFn = state['loadChildren'];
   return loadComponentFn

src/uiRouterConfig.ts

@@ -13,7 +13,7 @@ export function applyModuleConfig(uiRouter: UIRouter, injector: Injector, module
 }
 
 export function applyRootModuleConfig(uiRouter: UIRouter, injector: Injector, module: RootModule) {
-  isDefined(module.deferIntercept) && uiRouter.urlService.deferIntercept(module.deferIntercept);
-  isDefined(module.otherwise) && uiRouter.urlService.rules.otherwise(module.otherwise);
-  isDefined(module.initial) && uiRouter.urlService.rules.initial(module.initial);
+  if (isDefined(module.deferIntercept)) uiRouter.urlService.deferIntercept(module.deferIntercept);
+  if (isDefined(module.otherwise)) uiRouter.urlService.rules.otherwise(module.otherwise);
+  if (isDefined(module.initial)) uiRouter.urlService.rules.initial(module.initial);
 }

test/uiSrefActive/uiSrefActive.spec.ts

@@ -59,7 +59,7 @@ describe('uiSrefActive', () => {
       await router.stateService.go('statea');
       await tick();
       fixture.detectChanges();
-      let classList = des[0].nativeElement.classList;
+      const classList = des[0].nativeElement.classList;
       expect(classList).toContain(activeClasses[0]);
       expect(classList).toContain(activeClasses[1]);
     });

test/uiSrefStatus/uiSrefStatus.spec.ts

@@ -14,7 +14,7 @@ describe('uiSrefStatus', () => {
     standalone: false,
   })
   class TestComponent {
-    updated(event: SrefStatus) {
+    updated(_event: SrefStatus) {
       throw new Error('updated() method must be spied');
     }
   }

test/uiView/resolveBinding.spec.ts

@@ -9,7 +9,9 @@ describe('uiView', () => {
   describe('should map resolve data to inputs', () => {
     @Component({ template: `<h3>hey</h3> `, standalone: false })
     class ManyResolvesComponent {
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
       constructor(@Inject('resolve1') foo, @Inject('Resolve2') bar, @Inject('resolve5') baz) {
+        // eslint-disable-next-line prefer-rest-params
         this.injectedValues = Array.from(arguments);
       }