Template uses 10 years old sinon version

[akudev]

generator-ui5-ts-app/generators/app/templates/webapp/test/unit/unitTests.qunit.html

Line 23 in efc3841

<script src="../../resources/sap/ui/thirdparty/sinon.js"></script>

loads "sinon.js" from UI5's thirdparty folder, which means it's super-old.

[saard]

Also, since the template is using sinon-qunit it will break if you add a later version as "sinon.test" function is not available.
I changed to

<script src="../thirdparty/sinon-17.0.2.js"></script> (I placed the sinon file manually)

and removed the sinon-qunit line

[heimwege]

@saard what's the benefit of using sinon-qunit? I couldn't find any documentation 🤷🏻 At least my qunit tests run perfectly fine without it (using sinon nevertheless)

[saard]

@heimwege no benefit, it's really old.
however, since the template still uses sinon-qunit if you had tests that are using it and you upgrade to a more advanced sinon (while still using the sinon-qunit) they will break.

[heimwege]

@saard thanks for the update. That's good news for me as I'm using the preview middleware for the on-the-fly generation of the test glue code. The sinon-qunit is not part of the template (because I didn't know what it is used for and everything worked perfectly fine without it, so I didn't add it 😄).

So somehow this issue is now linked to #35 🙈

[akudev]

Re-opening to use up-to-date sinon versions with UI5 versions including SAP/openui5@b1737b0