fix(ui5-tooling-modules): avoid width/height property for base classes (#1284)

Author: petermuessig

packages/ui5-tooling-modules/lib/utils/WebComponentRegistry.js

@@ -880,7 +880,7 @@ class RegistryEntry {
 		}
 
 		// cssProperties: [ "width", "height", "display" ]
-		if (!this.#ui5PropertyExistsInParentChain(classDef, "width")) {
+		if (ui5metadata.tag && !this.#ui5PropertyExistsInParentChain(classDef, "width")) {
 			ui5metadata.properties["width"] = {
 				type: "sap.ui.core.CSSSize",
 				mapping: "style",
@@ -905,7 +905,7 @@ class RegistryEntry {
 			});
 		}
 
-		if (!this.#ui5PropertyExistsInParentChain(classDef, "height")) {
+		if (ui5metadata.tag && !this.#ui5PropertyExistsInParentChain(classDef, "height")) {
 			ui5metadata.properties["height"] = {
 				type: "sap.ui.core.CSSSize",
 				mapping: "style",

packages/ui5-tooling-modules/test/__fixtures__/@ui5/webcomponents-base/classes/I18nBundle.json

@@ -1 +1 @@
-{"namespace":"@ui5/webcomponents-base","qualifiedNamespace":"@ui5.webcomponents-base","interfaces":[],"properties":{"text":{"type":"string","mapping":"textContent"},"width":{"type":"sap.ui.core.CSSSize","mapping":"style"},"height":{"type":"sap.ui.core.CSSSize","mapping":"style"}},"aggregations":{},"associations":{},"events":{},"getters":[],"methods":["getText"]}
+{"namespace":"@ui5/webcomponents-base","qualifiedNamespace":"@ui5.webcomponents-base","interfaces":[],"properties":{"text":{"type":"string","mapping":"textContent"}},"aggregations":{},"associations":{},"events":{},"getters":[],"methods":["getText"]}

packages/ui5-tooling-modules/test/__fixtures__/@ui5/webcomponents-base/classes/ItemNavigation.json

@@ -1 +1 @@
-{"namespace":"@ui5/webcomponents-base","qualifiedNamespace":"@ui5.webcomponents-base","interfaces":[],"properties":{"text":{"type":"string","mapping":"textContent"},"width":{"type":"sap.ui.core.CSSSize","mapping":"style"},"height":{"type":"sap.ui.core.CSSSize","mapping":"style"}},"aggregations":{},"associations":{},"events":{},"getters":[],"methods":["setCurrentItem","setRowSize"]}
+{"namespace":"@ui5/webcomponents-base","qualifiedNamespace":"@ui5.webcomponents-base","interfaces":[],"properties":{"text":{"type":"string","mapping":"textContent"}},"aggregations":{},"associations":{},"events":{},"getters":[],"methods":["setCurrentItem","setRowSize"]}

packages/ui5-tooling-modules/test/__fixtures__/@ui5/webcomponents-base/classes/ResizeHandler.json

@@ -1 +1 @@
-{"namespace":"@ui5/webcomponents-base","qualifiedNamespace":"@ui5.webcomponents-base","interfaces":[],"properties":{"text":{"type":"string","mapping":"textContent"},"width":{"type":"sap.ui.core.CSSSize","mapping":"style"},"height":{"type":"sap.ui.core.CSSSize","mapping":"style"}},"aggregations":{},"associations":{},"events":{},"getters":[],"methods":["register","deregister"]}
+{"namespace":"@ui5/webcomponents-base","qualifiedNamespace":"@ui5.webcomponents-base","interfaces":[],"properties":{"text":{"type":"string","mapping":"textContent"}},"aggregations":{},"associations":{},"events":{},"getters":[],"methods":["register","deregister"]}

packages/ui5-tooling-modules/test/__fixtures__/@ui5/webcomponents-base/classes/UI5Element.json

@@ -1 +1 @@
-{"namespace":"@ui5/webcomponents-base","qualifiedNamespace":"@ui5.webcomponents-base","interfaces":[],"properties":{"text":{"type":"string","mapping":"textContent"},"width":{"type":"sap.ui.core.CSSSize","mapping":"style"},"height":{"type":"sap.ui.core.CSSSize","mapping":"style"}},"aggregations":{},"associations":{},"events":{},"getters":["effectiveDir","isUI5Element"],"methods":["onBeforeRendering","onAfterRendering","onEnterDOM","onExitDOM","attachInvalidate","detachInvalidate","onInvalidation","getDomRef","getFocusDomRef","getFocusDomRefAsync","focus","fireEvent","fireDecoratorEvent","getSlottedNodes","attachComponentStateFinalized","detachComponentStateFinalized","getUniqueDependencies","define","getMetadata"]}
+{"namespace":"@ui5/webcomponents-base","qualifiedNamespace":"@ui5.webcomponents-base","interfaces":[],"properties":{"text":{"type":"string","mapping":"textContent"}},"aggregations":{},"associations":{},"events":{},"getters":["effectiveDir","isUI5Element"],"methods":["onBeforeRendering","onAfterRendering","onEnterDOM","onExitDOM","attachInvalidate","detachInvalidate","onInvalidation","getDomRef","getFocusDomRef","getFocusDomRefAsync","focus","fireEvent","fireDecoratorEvent","getSlottedNodes","attachComponentStateFinalized","detachComponentStateFinalized","getUniqueDependencies","define","getMetadata"]}

packages/ui5-tooling-modules/test/__fixtures__/@ui5/webcomponents-base/classes/UI5ElementMetadata.json

@@ -1 +1 @@
-{"namespace":"@ui5/webcomponents-base","qualifiedNamespace":"@ui5.webcomponents-base","interfaces":[],"properties":{"text":{"type":"string","mapping":"textContent"},"width":{"type":"sap.ui.core.CSSSize","mapping":"style"},"height":{"type":"sap.ui.core.CSSSize","mapping":"style"}},"aggregations":{},"associations":{},"events":{},"getters":[],"methods":["validateSlotValue","getPureTag","getTag","hasAttribute","getPropertiesList","getAttributesList","hasSlots","hasIndividualSlots","slotsAreManaged","supportsF6FastNavigation","getProperties","getEvents","getSlots"]}
+{"namespace":"@ui5/webcomponents-base","qualifiedNamespace":"@ui5.webcomponents-base","interfaces":[],"properties":{"text":{"type":"string","mapping":"textContent"}},"aggregations":{},"associations":{},"events":{},"getters":[],"methods":["validateSlotValue","getPureTag","getTag","hasAttribute","getPropertiesList","getAttributesList","hasSlots","hasIndividualSlots","slotsAreManaged","supportsF6FastNavigation","getProperties","getEvents","getSlots"]}

packages/ui5-tooling-modules/test/__fixtures__/@ui5/webcomponents-fiori/classes/NotificationListGroupItem.json

@@ -1 +1 @@
-{"namespace":"@ui5/webcomponents-fiori","qualifiedNamespace":"@ui5.webcomponents-fiori","tag":"ui5-li-notification-group","interfaces":[],"properties":{"collapsed":{"type":"boolean","mapping":"property","defaultValue":false},"growing":{"type":"@ui5.webcomponents.NotificationListGrowingMode","mapping":"property","defaultValue":"None"},"titleText":{"type":"string","mapping":"property"},"read":{"type":"boolean","mapping":"property","defaultValue":false},"loading":{"type":"boolean","mapping":"property","defaultValue":false},"loadingDelay":{"type":"float","mapping":"property","defaultValue":1000}},"aggregations":{"items":{"type":"@ui5.webcomponents-fiori.dist.NotificationListItem","multiple":true}},"associations":{},"events":{"toggle":{"allowPreventDefault":false,"enableEventBubbling":true,"parameters":{}},"loadMore":{"allowPreventDefault":false,"enableEventBubbling":true,"parameters":{}}},"getters":[],"methods":[],"defaultAggregation":"items"}
+{"namespace":"@ui5/webcomponents-fiori","qualifiedNamespace":"@ui5.webcomponents-fiori","tag":"ui5-li-notification-group","interfaces":[],"properties":{"collapsed":{"type":"boolean","mapping":"property","defaultValue":false},"growing":{"type":"@ui5.webcomponents.NotificationListGrowingMode","mapping":"property","defaultValue":"None"},"titleText":{"type":"string","mapping":"property"},"read":{"type":"boolean","mapping":"property","defaultValue":false},"loading":{"type":"boolean","mapping":"property","defaultValue":false},"loadingDelay":{"type":"float","mapping":"property","defaultValue":1000},"width":{"type":"sap.ui.core.CSSSize","mapping":"style"},"height":{"type":"sap.ui.core.CSSSize","mapping":"style"}},"aggregations":{"items":{"type":"@ui5.webcomponents-fiori.dist.NotificationListItem","multiple":true}},"associations":{},"events":{"toggle":{"allowPreventDefault":false,"enableEventBubbling":true,"parameters":{}},"loadMore":{"allowPreventDefault":false,"enableEventBubbling":true,"parameters":{}}},"getters":[],"methods":[],"defaultAggregation":"items"}

packages/ui5-tooling-modules/test/__fixtures__/@ui5/webcomponents-fiori/classes/NotificationListItem.json

@@ -1 +1 @@
-{"namespace":"@ui5/webcomponents-fiori","qualifiedNamespace":"@ui5.webcomponents-fiori","tag":"ui5-li-notification","interfaces":[],"properties":{"wrappingType":{"type":"@ui5.webcomponents.WrappingType","mapping":"property","defaultValue":"None"},"state":{"type":"sap.ui.core.ValueState","mapping":{"formatter":"_mapValueState","parser":"_parseValueState"},"defaultValue":"None"},"showClose":{"type":"boolean","mapping":"property","defaultValue":false},"importance":{"type":"@ui5.webcomponents-fiori.NotificationListItemImportance","mapping":"property","defaultValue":"Standard"},"titleText":{"type":"string","mapping":"property"},"read":{"type":"boolean","mapping":"property","defaultValue":false},"loading":{"type":"boolean","mapping":"property","defaultValue":false},"loadingDelay":{"type":"float","mapping":"property","defaultValue":1000}},"aggregations":{"avatar":{"type":"sap.ui.core.Control","multiple":true,"slot":"avatar"},"menu":{"type":"sap.ui.core.Control","multiple":true,"slot":"menu"},"footnotes":{"type":"sap.ui.core.Control","multiple":true,"slot":"footnotes"},"description":{"type":"sap.ui.core.Control","multiple":true}},"associations":{},"events":{"close":{"allowPreventDefault":false,"enableEventBubbling":true,"parameters":{"item":{"type":"sap.ui.core.Control","types":[{"origType":"HTMLElement","multiple":false,"dedicatedTypes":[{"dtsType":"Control","packageName":"sap/ui/core/Control","moduleType":"module:sap/ui/core/Control","ui5Type":"sap.ui.core.Control","isClass":true}]}],"dtsParamDescription":"the closed item."}}}},"getters":[],"methods":[],"defaultAggregation":"description"}
+{"namespace":"@ui5/webcomponents-fiori","qualifiedNamespace":"@ui5.webcomponents-fiori","tag":"ui5-li-notification","interfaces":[],"properties":{"wrappingType":{"type":"@ui5.webcomponents.WrappingType","mapping":"property","defaultValue":"None"},"state":{"type":"sap.ui.core.ValueState","mapping":{"formatter":"_mapValueState","parser":"_parseValueState"},"defaultValue":"None"},"showClose":{"type":"boolean","mapping":"property","defaultValue":false},"importance":{"type":"@ui5.webcomponents-fiori.NotificationListItemImportance","mapping":"property","defaultValue":"Standard"},"titleText":{"type":"string","mapping":"property"},"read":{"type":"boolean","mapping":"property","defaultValue":false},"loading":{"type":"boolean","mapping":"property","defaultValue":false},"loadingDelay":{"type":"float","mapping":"property","defaultValue":1000},"width":{"type":"sap.ui.core.CSSSize","mapping":"style"},"height":{"type":"sap.ui.core.CSSSize","mapping":"style"}},"aggregations":{"avatar":{"type":"sap.ui.core.Control","multiple":true,"slot":"avatar"},"menu":{"type":"sap.ui.core.Control","multiple":true,"slot":"menu"},"footnotes":{"type":"sap.ui.core.Control","multiple":true,"slot":"footnotes"},"description":{"type":"sap.ui.core.Control","multiple":true}},"associations":{},"events":{"close":{"allowPreventDefault":false,"enableEventBubbling":true,"parameters":{"item":{"type":"sap.ui.core.Control","types":[{"origType":"HTMLElement","multiple":false,"dedicatedTypes":[{"dtsType":"Control","packageName":"sap/ui/core/Control","moduleType":"module:sap/ui/core/Control","ui5Type":"sap.ui.core.Control","isClass":true}]}],"dtsParamDescription":"the closed item."}}}},"getters":[],"methods":[],"defaultAggregation":"description"}

packages/ui5-tooling-modules/test/__fixtures__/@ui5/webcomponents-fiori/classes/SearchItem.json

@@ -1 +1 @@
-{"namespace":"@ui5/webcomponents-fiori","qualifiedNamespace":"@ui5.webcomponents-fiori","tag":"ui5-search-item","interfaces":[],"properties":{"text":{"type":"string","mapping":"property"},"description":{"type":"string","mapping":"property"},"icon":{"type":"string","mapping":"property"},"selected":{"type":"boolean","mapping":"property","defaultValue":false},"scopeName":{"type":"string","mapping":"property"}},"aggregations":{"image":{"type":"sap.ui.core.Control","multiple":true,"slot":"image"}},"associations":{},"events":{"delete":{"allowPreventDefault":false,"enableEventBubbling":false,"parameters":{}}},"getters":[],"methods":[]}
+{"namespace":"@ui5/webcomponents-fiori","qualifiedNamespace":"@ui5.webcomponents-fiori","tag":"ui5-search-item","interfaces":[],"properties":{"text":{"type":"string","mapping":"property"},"description":{"type":"string","mapping":"property"},"icon":{"type":"string","mapping":"property"},"selected":{"type":"boolean","mapping":"property","defaultValue":false},"scopeName":{"type":"string","mapping":"property"},"width":{"type":"sap.ui.core.CSSSize","mapping":"style"},"height":{"type":"sap.ui.core.CSSSize","mapping":"style"}},"aggregations":{"image":{"type":"sap.ui.core.Control","multiple":true,"slot":"image"}},"associations":{},"events":{"delete":{"allowPreventDefault":false,"enableEventBubbling":false,"parameters":{}}},"getters":[],"methods":[]}

packages/ui5-tooling-modules/test/__fixtures__/@ui5/webcomponents-fiori/classes/SideNavigationItemBase.json

@@ -1 +1 @@
-{"namespace":"@ui5/webcomponents-fiori","qualifiedNamespace":"@ui5.webcomponents-fiori","interfaces":[],"properties":{"text":{"type":"string","mapping":"property"},"enabled":{"type":"boolean","defaultValue":"true","mapping":{"type":"property","to":"disabled","formatter":"_mapEnabled"}},"width":{"type":"sap.ui.core.CSSSize","mapping":"style"},"height":{"type":"sap.ui.core.CSSSize","mapping":"style"}},"aggregations":{},"associations":{},"events":{},"getters":[],"methods":[]}
+{"namespace":"@ui5/webcomponents-fiori","qualifiedNamespace":"@ui5.webcomponents-fiori","interfaces":[],"properties":{"text":{"type":"string","mapping":"property"},"enabled":{"type":"boolean","defaultValue":"true","mapping":{"type":"property","to":"disabled","formatter":"_mapEnabled"}}},"aggregations":{},"associations":{},"events":{},"getters":[],"methods":[]}