Skip to content

Commit 6aa2be6

Browse files
committed
fix(ui5-tooling-modules): include also non-documented properties in wrappers
1 parent 41a5ffa commit 6aa2be6

File tree

7 files changed

+12
-30
lines changed

7 files changed

+12
-30
lines changed

packages/ui5-middleware-approuter/test/rewrite.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ test("no rewrite content", async (t) => {
106106
const respMetadata = await app.get("/backendv2/Categories?$format=atom")
107107
t.is(respMetadata.status, 200, "http 200 on categories")
108108
t.true(
109-
respMetadata.text.indexOf(`<feed xml:base="https://services.odata.org/V2/northwind/Northwind.svc/"`) !== -1,
109+
respMetadata.text.indexOf(`<feed xml:base="https://services.odata.org/V2/Northwind/Northwind.svc/"`) !== -1,
110110
"OData context not rewritten"
111111
)
112112

@@ -148,7 +148,7 @@ test("partial rewrite content", async (t) => {
148148
const respMetadata = await app.get("/backendv2/Categories?$format=atom")
149149
t.is(respMetadata.status, 200, "http 200 on categories")
150150
t.true(
151-
respMetadata.text.indexOf(`<feed xml:base="https://services.odata.org/V2/northwind/Northwind.svc/"`) !== -1,
151+
respMetadata.text.indexOf(`<feed xml:base="https://services.odata.org/V2/Northwind/Northwind.svc/"`) !== -1,
152152
"OData context not rewritten"
153153
)
154154

packages/ui5-tooling-modules/lib/templates/jsdoc/UI5Metadata.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
"defaultAggregation": "{{metadata.defaultAggregation}}",
1313

1414
"properties": {
15-
{{#each metadata.properties}}{{#if (lookup (lookup @root.jsDoc "properties") @key)}}
15+
{{#each metadata.properties}}
1616
{{{lookup (lookup @root.jsDoc "properties") @key}}}
1717
"{{@key}}": {{{json this}}},
18-
{{/if}}{{/each}}
18+
{{/each}}
1919
},
2020

2121
"aggregations": {

packages/ui5-tooling-modules/test/__snap__/56bfa72a/@luigi-project/container.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ sap.ui.define(["../container"], function (WebCPackage) {
1010
// export the UI5 metadata along with the package
1111
pkg["_ui5metadata"] = {
1212
name: "@luigi-project/container",
13-
version: "1.7.0",
13+
version: "1.7.4",
1414
dependencies: ["sap.ui.core"],
1515
types: [],
1616
interfaces: [],

packages/ui5-tooling-modules/test/__snap__/56bfa72a/@luigi-project/container/LuigiContainer.js

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,6 @@ sap.ui.define(
130130
customMessage: {
131131
parameters: {}
132132
},
133-
getContextRequest: {
134-
parameters: {}
135-
},
136133
navigationRequest: {
137134
parameters: {}
138135
},
@@ -193,24 +190,9 @@ sap.ui.define(
193190
setViewgroupDataRequest: {
194191
parameters: {}
195192
},
196-
openUserSettingsRequest: {
197-
parameters: {}
198-
},
199-
closeUserSettingsRequest: {
200-
parameters: {}
201-
},
202-
collapseLeftnavRequest: {
203-
parameters: {}
204-
},
205-
updateTopNavigationRequest: {
206-
parameters: {}
207-
},
208193
goBackRequest: {
209194
parameters: {}
210195
},
211-
hasBackRequest: {
212-
parameters: {}
213-
},
214196
addBackdropRequest: {
215197
parameters: {}
216198
},

packages/ui5-tooling-modules/test/__snap__/56bfa72a/LuigiContainer2.js

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

pnpm-lock.yaml

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

showcases/ui5-tsapp/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"directory": "showcases/ui5-tsapp"
2727
},
2828
"dependencies": {
29-
"@luigi-project/container": "1.7.0",
29+
"@luigi-project/container": "1.7.4",
3030
"@stomp/stompjs": "^7.1.1",
3131
"chart.js": "^3.9.1",
3232
"jspdf": "^3.0.1",

0 commit comments

Comments
 (0)