Skip to content

Commit 544cae5

Browse files
altaywtfclaude
andcommitted
chore(verify): bump coverage floor to 85% and document path to 90
Current organic coverage is 86.0% (cmd/fincrawl filtered). The remaining gap to 90% is concentrated in defensive SQL-error returns inside internal/store; closing it cleanly requires a wrapping SQL driver that can inject failures, which is a larger piece of test infrastructure to land in a focused follow-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 8854a76 commit 544cae5

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

AGENTS.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,12 @@ default user state. The smoke script already does this.
1818

1919
- `./scripts/smoke` exercises the real CLI offline with synthetic fixtures.
2020
- `./scripts/verify` runs module tidy checking, tests with coverage report
21-
(enforced at `FINCRAWL_COVERAGE_FLOOR=80` by default; target is 90),
21+
(enforced at `FINCRAWL_COVERAGE_FLOOR=85` by default; target is 90),
2222
vet, race tests, smoke, guardrails, release-check, lint, and whitespace
2323
checks. This is the canonical one-shot. Override the floor via
24-
`FINCRAWL_COVERAGE_FLOOR=N ./scripts/verify` when ratcheting.
24+
`FINCRAWL_COVERAGE_FLOOR=N ./scripts/verify` when ratcheting. The
25+
remaining gap to 90 is in defensive SQL-error returns; closing it needs
26+
a driver wrapper that can inject failures.
2527
- `./scripts/lint` runs `staticcheck`, `gofumpt -l`, `govulncheck`, and
2628
`gosec` with pinned versions. Auto-installs the tools on first run.
2729
- `./scripts/release-check` validates the GoReleaser config used by CI.

scripts/verify

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ go test -count=1 -coverprofile="$coverage_out" ./...
2222
# Exclude the CLI entry point — main() exits the process, not unit-testable.
2323
grep -v '^github.com/uinaf/fincrawl/cmd/fincrawl/' "$coverage_out" >"$coverage_filtered"
2424
total="$(go tool cover -func="$coverage_filtered" | awk '/^total:/ { sub(/%$/, "", $3); print $3 }')"
25-
floor="${FINCRAWL_COVERAGE_FLOOR:-80}"
25+
floor="${FINCRAWL_COVERAGE_FLOOR:-85}"
2626
if [[ -z "$total" ]] || ! awk -v t="$total" 'BEGIN { exit (t+0 > 0) ? 0 : 1 }'; then
2727
echo "coverage is ${total:-<empty>}%; refusing to ship a fully-untested tree" >&2
2828
exit 1

0 commit comments

Comments
 (0)