"collection-id" vs "collection_id" in WARCIndexerCommandOptions.java

[vkush]

Since this commit (ad8b1f6#diff-a625377f8366dfa2c9fa0bb0e8b934d44d3d4d628f46a3e5ccc0350fa4cbe4de) was changed a command line input option in WARCIndexerCommandOptions.java for Collection ID - from "collection_id" to "collection-id", see line here

webarchive-discovery/warc-indexer/src/main/java/uk/bl/wa/indexer/WARCIndexerCommandOptions.java

Line 75 in 13595be

@Option(names = { "-u", "--collection-id" }, description = "Collection ID.")

It is not a big problem, but it brings some unclarity working with other tools (e.g. indexer is also used by SolrWayback), because parameter in Solr config calls "collection_id", see line here

webarchive-discovery/warc-indexer/src/main/java/uk/bl/wa/solr/SolrFields.java

Line 154 in 13595be

public static final String COLLECTION_ID = "collection_id";

Would it be possible to switch it back to "collection_id" or maybe to use both variants like it was done for "disable_commit" option here below? Or for community is better to keep it like it is?

webarchive-discovery/warc-indexer/src/main/java/uk/bl/wa/indexer/WARCIndexerCommandOptions.java

Line 119 in 13595be

@Option(names = { "-d", "--disable_commit", "--disable-commit" }, description = "Disable client side commits (speeds up indexing at the cost of flush guarantee).", defaultValue = "false")