Merge pull request #49 from ukwhatn/feature/forum-post-source-batch

feat: add getPostSources method to ForumPostCollection

Author: ukwhatn

src/module/forum/forum-post.ts

@@ -73,29 +73,13 @@ export class ForumPost {
 
     return fromPromise(
       (async () => {
-        const result = await this.thread.site.amcRequest([
-          {
-            moduleName: 'forum/sub/ForumEditPostFormModule',
-            threadId: this.thread.id,
-            postId: this.id,
-          },
-        ]);
-
+        const result = await ForumPostCollection.acquirePostSources(this.thread, [this]);
         if (result.isErr()) {
           throw result.error;
         }
-
-        const response = result.value[0];
-        if (!response) {
-          throw new NoElementError('Empty response');
-        }
-
-        const $ = cheerio.load(String(response.body ?? ''));
-        const sourceElem = $("textarea[name='source']");
-        if (sourceElem.length === 0) {
+        if (this._source === null) {
           throw new NoElementError('Source textarea not found');
         }
-        this._source = sourceElem.text();
         return this._source;
       })(),
       (error) => {
@@ -508,4 +492,60 @@ export class ForumPostCollection extends Array<ForumPost> {
       }
     );
   }
+
+  /**
+   * Internal method to acquire post sources in bulk
+   */
+  static acquirePostSources(
+    thread: ForumThreadRef,
+    posts: ForumPost[]
+  ): WikidotResultAsync<ForumPostCollection> {
+    return fromPromise(
+      (async () => {
+        const targetPosts = posts.filter((post) => post._source === null);
+
+        if (targetPosts.length === 0) {
+          return new ForumPostCollection(thread, posts);
+        }
+
+        const result = await thread.site.amcRequest(
+          targetPosts.map((post) => ({
+            moduleName: 'forum/sub/ForumEditPostFormModule',
+            threadId: thread.id,
+            postId: post.id,
+          }))
+        );
+
+        if (result.isErr()) {
+          throw result.error;
+        }
+
+        for (let i = 0; i < targetPosts.length; i++) {
+          const post = targetPosts[i];
+          const response = result.value[i];
+          if (!post || !response) continue;
+          const $ = cheerio.load(String(response.body ?? ''));
+          const sourceElem = $("textarea[name='source']");
+          if (sourceElem.length === 0) {
+            throw new NoElementError(`Source textarea not found for post: ${post.id}`);
+          }
+          post._source = sourceElem.text();
+        }
+
+        return new ForumPostCollection(thread, posts);
+      })(),
+      (error) => {
+        if (error instanceof NoElementError) return error;
+        return new UnexpectedError(`Failed to acquire post sources: ${String(error)}`);
+      }
+    );
+  }
+
+  /**
+   * Get sources for all posts in the collection
+   * @returns Result containing the collection (for method chaining)
+   */
+  getPostSources(): WikidotResultAsync<ForumPostCollection> {
+    return ForumPostCollection.acquirePostSources(this.thread, Array.from(this));
+  }
 }

tests/unit/module/forum.test.ts

@@ -4,7 +4,7 @@
 import { describe, expect, test } from 'bun:test';
 import type { Element } from 'domhandler';
 import { ForumCategory } from '../../../src/module/forum/forum-category';
-import { ForumPost } from '../../../src/module/forum/forum-post';
+import { ForumPost, ForumPostCollection } from '../../../src/module/forum/forum-post';
 import { ForumThread } from '../../../src/module/forum/forum-thread';
 import type { ForumThreadRef, SiteRef } from '../../../src/module/types';
 import { User } from '../../../src/module/user/user';
@@ -351,3 +351,131 @@ describe('ForumPost data class', () => {
     });
   });
 });
+
+describe('ForumPostCollection', () => {
+  describe('getPostSources', () => {
+    test('can get sources for posts', async () => {
+      const site = createMockSite();
+      const threadRef = createMockThreadRef(site);
+      const createdBy = createMockUser('TestUser');
+      const mockElement = { type: 'tag', name: 'div' } as Element;
+
+      const post1 = new ForumPost({
+        thread: threadRef,
+        id: 5001,
+        title: 'Post 1',
+        text: '<p>Content 1</p>',
+        element: mockElement,
+        createdBy,
+        createdAt: new Date(),
+        editedBy: null,
+        editedAt: null,
+        parentId: null,
+      });
+
+      const post2 = new ForumPost({
+        thread: threadRef,
+        id: 5002,
+        title: 'Post 2',
+        text: '<p>Content 2</p>',
+        element: mockElement,
+        createdBy,
+        createdAt: new Date(),
+        editedBy: null,
+        editedAt: null,
+        parentId: null,
+      });
+
+      const collection = new ForumPostCollection(threadRef, [post1, post2]);
+
+      const mockResponse1 = {
+        body: '<textarea name="source">Test source 1</textarea>',
+      };
+      const mockResponse2 = {
+        body: '<textarea name="source">Test source 2</textarea>',
+      };
+
+      site.amcRequest = async () => ({
+        isErr: () => false,
+        value: [mockResponse1, mockResponse2],
+      });
+
+      const result = await collection.getPostSources();
+
+      expect(result.isOk()).toBe(true);
+      expect(post1._source).toBe('Test source 1');
+      expect(post2._source).toBe('Test source 2');
+    });
+
+    test('skips already acquired sources', async () => {
+      const site = createMockSite();
+      const threadRef = createMockThreadRef(site);
+      const createdBy = createMockUser('TestUser');
+      const mockElement = { type: 'tag', name: 'div' } as Element;
+
+      const post1 = new ForumPost({
+        thread: threadRef,
+        id: 5001,
+        title: 'Post 1',
+        text: '<p>Content 1</p>',
+        element: mockElement,
+        createdBy,
+        createdAt: new Date(),
+        editedBy: null,
+        editedAt: null,
+        parentId: null,
+      });
+
+      post1._source = 'cached source';
+
+      const post2 = new ForumPost({
+        thread: threadRef,
+        id: 5002,
+        title: 'Post 2',
+        text: '<p>Content 2</p>',
+        element: mockElement,
+        createdBy,
+        createdAt: new Date(),
+        editedBy: null,
+        editedAt: null,
+        parentId: null,
+      });
+
+      const collection = new ForumPostCollection(threadRef, [post1, post2]);
+
+      const mockResponse = {
+        body: '<textarea name="source">Test source 2</textarea>',
+      };
+
+      let callCount = 0;
+      site.amcRequest = async (requests) => {
+        callCount++;
+        // Only post2 should be requested
+        expect(requests.length).toBe(1);
+        expect(requests[0]?.postId).toBe(5002);
+        return {
+          isErr: () => false,
+          value: [mockResponse],
+        };
+      };
+
+      const result = await collection.getPostSources();
+
+      expect(result.isOk()).toBe(true);
+      expect(callCount).toBe(1);
+      expect(post1._source).toBe('cached source');
+      expect(post2._source).toBe('Test source 2');
+    });
+
+    test('handles empty collection', async () => {
+      const site = createMockSite();
+      const threadRef = createMockThreadRef(site);
+      const collection = new ForumPostCollection(threadRef, []);
+
+      const result = await collection.getPostSources();
+
+      expect(result.isOk()).toBe(true);
+      expect(collection.length).toBe(0);
+    });
+  });
+});