Accept normalized CLA signature comments - #26
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed the complete .github/workflows/cla.yml diff. The signature gate now admits comments containing the canonical phrase while preserving the exact recheck condition, matching the stated behavior. No genuine issues found. LGTM.
|
🎉 Huge thanks to @glenn-jocher for merging PR #26!
This focused improvement makes the CLA gate accept valid normalized signature text surrounded by whitespace or Markdown, while preserving exact |
Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.
This makes only the signature gate permissive. The
recheckcommand remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.Related matcher fix: ultralytics/actions#894
Validation:
actionlint .github/workflows/cla.ymlnpx prettier@3.8.5 --check .github/workflows/cla.yml🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated the CLA workflow gate to accept comments containing the normalized CLA signature text, including comments with surrounding whitespace or Markdown.
📊 Key Changes
contains()check in.github/workflows/cla.yml.recheckcommand’s exact-match behavior unchanged.🎯 Purpose & Impact
recheckbehavior is unchanged.