-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Snyk] Security upgrade urllib3 from 2.0.7 to 2.6.0 #2367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-14192442
|
👋 Hello @glenn-jocher, thank you for submitting a -✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions. For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Clean, minimal security-driven change. The main risk is compatibility: enforcing urllib3>=2.6.0 globally in requirements.txt can break installs for older Python/OpenSSL environments. If the repo targets such environments, consider adding an environment marker or scoping the pin to avoid unintended installation failures.
💬 Posted 1 inline comment
| # mss # Screenshot capturing for inference UI | ||
| # albumentations>=1.0.3 # Powerful image augmentation library | ||
| # pycocotools>=2.0.6 # COCO dataset metrics (mAP, etc.) | ||
| urllib3>=2.6.0 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 MEDIUM: This project may support Python versions where urllib3>=2.6.0 is not installable/compatible (urllib3 2.x has dropped older Python/OpenSSL combos in the past). A hard minimum here can break installs even if the vulnerable transitive path isn’t present. Consider aligning the constraint with the repo’s supported Python range (e.g., conditional marker) or pinning only in the environments that need it (CI/dev), if applicable.
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
🔒 Bumps
urllib3to a secure minimum version to address a Snyk-reported vulnerability.📊 Key Changes
urllib3>=2.6.0torequirements.txt(explicit security pin)🎯 Purpose & Impact
urllib3version 🛡️urllib3versions (potential compatibility constraints)