Skip to content

When server is down, link tracking breaks all implementing application navigation #4304

@tpendragon

Description

@tpendragon

Describe the Bug

The event sender for links prevents default and only re-applies it if tracking is successful. If the endpoint is down, links are effectively all broken.

Relevant code:

umami/src/tracker/index.js

Lines 143 to 144 in c0ea3ae

if (!external) e.preventDefault();
return trackElement(parentElement).then(() => {

I -think- this would be fixed by using .finally() instead of .then() there.

sendBeacon() would also work, but I've heard y'all decided not to use that.

Database

PostgreSQL

Relevant log output

Which Umami version are you using?

3.1.0

How are you deploying your application?

Docker

Which browser are you using?

Chrome/Firefox/Edge

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingfixed in devFixed in the dev branch

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions