Skip to content

Update package.json #4328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-rooeintan wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

Update package.json #4328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,5 +157,11 @@
"tsx": "^4.19.0",
"typescript": "^5.9.3",
"vitest": "^4.1.6"
},
"pnpm": {
"onlyBuiltDependencies": [
Comment on lines +160 to +162

@greptile-apps greptile-apps Bot Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The "pnpm" key is indented with 4 spaces, breaking consistency with every other top-level key in the file (all use 2 spaces). The closing brace on line 166 is already at 2 spaces, making the open/close indentation levels mismatch visually.

Suggested change
},
"pnpm": {
"onlyBuiltDependencies": [
},
"pnpm": {
"onlyBuiltDependencies": [

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

"@swc/core",
"@parcel/watcher"
]
}
Comment on lines +161 to 166

@greptile-apps greptile-apps Bot Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Incomplete onlyBuiltDependencies allowlist may silently break installs

In pnpm v9+, setting pnpm.onlyBuiltDependencies means only the listed packages are permitted to run lifecycle scripts — all others are silently skipped. This project has several direct devDependencies that rely on postinstall scripts to download their native binaries: cypress (downloads the Cypress binary), and potentially prisma (generates the client, though that step is also called explicitly in the build scripts). If Cypress's postinstall script is skipped, cypress run / cypress open will fail with a missing binary error at runtime rather than at install time, making the breakage hard to diagnose. The list should be expanded to include every package in the dependency tree that needs to run a build step.

}