Changing property editor of datatype doesn't reflect on content type property

[bjarnef]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

12.1.1

Bug summary

I noticed if changing a property editor of a datatype instance this is updated on the datatype (e.g. from MTNP to a custom property editor), but if I went back to the property on the content type and open this, it still says MTNP.

I have to re-select the datatype by clicking the "change" button.

Specifics

No response

Steps to reproduce

Change a property editor of an existing datatype.
Go back to the property on the content type and open this.
Notice the property still shows the previous datatype (alias) is used.

Expected result / actual result

No response

[github-actions]

Hi there @bjarnef!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[andr317c]

Hey!

Thanks for raising this issue. I was able to reproduce the issue on 10.6.1 and 12.1.1.

When changing the PropertyEditor of a datatype, the document does not update the PropertyEditorAlias for the dataType, which results in this error when trying to do anything in the content section with the document:

I'll go ahead and mark this issue as up for grabs 😄

[github-actions]

Hi @bjarnef,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

[bjarnef]

@andr317c in that case you are changing property editor to another with a different value type. I think it is okay it isn't supported. However in this case the value type is also ValueTypes.Text as MNTP - or actually because the configuration is different. In this case it just use exact same configuration.

I haven't included a property value converter in the example here as it isn't necessary to test this issue.

Try this:

[DataEditor(
    name: "My Custom Picker",
    alias: "myCustomPicker",
    view: "contentpicker",
    Icon = "icon-mindmap",
    ValueType = ValueTypes.Text,
    Group = Umbraco.Cms.Core.Constants.PropertyEditors.Groups.Pickers)]
public class MyCustomPickerPropertyEditor : DataEditor
{
    private readonly IEditorConfigurationParser _editorConfigurationParser;
    private readonly IIOHelper _ioHelper;

    public MyCustomPickerPropertyEditor(
        IDataValueEditorFactory dataValueEditorFactory,
        IIOHelper ioHelper,
        IEditorConfigurationParser editorConfigurationParser,
        EditorType type = EditorType.PropertyValue)
        : base(dataValueEditorFactory, type)
    {
        _ioHelper = ioHelper;
        _editorConfigurationParser = editorConfigurationParser;
        SupportsReadOnly = true;
    }

    /// <inheritdoc />
    protected override IConfigurationEditor CreateConfigurationEditor() =>
        new MultiNodePickerConfigurationEditor(_ioHelper, _editorConfigurationParser); // Just reuse the MNTP configuration.

    protected override IDataValueEditor CreateValueEditor() =>
        DataValueEditorFactory.Create<MyCustomPickerPropertyValueEditor>(Attribute!);

    public class MyCustomPickerPropertyValueEditor : DataValueEditor, IDataValueReferenceFactory, IDataValueReference
    {
        public MyCustomPickerPropertyValueEditor(
            ILocalizedTextService localizedTextService,
            IShortStringHelper shortStringHelper,
            IJsonSerializer jsonSerializer,
            IIOHelper ioHelper,
            DataEditorAttribute attribute)
            : base(localizedTextService, shortStringHelper, jsonSerializer, ioHelper, attribute)
        {
        }

        public IDataValueReference GetDataValueReference() => this;

        public IEnumerable<string> GetAutomaticRelationTypesAliases() => new[] { "umbDocument" };

        public bool IsForEditor(IDataEditor? dataEditor) => dataEditor?.Alias == "myCustomPicker";

        public IEnumerable<UmbracoEntityReference> GetReferences(object? value)
        {
            var asString = value == null ? string.Empty : value is string str ? str : value.ToString();

            if (string.IsNullOrEmpty(asString))
            {
                yield break;
            }

            var udiPaths = asString!.Split(',');

            foreach (var udiPath in udiPaths)
            {
                if (UdiParser.TryParse(udiPath, out Udi? udi))
                {
                    yield return new UmbracoEntityReference(udi, "umbDocument");
                }
            }
        }
    }
}

[andr317c]

Hey again, sorry for the late response.

It seems that I misunderstood what you meant. I tried looking at the issue again and here is what I did: I changed the PropertyEditor of a DataType. The DataType is already in a DocumentType. When looking in the DocumentType to see if the DataType was updated with the new PropertyEditor, it still had the old one.
This is an issue.

Here is a GIF of what I did:

Please let me know if I missed anything! 😄

[bjarnef]

Hi @andr317c

Yes, that's it.
The property editor alias is still the old one showing until the property is updated by re-selecting the datatype or another datatype.

[bjarnef]

Should property only have reference to datatype instance and not property editor directly?
E.g. in migration of a UCommerce project, where I didn't include the UCommerce pickers, the datatypes fallback to Umbraco.Label ... however the properties using the datatypes still have reference to the UCommerce property editors, which cause errors in content.

So on the content type property it need to reselect the datatype instance to update reference to Umbraco.Label property editor.

This is also a general issue if changing property editor on existing datatype instance. I guess the reason it has reference to property editor as well is to show the property editor alias at the property and in content to know about the property editor via the content type property.

Perhaps with a bit optimization it only need reference to datatype instance?