ModelsBuilder generates different types for Color Picker values

[idseefeld]

Which Umbraco version are you using?

16.0.0-rc3

Bug summary

Depending on the Include labels setting of a Color Picker Property Editor UI ModelsBuilder generates two different types for the value:

// no labels
... => this.Value<string>(_publishedValueFallback, "pageBackgroundColor");

// labels included
... => this.Value<global::Umbraco.Cms.Core.PropertyEditors.ValueConverters.ColorPickerValueConverter.PickedColor>(_publishedValueFallback, "pageBackgroundColor");

Bellissima seems to handle this already.

Specifics

Changing this will be a breaking change. Fixing this in release 16 would be cool.

Steps to reproduce

1. Add some items to the "Approved Colors "data type
2. Add a property of type "Approved Colors" to a document type
3. generate the models with ModelsBuilder
4. change the "Include labels" setting of "Approved Colors" data type
5. generate the models with ModelsBuilder again
6. compare generated results (when using a repository you can see the difference immediately😜)

Expected result / actual result

Property value type should always be PickedColor.

Currently it is of type string or PickedColor.

[github-actions]

Hi there @idseefeld!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[idseefeld]

After debugging the source code I found the issue in file:
Umbraco-CMS\src\Umbraco.Core\PropertyEditors\ValueConverters\ColorPickerValueConverter.cs

I have change the behaviour in PR #19347 to always return PickedColor type | instance.