NRE when try to finish with a Bundle in the cart

[marvingbh]

Which component is this issue related to?

Umbraco Commerce (Core)

Which Umbraco Commerce version are you using? (Please write the exact version, example: 10.1.0)

15.3.13

Bug summary

getting this error when try to finish a purchase with a bundle product in the cart:

2025-12-04T17:46:38.670493633Z` [17:46:38 ERR] An unhandled exception has occurred while executing the request.
2025-12-04T17:46:38.670540634Z System.NullReferenceException: Object reference not set to an instance of an object.
2025-12-04T17:46:38.670551135Z    at Umbraco.Commerce.Infrastructure.Resiliency.PollyExecutionStrategyBase.ExecuteAsync[TResult](Func`2 operation, Func`2 verifySucceeded, CancellationToken cancellationToken)
2025-12-04T17:46:38.670557435Z    at Umbraco.Commerce.Cms.Web.Api.Storefront.Controllers.HostedCheckoutStorefrontApiController.PrepareStorefrontPaymentFormAsync(OrderReadOnly order)
2025-12-04T17:46:38.670562335Z    at Umbraco.Commerce.Cms.Web.Api.Storefront.Controllers.HostedCheckoutStorefrontApiController.Pay(Guid orderId, String token, CancellationToken cancellationToken)
2025-12-04T17:46:38.670567535Z    at lambda_method4045(Closure, Object)
2025-12-04T17:46:38.670575035Z    at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.TaskOfActionResultExecutor.Execute(ActionContext actionContext, IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
2025-12-04T17:46:38.670581135Z    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Logged|12_1(ControllerActionInvoker invoker)
2025-12-04T17:46:38.670588135Z    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeNextActionFilterAsync>g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
2025-12-04T17:46:38.670593035Z    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
2025-12-04T17:46:38.670599836Z    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
2025-12-04T17:46:38.670618836Z    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeInnerFilterAsync>g__Awaited|13_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
2025-12-04T17:46:38.670624136Z    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextResourceFilter>g__Awaited|25_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
2025-12-04T17:46:38.670628436Z    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
2025-12-04T17:46:38.670632536Z    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
2025-12-04T17:46:38.670636036Z    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeFilterPipelineAsync>g__Awaited|20_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
2025-12-04T17:46:38.670639436Z    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Logged|17_1(ResourceInvoker invoker)
2025-12-04T17:46:38.670643036Z    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Logged|17_1(ResourceInvoker invoker)
2025-12-04T17:46:38.670646836Z    at Umbraco.Cms.Api.Management.Middleware.BackOfficeExternalLoginProviderErrorMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
2025-12-04T17:46:38.670650437Z    at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.InterfaceMiddlewareBinder.<>c__DisplayClass2_0.<<CreateMiddleware>b__0>d.MoveNext()
2025-12-04T17:46:38.670654737Z --- End of stack trace from previous location ---
2025-12-04T17:46:38.670658337Z    at Swashbuckle.AspNetCore.SwaggerUI.SwaggerUIMiddleware.Invoke(HttpContext httpContext)
2025-12-04T17:46:38.670661837Z    at Swashbuckle.AspNetCore.Swagger.SwaggerMiddleware.Invoke(HttpContext httpContext, ISwaggerProvider swaggerProvider)
2025-12-04T17:46:38.670665837Z    at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
2025-12-04T17:46:38.670669237Z    at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
2025-12-04T17:46:38.670672937Z    at Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.Invoke(HttpContext context)
2025-12-04T17:46:38.670676437Z    at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
2025-12-04T17:46:38.670680137Z    at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
2025-12-04T17:46:38.670683937Z    at StackExchange.Profiling.MiniProfilerMiddleware.Invoke(HttpContext context) in C:\projects\dotnet\src\MiniProfiler.AspNetCore\MiniProfilerMiddleware.cs:line 112
2025-12-04T17:46:38.670687437Z    at Umbraco.Cms.Web.Common.Middleware.UmbracoRequestMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
2025-12-04T17:46:38.670691137Z    at Umbraco.Cms.Web.Common.Middleware.UmbracoRequestMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
2025-12-04T17:46:38.670699838Z    at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.InterfaceMiddlewareBinder.<>c__DisplayClass2_0.<<CreateMiddleware>b__0>d.MoveNext()
2025-12-04T17:46:38.670703538Z --- End of stack trace from previous location ---
2025-12-04T17:46:38.670707038Z    at Umbraco.Cms.Web.Common.Middleware.PreviewAuthenticationMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
2025-12-04T17:46:38.670710538Z    at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.InterfaceMiddlewareBinder.<>c__DisplayClass2_0.<<CreateMiddleware>b__0>d.MoveNext()
2025-12-04T17:46:38.670714138Z --- End of stack trace from previous location ---
2025-12-04T17:46:38.670722738Z    at Umbraco.Cms.Web.Common.Middleware.UmbracoRequestLoggingMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
2025-12-04T17:46:38.670726438Z    at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.InterfaceMiddlewareBinder.<>c__DisplayClass2_0.<<CreateMiddleware>b__0>d.MoveNext()
2025-12-04T17:46:38.670729938Z --- End of stack trace from previous location ---
2025-12-04T17:46:38.670744839Z    at SixLabors.ImageSharp.Web.Middleware.ImageSharpMiddleware.Invoke(HttpContext httpContext, Boolean retry)
2025-12-04T17:46:38.670748439Z    at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddlewareImpl.<Invoke>g__Awaited|10_0(ExceptionHandlerMiddlewareImpl middleware, HttpContext context, Task task)

Specifics

it works for other kind of product

Steps to reproduce

• create a bundle product
• try to add to the cart

Expected result / actual result

No response

Dependencies

No response

[mattbrailsford]

What payment provider are you using?

[marvingbh]

stripe

[mattbrailsford]

Ok, well I've been unable to replicate this. I've used our demo headless store and created an order then in the backoffice converted it to a bundle and attached another product. I've then gone through the checkout process using the hosted payment option of the Stripe provider and I have successfully reached the checkout page.

Do you have any code that runs dynamically for bundled products that could be affecting this?

[marvingbh]

no, is also weird here for me, I have dev and prod environment, the error only happens in dev, in prod it works fine. I open it here hopping with the stack trace you could find what was the property that is null, I have no clue, since I already compared side by side the products and the bundles, and they looks identical in both environments.

[mattbrailsford]

Ok, well in terms of helping explain some of the stack trace in case it helps PrepareStorefrontPaymentFormAsync is where we ask the payment provider to generate their redirect form (hence me asking what you were using). I wondered if there was an issue in the payment provider not handling bundles too well, but the Stripe provider doesn't really create matching line items. It only makes Stripe specific line items for Subscriptions, for anything else, it just creates a single line item so I couldn't see that being the problem.

If you have the source for the Stripe Provider, it could be worth debugging that to see if it's within the GenerateForm method, or whether it's part of Umbraco Commerce. That could help narrow it down at least.

The Pay endpoint basically renders the form from the provider, and then converts that to markup, so it's likely an issue in the provider or in the markup generating logic. But I can't really see anything obvious being the culprit.