Skip to content

Commit 1e27ccf

Browse files
author
pavel.chi
committed
tests
1 parent d800b4d commit 1e27ccf

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

src/Trackers/ResponseTime/ResponseTimeTrackerMiddleware.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ public function handle($request, $next)
2727
public function terminate(Request $request, Response $response): void
2828
{
2929
$responseTime = $this->calculateResponseTime();
30+
$route = $request->route();
3031

3132
$this->adapter->write($this->metricConfig['measurement'], $responseTime, [
32-
'action' => $request->route()
33-
->getActionName(),
33+
'action' => $route ? $route->getActionName() : '',
3434
]);
3535
}
3636

tests/Feature/Trackers/ExternalApiResponse/GuzzleClientOnStatsCallbackCreatorTest.php

-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ public function dontWriteEveryRequestIfRedirect(): void
3939
$eventTracker->expects($this->once())
4040
->method('write')
4141
->with('external_api_response', 2, [
42-
'urlName' => 'https://domain.com/1/edit',
4342
'host' => 'domain.com',
4443
'status' => 200,
4544
'total_time' => 2,

tests/Unit/Trackers/ResponseTime/ResponseTimeTrackerMiddlewareTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public function correctWrite(): void
2424
$eventAdapter->expects($this->once())
2525
->method('write')
2626
->with($measurement, $this->greaterThan(0), [
27-
'urlName' => 'domain.com/test',
27+
'action' => '',
2828
]);
2929

3030
$middleware = new ResponseTimeTrackerMiddleware($eventAdapter, compact('measurement'));

0 commit comments

Comments
 (0)