add some fixes

Author: tycooon

Diff for: Gemfile

@@ -13,3 +13,4 @@ gem "rspec-its"
 gem "rubocop-config-umbrellio"
 gem "simplecov"
 gem "simplecov-lcov"
+gem "sneakers_handlers", github: "umbrellio/sneakers_handlers", branch: "gt-1241-test-rabbit-dlx"

Diff for: Gemfile.lock

@@ -1,3 +1,11 @@
+GIT
+  remote: https://github.com/umbrellio/sneakers_handlers.git
+  revision: 2fd531a99c85f042923ae8b8bd0f3b340af4d15f
+  branch: gt-1241-test-rabbit-dlx
+  specs:
+    sneakers_handlers (0.1.0)
+      kicks
+
 PATH
   remote: .
   specs:
@@ -6,7 +14,6 @@ PATH
       kicks (~> 3)
       lamian
       rails (>= 6.1)
-      sneakers_handlers
       tainbox
 
 GEM
@@ -273,21 +280,13 @@ GEM
     simplecov-html (0.13.1)
     simplecov-lcov (0.8.0)
     simplecov_json_formatter (0.1.4)
-    sneakers (0.0.7)
-      bunny (>= 0.10.0)
-      serverengine
-      thor
-      thread
-    sneakers_handlers (0.0.6)
-      sneakers
     sorted_set (1.0.3)
       rbtree
       set (~> 1.0)
     stringio (3.1.1)
     tainbox (2.1.2)
       activesupport
     thor (1.3.2)
-    thread (0.2.2)
     timeout (0.4.1)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
@@ -313,6 +312,7 @@ DEPENDENCIES
   rubocop-config-umbrellio
   simplecov
   simplecov-lcov
+  sneakers_handlers!
 
 BUNDLED WITH
    2.5.22

Diff for: lib/rabbit.rb

@@ -61,7 +61,7 @@ def app_name
     end
 
     def read_queue
-      [app_name, queue_suffix].compact.join(".")
+      [app_name, queue_suffix].reject { |x| x.nil? || x.empty? }.join(".")
     end
   end
 

Diff for: lib/rabbit/daemon.rb

@@ -28,7 +28,7 @@ def run(logger: Sneakers.logger)
 
       Receiving::Worker.from_queue(
         Rabbit.config.read_queue,
-        handler: SneakersHandlers::ExponentialBackoffHandler,
+        handler: SneakersHandlers::ExponentialBackoffHandler, # TODO: add config
         max_retries: Rabbit.config.backoff_handler_max_retries,
         arguments: {
           "x-dead-letter-exchange" => "#{Rabbit.config.read_queue}.dlx",

Diff for: rabbit_messaging.gemspec

@@ -23,6 +23,5 @@ Gem::Specification.new do |spec|
   spec.add_dependency "kicks", "~> 3"
   spec.add_dependency "lamian"
   spec.add_dependency "rails", ">= 6.1"
-  spec.add_dependency "sneakers_handlers"
   spec.add_dependency "tainbox"
 end

Diff for: spec/units/rabbit_spec.rb

@@ -104,6 +104,18 @@
     describe "#read_queue" do
       specify { expect(Rabbit.config.read_queue).to eq("test_group_id.test_project_id") }
 
+      context "with nil suffix provided" do
+        before { Rabbit.config.queue_suffix = nil }
+
+        specify { expect(Rabbit.config.read_queue).to eq("test_group_id.test_project_id") }
+      end
+
+      context "with blank suffix provided" do
+        before { Rabbit.config.queue_suffix = "" }
+
+        specify { expect(Rabbit.config.read_queue).to eq("test_group_id.test_project_id") }
+      end
+
       context "with suffix provided" do
         before { Rabbit.config.queue_suffix = "smth" }