Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit ddfe667

Browse files
committedDec 9, 2024·
rubocop
1 parent 50a7371 commit ddfe667

36 files changed

+146
-146
lines changed
 

Diff for: ‎lib/table_sync.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class << self
4747

4848
def sync(object_class, **options)
4949
setup.new(
50-
object_class: object_class,
50+
object_class:,
5151
on: options[:on],
5252
if_condition: options[:if],
5353
unless_condition: options[:unless],

Diff for: ‎lib/table_sync/instrument_adapter/active_support.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ module ActiveSupport
66

77
def notify(table:, schema:, event:, direction:, count: 1)
88
::ActiveSupport::Notifications.instrument "tablesync.#{direction}.#{event}",
9-
count: count,
9+
count:,
1010
table: table.to_s,
1111
schema: schema.to_s,
12-
event: event,
13-
direction: direction
12+
event:,
13+
direction:
1414
end
1515
end
1616
end

Diff for: ‎lib/table_sync/publishing/data/objects.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def initialize(objects:, event:, custom_version:)
1212

1313
def construct
1414
{
15-
model: model,
15+
model:,
1616
attributes: attributes_for_sync,
1717
version: custom_version || version,
1818
event: event.resolve,

Diff for: ‎lib/table_sync/publishing/message/base.rb

+6-6
Original file line numberDiff line numberDiff line change
@@ -33,21 +33,21 @@ def empty?
3333

3434
def find_or_init_objects
3535
TableSync::Publishing::Helpers::Objects.new(
36-
object_class: object_class, original_attributes: original_attributes, event: event,
36+
object_class:, original_attributes:, event:,
3737
).construct_list
3838
end
3939

4040
# MESSAGE PARAMS
4141

4242
def message_params
43-
params.merge(data: data)
43+
params.merge(data:)
4444
end
4545

4646
def data
4747
TableSync::Publishing::Data::Objects.new(
48-
objects: objects,
49-
event: event,
50-
custom_version: custom_version,
48+
objects:,
49+
event:,
50+
custom_version:,
5151
).construct
5252
end
5353

@@ -63,7 +63,7 @@ def notify!
6363
TableSync::Instrument.notify(
6464
table: model_naming.table,
6565
schema: model_naming.schema,
66-
event: event,
66+
event:,
6767
direction: :publish,
6868
count: objects.count,
6969
)

Diff for: ‎lib/table_sync/publishing/message/raw.rb

+5-5
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def notify!
2626
TableSync::Instrument.notify(
2727
table: table_name,
2828
schema: schema_name,
29-
event: event,
29+
event:,
3030
count: original_attributes.count,
3131
direction: :publish,
3232
)
@@ -35,15 +35,15 @@ def notify!
3535
# MESSAGE PARAMS
3636

3737
def message_params
38-
params.merge(data: data)
38+
params.merge(data:)
3939
end
4040

4141
def data
4242
TableSync::Publishing::Data::Raw.new(
43-
model_name: model_name,
43+
model_name:,
4444
attributes_for_sync: original_attributes,
45-
event: event,
46-
custom_version: custom_version,
45+
event:,
46+
custom_version:,
4747
).construct
4848
end
4949

Diff for: ‎lib/table_sync/publishing/message/single.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ def object
77
end
88

99
def params
10-
TableSync::Publishing::Params::Single.new(object: object).construct
10+
TableSync::Publishing::Params::Single.new(object:).construct
1111
end
1212
end
1313
end

Diff for: ‎lib/table_sync/publishing/params/base.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ class Base
1010

1111
def construct
1212
DEFAULT_PARAMS.merge(
13-
routing_key: routing_key,
14-
headers: headers,
15-
exchange_name: exchange_name,
13+
routing_key:,
14+
headers:,
15+
exchange_name:,
1616
)
1717
end
1818

Diff for: ‎lib/table_sync/publishing/single.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ def publish_now
3131

3232
memoize def debounce
3333
TableSync::Publishing::Helpers::Debounce.new(
34-
object_class: object_class,
34+
object_class:,
3535
needle: message.object.needle,
36-
debounce_time: debounce_time,
37-
event: event,
36+
debounce_time:,
37+
event:,
3838
)
3939
end
4040

Diff for: ‎lib/table_sync/receiving/config_decorator.rb

+7-7
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@ def initialize(config:, event:, model:, version:, project_id:, raw_data:)
1010
@config = config
1111

1212
@default_params = {
13-
event: event,
14-
model: model,
15-
version: version,
16-
project_id: project_id,
17-
raw_data: raw_data,
13+
event:,
14+
model:,
15+
version:,
16+
project_id:,
17+
raw_data:,
1818
}
1919
end
2020
# rubocop:enable Metrics/ParameterLists
2121

22-
def method_missing(name, **additional_params, &block)
22+
def method_missing(name, **additional_params, &)
2323
value = @config.send(name)
24-
value.is_a?(Proc) ? value.call(@default_params.merge(additional_params), &block) : value
24+
value.is_a?(Proc) ? value.call(@default_params.merge(additional_params), &) : value
2525
end
2626
end
2727
end

Diff for: ‎lib/table_sync/receiving/dsl.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def receive(source, to_table: nil, to_model: nil, events: [:update, :destroy], &
1616

1717
TableSync::Utils::InterfaceChecker.new(model).implements(:receiving_model)
1818

19-
config = ::TableSync::Receiving::Config.new(model: model, events: events)
19+
config = ::TableSync::Receiving::Config.new(model:, events:)
2020

2121
config.instance_exec(&block) if block
2222

Diff for: ‎lib/table_sync/receiving/handler.rb

+20-20
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,22 @@ def call
1616

1717
next if data.empty?
1818

19-
version_key = config.version_key(data: data)
19+
version_key = config.version_key(data:)
2020
data.each { |row| row[version_key] = version }
2121

22-
target_keys = config.target_keys(data: data)
22+
target_keys = config.target_keys(data:)
2323

24-
validate_data(data, target_keys: target_keys)
24+
validate_data(data, target_keys:)
2525

2626
data.sort_by! { |row| row.values_at(*target_keys).map { |value| sort_key(value) } }
2727

28-
params = { data: data, target_keys: target_keys, version_key: version_key }
28+
params = { data:, target_keys:, version_key: }
2929

3030
if event == :update
31-
params[:default_values] = config.default_values(data: data)
31+
params[:default_values] = config.default_values(data:)
3232
end
3333

34-
config.wrap_receiving(event: event, **params) do
34+
config.wrap_receiving(event:, **params) do
3535
perform(config, params)
3636
end
3737
end
@@ -64,12 +64,12 @@ def configs
6464
configs = configs.sort_by { |config| "#{config.model.schema}.#{config.model.table}" }
6565
configs.map do |config|
6666
::TableSync::Receiving::ConfigDecorator.new(
67-
config: config,
67+
config:,
6868
# next parameters will be send to each proc-options from config
69-
event: event,
70-
model: model,
71-
version: version,
72-
project_id: project_id,
69+
event:,
70+
model:,
71+
version:,
72+
project_id:,
7373
raw_data: data,
7474
)
7575
end
@@ -78,22 +78,22 @@ def configs
7878

7979
def processed_data(config)
8080
data.filter_map do |row|
81-
next if config.skip(row: row)
81+
next if config.skip(row:)
8282

8383
row = row.dup
8484

85-
config.mapping_overrides(row: row).each do |before, after|
85+
config.mapping_overrides(row:).each do |before, after|
8686
row[after] = row.delete(before)
8787
end
8888

89-
config.except(row: row).each { |x| row.delete(x) }
89+
config.except(row:).each { |x| row.delete(x) }
9090

91-
row.merge!(config.additional_data(row: row))
91+
row.merge!(config.additional_data(row:))
9292

93-
only = config.only(row: row)
93+
only = config.only(row:)
9494
row, rest = row.partition { |key, _| key.in?(only) }.map(&:to_h)
9595

96-
rest_key = config.rest_key(row: row, rest: rest)
96+
rest_key = config.rest_key(row:, rest:)
9797
(row[rest_key] ||= {}).merge!(rest) if rest_key
9898

9999
row
@@ -139,13 +139,13 @@ def perform(config, params)
139139

140140
model.after_commit do
141141
TableSync::Instrument.notify table: model.table, schema: model.schema,
142-
count: results.count, event: event, direction: :receive
142+
count: results.count, event:, direction: :receive
143143
end
144144

145145
if event == :update
146-
model.after_commit { config.after_commit_on_update(**params.merge(results: results)) }
146+
model.after_commit { config.after_commit_on_update(**params.merge(results:)) }
147147
else
148-
model.after_commit { config.after_commit_on_destroy(**params.merge(results: results)) }
148+
model.after_commit { config.after_commit_on_destroy(**params.merge(results:)) }
149149
end
150150
end
151151
end

Diff for: ‎lib/table_sync/receiving/model/active_record.rb

+7-7
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def initialize(table_name)
2626
self.inheritance_column = nil
2727
end
2828

29-
model_naming = ::TableSync::NamingResolver::ActiveRecord.new(table_name: table_name)
29+
model_naming = ::TableSync::NamingResolver::ActiveRecord.new(table_name:)
3030

3131
@table = model_naming.table.to_sym
3232
@schema = model_naming.schema.to_sym
@@ -66,7 +66,7 @@ def upsert(data:, target_keys:, version_key:, default_values:)
6666
row = raw_model.lock("FOR NO KEY UPDATE").where(conditions)
6767

6868
if row.to_a.size > 1
69-
raise TableSync::UpsertError.new(data: datum, target_keys: target_keys, result: row)
69+
raise TableSync::UpsertError.new(data: datum, target_keys:, result: row)
7070
end
7171

7272
row = row.first
@@ -99,18 +99,18 @@ def destroy(data:, target_keys:, version_key:)
9999
result = query.destroy_all.map { |x| row_to_hash(x) }
100100

101101
if result.size > data.size
102-
raise TableSync::DestroyError.new(data: data, target_keys: target_keys, result: result)
102+
raise TableSync::DestroyError.new(data:, target_keys:, result:)
103103
end
104104

105105
result
106106
end
107107

108-
def transaction(&block)
109-
::ActiveRecord::Base.transaction(&block)
108+
def transaction(&)
109+
::ActiveRecord::Base.transaction(&)
110110
end
111111

112-
def after_commit(&block)
113-
db.add_transaction_record(AfterCommitWrap.new(&block))
112+
def after_commit(&)
113+
db.add_transaction_record(AfterCommitWrap.new(&))
114114
end
115115

116116
private

Diff for: ‎lib/table_sync/receiving/model/sequel.rb

+6-6
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ def initialize(table_name)
88
@raw_model = Class.new(::Sequel::Model(table_name)).tap(&:unrestrict_primary_key)
99

1010
model_naming = ::TableSync::NamingResolver::Sequel.new(
11-
table_name: table_name,
11+
table_name:,
1212
db: @raw_model.db,
1313
)
1414

@@ -46,18 +46,18 @@ def destroy(data:, target_keys:, version_key:)
4646
result = dataset.returning.where(::Sequel.|(*sanitized_data)).delete
4747

4848
if result.size > data.size
49-
raise TableSync::DestroyError.new(data: data, target_keys: target_keys, result: result)
49+
raise TableSync::DestroyError.new(data:, target_keys:, result:)
5050
end
5151

5252
result
5353
end
5454

55-
def transaction(&block)
56-
db.transaction(&block)
55+
def transaction(&)
56+
db.transaction(&)
5757
end
5858

59-
def after_commit(&block)
60-
db.after_commit(&block)
59+
def after_commit(&)
60+
db.after_commit(&)
6161
end
6262

6363
private

Diff for: ‎lib/table_sync/setup/active_record.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def define_after_commit(event)
1414
TableSync::Publishing::Single.new(
1515
object_class: self.class.name,
1616
original_attributes: attributes,
17-
event: event,
17+
event:,
1818
debounce_time: options[:debounce_time],
1919
).publish_later
2020
end

Diff for: ‎lib/table_sync/setup/base.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def options_exposed_for_block
6060
{
6161
if: if_condition,
6262
unless: unless_condition,
63-
debounce_time: debounce_time,
63+
debounce_time:,
6464
}
6565
end
6666
end

Diff for: ‎lib/table_sync/setup/sequel.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def define_after_commit(event)
1313
TableSync::Publishing::Single.new(
1414
object_class: self.class.name,
1515
original_attributes: values,
16-
event: event,
16+
event:,
1717
debounce_time: options[:debounce_time],
1818
).publish_later
1919
end

Diff for: ‎lib/table_sync/utils/proc_array.rb

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
# frozen_string_literal: true
22

33
class TableSync::Utils::ProcArray < Proc
4-
def initialize(&block)
4+
def initialize(&)
55
@array = []
6-
super(&block)
6+
super(&)
77
end
88

99
def push(&block)
1010
@array.push(block)
1111
self
1212
end
1313

14-
def call(*args, &block)
15-
super(@array, args, &block)
14+
def call(*args, &)
15+
super(@array, args, &)
1616
end
1717
end
There was a problem loading the remainder of the diff.

0 commit comments

Comments
 (0)
Please sign in to comment.