fix: drop all omitzero tags — omitempty on structs was always a no-op

The original omitempty on struct-typed fields (time.Time, PostInfo,
UserDetailEntry) was a no-op in encoding/json, so zero values were
always serialised. Replacing with omitzero would change actual behaviour
by omitting these fields when zero-valued, breaking API responses and
RPC wire format. Just drop the tag entirely to preserve existing
behaviour.

Author: paskal

backend/app/cmd/cleanup.go

@@ -179,7 +179,7 @@ func (cc *CleanupCommand) listComments(postURL string) ([]store.Comment, error)
 
 	commentsWithInfo := struct {
 		Comments []store.Comment `json:"comments"`
-		Info     store.PostInfo  `json:"info,omitzero"`
+		Info     store.PostInfo  `json:"info"`
 	}{}
 
 	if err = json.NewDecoder(r.Body).Decode(&commentsWithInfo); err != nil {

backend/app/cmd/cleanup_test.go

@@ -173,7 +173,7 @@ func cleanupRoutes(t *testing.T, r *chi.Mux, c *cleanedComments) {
 
 		commentsWithInfo := struct {
 			Comments []store.Comment `json:"comments"`
-			Info     store.PostInfo  `json:"info,omitzero"`
+			Info     store.PostInfo  `json:"info"`
 		}{}
 
 		switch r.URL.Query().Get("url") {

backend/app/migrator/commento.go

@@ -48,7 +48,7 @@ type commentoCommenter struct {
 	Link         string    `json:"link"`
 	Photo        string    `json:"photo"`
 	Provider     string    `json:"provider,omitempty"`
-	JoinDate     time.Time `json:"joinDate,omitzero"`
+	JoinDate     time.Time `json:"joinDate"`
 	IsModerator  bool      `json:"isModerator"`
 }
 

backend/app/rest/api/rest.go

@@ -96,12 +96,12 @@ const lastCommentsScope = "last"
 
 type commentsWithInfo struct {
 	Comments []store.Comment `json:"comments"`
-	Info     store.PostInfo  `json:"info,omitzero"`
+	Info     store.PostInfo  `json:"info"`
 }
 
 type treeWithInfo struct {
 	*service.Tree
-	Info store.PostInfo `json:"info,omitzero"`
+	Info store.PostInfo `json:"info"`
 }
 
 // Run the lister and request's router, activate rest server

backend/app/store/comment.go

@@ -50,8 +50,8 @@ type PostInfo struct {
 	CountLeft   int       `json:"count_left"`                                     // used only with returning search results limited by number, otherwise zero
 	LastComment string    `json:"last_comment,omitempty"`                         // used only with returning search results limited by number
 	ReadOnly    bool      `json:"read_only,omitempty" bson:"read_only,omitempty"` // can be attached to site-wide comments but won't be set then
-	FirstTS     time.Time `json:"first_time,omitzero" bson:"first_time,omitempty"`
-	LastTS      time.Time `json:"last_time,omitzero" bson:"last_time,omitempty"`
+	FirstTS     time.Time `json:"first_time" bson:"first_time,omitempty"`
+	LastTS      time.Time `json:"last_time" bson:"last_time,omitempty"`
 }
 
 // BlockedUser holds id and ts for blocked user

backend/app/store/service/service.go

@@ -62,7 +62,7 @@ type UserMetaData struct {
 		Until  time.Time `json:"until"`
 	} `json:"blocked"`
 	Verified bool                   `json:"verified"`
-	Details  engine.UserDetailEntry `json:"details,omitzero"`
+	Details  engine.UserDetailEntry `json:"details"`
 }
 
 // PostMetaData keeps info about post flags