diff --git a/backend/app/cmd/server_test.go b/backend/app/cmd/server_test.go index 644ce9f403..821b2b2ba7 100644 --- a/backend/app/cmd/server_test.go +++ b/backend/app/cmd/server_test.go @@ -642,7 +642,10 @@ func prepServerApp(t *testing.T, fn func(o ServerCommand) ServerCommand) (*serve os.Remove(cmd.Store.Bolt.Path + "/remark.db") - // create app + return createAppFromCmd(t, cmd) +} + +func createAppFromCmd(t *testing.T, cmd ServerCommand) (*serverApp, context.Context, context.CancelFunc) { app, err := cmd.newServerApp() require.NoError(t, err) diff --git a/backend/app/rest/api/rest_test.go b/backend/app/rest/api/rest_test.go index 4d01b28980..5285782f68 100644 --- a/backend/app/rest/api/rest_test.go +++ b/backend/app/rest/api/rest_test.go @@ -333,17 +333,24 @@ func TestRest_cacheControl(t *testing.T) { } -func startupT(t *testing.T) (ts *httptest.Server, srv *Rest, teardown func()) { - tmp := os.TempDir() - var testDB string - // pick a file name which is not in use for sure +// randomPath pick a file or folder name which is not in use for sure +func randomPath(tempDir, basename, suffix string) (string, error) { for i := 0; i < 10; i++ { - testDB = fmt.Sprintf("/%s/test-remark-%d.db", tmp, rand.Int31()) - _, err := os.Stat(testDB) + fname := fmt.Sprintf("/%s/%s-%d%s", tempDir, basename, rand.Int31(), suffix) + fmt.Printf("fname %q", fname) + _, err := os.Stat(fname) if err != nil { - break + return fname, nil } } + return "", errors.New("cannot create temp file") +} + +func startupT(t *testing.T) (ts *httptest.Server, srv *Rest, teardown func()) { + tmp := os.TempDir() + testDB, err := randomPath(tmp, "test-remark", ".db") + require.NoError(t, err) + _ = os.RemoveAll(tmp + "/ava-remark42") _ = os.RemoveAll(tmp + "/pics-remark42")