[prettier-plugin-sql] does not return cursor Position

[stonerl]

I added prettier-plugin-sql to my Prettier extension for Nova. I also use Prettiers formatWithCursor to retrieve the correct cursor Position after formatting.

prettier-plugin-sql seems to always return 0 as position, so the cursor always jumps to the beginning of the document.

[JounQin]

Please provide a online runnable reproduction. I'm not familiar with the formatWithCurson API.

[stonerl]

Dumb, question, but what would be an online runnable reproduction? I can only point you to the API doc.

https://prettier.io/docs/api/#prettierformatwithcursorsource--options

I'm just handing the cursor position to Prettier it and retrieve the new cursor position after formatting. That works for all languages supported by Prettier and all other plugins I use. e.g @prettier/plugin-xml and @prettier/plugin-php. So, not sure what I can do here?

[JounQin]

I didn't find what the plugin author need to do with formatWithCursor API or even cursor keyword: https://prettier.io/docs/plugins#developing-plugins

Maybe we can do better here?

prettier/packages/sql/src/index.ts

Lines 46 to 47 in 2b277b8

	locStart: () => -1,
	locEnd: () => -1,

cc @fisker

[fisker]

Here is how the cursor node is located https://github.com/prettier/prettier/blob/c2ad588ec38f204427cad076fa58d608a3e9e02d/src/main/get-cursor-node.js#L20, Prettier will insert two prettier.doc.builders.cursor around that node when printing node.

[stonerl]

As a side note, the TOML plugin has the same issue.