wip changes

Author: benbaumann95

Diff for: app/controllers/documents_controller.rb

@@ -38,7 +38,7 @@ def create
     @document = @planning_application.documents.build(document_params)
 
     if @document.save
-      flash[:notice] = "#{@document.name} has been uploaded."
+      flash[:notice] = "#{@document.name} has been uploaded and queued for analysis."
       redirect_to planning_application_documents_path
     else
       render :new

Diff for: app/jobs/document_analyser_job.rb

@@ -1,5 +1,8 @@
+# frozen_string_literal: true
+
 class DocumentAnalyserJob < ApplicationJob
   queue_as :high_priority
+  retry_on(StandardError, attempts: 5, wait: 1.minute, jitter: 0)
 
   def perform(document)
     DocumentAnalyserService.new(document).call

Diff for: app/models/document.rb

@@ -53,11 +53,10 @@ class NotArchiveableError < StandardError; end
 
   has_one_attached :file, dependent: :destroy
   after_create :create_audit!
+  after_create :generate_ai_summary
   before_update :reset_replacement_document_validation_request_update_counter!, if: :owner_is_validation_request?
   after_update :audit_updated!
 
-  after_create :generate_ai_summary
-
   DRAWING_TAGS = %w[
     elevations.existing
     elevations.proposed

Diff for: app/services/document_analyser_service.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "openai"
 require "base64"
 
@@ -19,12 +21,15 @@ def call
     return unless file_path
 
     image = build_image(file_path)
-    user_content = user_message(image)
+    user_summary_content = user_message(image)
+    user_content = user_message_tags(image)
 
-    ai_summary = generate_ai_summary(user_content)
+    ai_summary = generate_ai_summary(user_summary_content)
+    document_tags = generate_document_tags(user_content)
 
+    document.update!(tags: document_tags) if document_tags.any?
     document.update!(ai_summary: ai_summary) if ai_summary.present?
-  rescue StandardError => e
+  rescue => e
     Rails.logger.error("Error analysing the document with id: #{document.id}: #{e.message}")
     false
   end
@@ -51,17 +56,17 @@ def download_file
 
   def build_image(file_path)
     image_data = File.binread(file_path)
-    base64_image = Base64.strict_encode64(image_data)
+    Base64.strict_encode64(image_data)
   end
 
-  def generate_ai_summary(user_content)    
+  def generate_ai_summary(user_content)
     response = client.chat(
       parameters: {
         model: "gpt-4o-mini",
         messages: [
-          { 
-            role: "system", 
-            content: "You are an expert, with experience in UK housing/planning, in interpreting and extracting a concise summary/description of a document" 
+          {
+            role: "system",
+            content: "You are an expert, with experience in UK housing/planning, in interpreting and extracting a concise summary/description of a document"
           },
           {
             role: "user",
@@ -70,19 +75,56 @@ def generate_ai_summary(user_content)
         ]
       }
     )
-
     response.dig("choices", 0, "message", "content")
   end
 
   def user_message(base64_image)
     [
       {
         type: "text",
-        text: "Analyse this image/document and provide a short description/summary of its content in no more than 2 sentences."    
+        text: "Analyse this image/document and provide a short description/summary of its contents in no more than 2 sentences."
+      },
+      {
+        type: "image_url",
+        image_url: {
+          url: "data:image/jpeg;base64,#{base64_image}"
+        }
+      }
+    ]
+  end
+
+  def generate_document_tags(user_content)
+    response = client.chat(
+      parameters: {
+        model: "gpt-4o-mini",
+        messages: [
+          {
+            role: "system",
+            content: "You are an AI expert in reviewing and tagging documents with expertise in the UK housing/planning system. When tagging documents use ONLY the following predefined options:
+            - **DRAWING TAGS**: #{Document::DRAWING_TAGS.join(", ")}
+            - **EVIDENCE TAGS**: #{Document::EVIDENCE_TAGS.join(", ")}
+            - **SUPPORTING DOCUMENT TAGS**: #{Document::SUPPORTING_DOCUMENT_TAGS.join(", ")}"
+          },
+          {
+            role: "user",
+            content: user_content
+          }
+        ]
+      }
+    )
+    response.dig("choices", 0, "message", "content").split(", ").map(&:strip)
+  end
+
+  def user_message_tags(base64_image)
+    [
+      {
+        type: "text",
+        text: "Analyse this image/document and assign relevant document tags from the supplied lists.
+        ONLY choose tags from these lists. You may choose more than one tag if relevant. Provide a comma separated list of ONLY the tags."
       },
       {
         type: "image_url",
-        image_url: { 
+        image_url: {
           url: "data:image/jpeg;base64,#{base64_image}"
         }
       }

Diff for: app/views/documents/edit.html.erb

@@ -73,6 +73,10 @@
     <p class="govuk-body">
       <%= created_by(@document) %>
     </p>
+
+    <p class="govuk-body govuk-!-margin-bottom-0">
+      <strong>AI summary:</strong> <%= @document.ai_summary %>
+    </p>
   </div>
   <div class="govuk-grid-column-full">
     <%= render "edit_and_upload" %>

Diff for: db/migrate/20250319102739_add_ai_summary_to_documents.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AddAiSummaryToDocuments < ActiveRecord::Migration[7.2]
   def change
     add_column :documents, :ai_summary, :text