Fix app volume tooltip and control in taskbar

Author: unchihugo

FluentFlyoutWPF/Classes/Utils/MediaPlayerData.cs

@@ -19,6 +19,7 @@ private class CachedMediaPlayerInfo
         public required string Title { get; set; }
         public ImageSource? Icon { get; set; }
         public int ProcessId { get; set; }
+        public required DateTime ProcessIdCheckedAt { get; set; }
     }
     // cache for media player info to avoid redundant process lookups
     private static readonly ConcurrentDictionary<string, CachedMediaPlayerInfo> mediaPlayerCache = [];
@@ -119,7 +120,8 @@ public static (string, ImageSource?) GetAndCacheMediaPlayerData(string mediaPlay
             {
                 Title = shellTitle,
                 Icon = shellIcon,
-                ProcessId = -1 // no process match, -1 avoids colliding with real PIDs
+                ProcessId = -1, // no process match, -1 avoids colliding with real PIDs
+                ProcessIdCheckedAt = DateTime.UtcNow
             };
 
             return (shellTitle, shellIcon);
@@ -141,7 +143,8 @@ public static (string, ImageSource?) GetAndCacheMediaPlayerData(string mediaPlay
         {
             Title = mediaTitle,
             Icon = mediaIcon,
-            ProcessId = processData.ProcessId
+            ProcessId = processData.ProcessId,
+            ProcessIdCheckedAt = DateTime.UtcNow
         };
 
         return (mediaTitle, mediaIcon);
@@ -151,9 +154,35 @@ public static (string, ImageSource?) GetAndCacheMediaPlayerData(string mediaPlay
     {
         GetAndCacheMediaPlayerData(mediaPlayerId);
 
-        if (!mediaPlayerCache.TryGetValue(mediaPlayerId, out var cachedInfo)
-            && (!mediaPlayerIdVariants.TryGetValue(mediaPlayerId, out var variantKey)
-            || !mediaPlayerCache.TryGetValue(variantKey, out cachedInfo))) return null;
+        string cacheKey;
+        if (mediaPlayerCache.TryGetValue(mediaPlayerId, out var cachedInfo))
+        {
+            cacheKey = mediaPlayerId;
+        }
+        else if (mediaPlayerIdVariants.TryGetValue(mediaPlayerId, out var variantKey)
+            && mediaPlayerCache.TryGetValue(variantKey, out cachedInfo))
+        {
+            cacheKey = variantKey;
+        }
+        else
+        {
+            return null;
+        }
+
+        if (cachedInfo.ProcessId > 0)
+            return cachedInfo.ProcessId;
+
+        if (DateTime.UtcNow - cachedInfo.ProcessIdCheckedAt < TimeSpan.FromSeconds(CACHE_DURATION_SECONDS))
+            return null;
+
+        mediaPlayerCache.TryRemove(cacheKey, out _);
+        mediaPlayerIdVariants.TryRemove(mediaPlayerId, out _);
+        GetAndCacheMediaPlayerData(mediaPlayerId);
+
+        if (!mediaPlayerCache.TryGetValue(mediaPlayerId, out cachedInfo)
+            && (!mediaPlayerIdVariants.TryGetValue(mediaPlayerId, out var refreshedVariantKey)
+            || !mediaPlayerCache.TryGetValue(refreshedVariantKey, out cachedInfo)))
+            return null;
 
         return cachedInfo.ProcessId > 0 ? cachedInfo.ProcessId : null;
     }
@@ -286,7 +315,8 @@ private static bool IsBrowser(string processName) =>
                 {
                     Title = title,
                     Icon = icon,
-                    ProcessId = processId
+                    ProcessId = processId,
+                    ProcessIdCheckedAt = DateTime.UtcNow
                 };
             }
 

FluentFlyoutWPF/Controls/TaskbarWidgetControl.xaml.cs

@@ -179,6 +179,8 @@ private void Grid_MouseEnter(object sender, MouseEventArgs e)
     {
         if (string.IsNullOrEmpty(SongTitle.Text + SongArtist.Text)) return;
 
+        RefreshAppVolumeTooltip();
+
         SolidColorBrush targetBackgroundBrush;
         // hover effects with animations, hard-coded colors because I can't find the resource brushes
         WindowsThemeDetector.GetWindowsTheme(out _, out var systemTheme);

FluentFlyoutWPF/MainWindow.xaml.cs

@@ -338,7 +338,7 @@ private static bool MatchesFilterEntry(string entry, string appName, string appI
 
         int? processId = MediaPlayerData.GetAndCacheProcessId(activeSession.Id);
         return processId.HasValue
-            ? volumeMixerViewModel.Sessions.FirstOrDefault(session => session.ProcessId == processId.Value)?.Volume
+            ? volumeMixerViewModel.GetSessionVolume(processId.Value)
             : null;
     }
 

FluentFlyoutWPF/ViewModels/VolumeMixerViewModel.cs

@@ -135,20 +135,30 @@ public bool TryAdjustMasterVolume(float delta)
 
     public bool TryAdjustSessionVolume(int processId, float delta)
     {
-        var session = Sessions.FirstOrDefault(session => session.ProcessId == processId);
+        var session = FindSession(processId);
 
         if (session == null)
-        {
-            RefreshSessions();
-            session = Sessions.FirstOrDefault(session => session.ProcessId == processId);
-        }
-
-        if (session == null) return false;
+            return false;
 
         session.AdjustVolume(delta);
         return true;
     }
 
+    public float? GetSessionVolume(int processId)
+    {
+        return FindSession(processId)?.Volume;
+    }
+
+    private AudioSessionModel? FindSession(int processId)
+    {
+        var session = Sessions.FirstOrDefault(session => session.ProcessId == processId);
+        if (session != null)
+            return session;
+
+        RefreshSessions();
+        return Sessions.FirstOrDefault(session => session.ProcessId == processId);
+    }
+
 
     public void SyncMasterFromDevice()
     {