Repository navigation
Fix Play/Pause button losing album art accent color on hover and press - #1118
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read and agree to the FluentFlyout CLA |
|
hi, @unchihugo , the CLA issue has not been resolved |
|
Should be fixed now, sorry Edit: ignore it for now! |
|
Hi @lgc2333, could you make it so that opacity is only changed for the background? Currently, the symbol/icon is also adjusted, and is the reason why I couldn't merge the referenced PR either. |
|
commited by agent hosted on cloud, haven't tested yet |
f86b400 to
249ef6e
Compare
|
hi, just a friendly reminder because there's no response for a while. review this if you have time :) |
|
Hi @lgc2333, I don't have access to a PC right now, so could you show the same hover behaviors currently in master compared to your branch? |
|
combine image 1, 5, 6, it's the original behavior |
…ly opaque Addresses review feedback: the hover/pressed opacity was applied to the ContentBorder element, which also dimmed the play/pause symbol icon. Move the ContentPresenter out of the ContentBorder as a sibling layer so the opacity triggers only affect the background.
249ef6e to
672f9c0
Compare
|
Bump for review. Anything blocking this? |
|
Hi @lgc2333, I was busy. Will merge now! |






Summary
Keep the album art accent color on the play/pause button in hover and pressed states instead of switching to the system accent shade.
Motivation
Closes #910. Supersedes #913.
Type of Change
What Changed
PlayPauseButtonStyleinMainWindow.xaml, based onMicaWPF.Styles.AccentedButton, keeping the sameGradientBordertemplate but replacing theMouseOver/Pressedvisual-state color animations with opacity triggers (IsMouseOver→ 0.9,IsPressed→ 0.8).ControlPlayPausenow uses that style.Additional Information
Root cause: the
AccentedButtontemplate animatesContentBorder.Background.ColortoAccentFillColorSecondary/Tertiaryin theMouseOver/Pressedvisual states. Animations outrank the localBackgroundset byUpdateUI, so the album art color only survived in the normal state — hover/press fell back to the system accent, and disabled usedAccentFillColorDisabled.Why not #913's approach: it replaces
GradientBorderwith a plainBorder, losing the accent inner stroke and theMargin="-2"extension, so the button renders smaller and flatter than the otherAccentedButtons; it also strips the file BOM and is based on stale code (already conflicting). This PR keeps the original template and only removes the color animation. The opacity values match Fluent's own accent hover/press fills (0.9/0.8), so hover intensity is unchanged; disabled keeps the album art color dimmed by the existingOpacity = 0.35.Checklist