Open
Description
When setting up a custom provider, a user can supply a dict of kwargs to be passed to that class's initializer. If one of these was called 'strict', this would be dropped by the code which calls the standard FlaskRedis initializer. I see two problems with this:
- Someone might mistakenly pass the arg strict, intending for it to have its usual effect, as well as a custom provider. This is really a documentation/logging issue as this combination is not consistent.
- Someone might want to pass a keyword arg 'strict' to their custom class. This is less likely, but would be quite annoying as it would fail silently.
A couple of proposed solutions:
- Add an assert at line 25 to check that 'strict' isn't present. This might be overkill.
- Pass through the argument 'strict' by saving it and re-adding it. This complicates the code a bit, and doesn't help with case 1.
- Warning but continuing.
Happy to submit a PR if given some guidance as to what is considered a good solution.
Metadata
Metadata
Assignees
Labels
No labels