capture and expose download errors

Author: amakropoulos

Runtime/LLM.cs

@@ -79,8 +79,10 @@ public class LLM : MonoBehaviour
         public bool started { get; protected set; } = false;
         /// <summary> Boolean set to true if the server has failed to start. </summary>
         public bool failed { get; protected set; } = false;
+        /// <summary> Boolean set to true if the models were not downloaded successfully. </summary>
+        public static bool downloadFailed { get; protected set; } = false;
         /// <summary> Boolean set to true if the server has started and is ready to receive requests, false otherwise. </summary>
-        public static bool modelsDownloaded { get; protected set; } = false;
+        public static bool downloadComplete { get; protected set; } = false;
 
         /// <summary> the LLM model to use.
         /// Models with .gguf format are allowed.</summary>
@@ -110,9 +112,10 @@ public async void Awake()
         {
             if (!enabled) return;
 #if !UNITY_EDITOR
-            await LLMManager.DownloadModels();
+            downloadFailed = !await LLMManager.DownloadModels();
 #endif
-            modelsDownloaded = true;
+            downloadComplete = true;
+            if (downloadFailed) return;
             await AndroidSetup();
             string arguments = GetLlamaccpArguments();
             if (arguments == null) return;
@@ -147,10 +150,11 @@ public async Task WaitUntilReady()
             while (!started) await Task.Yield();
         }
 
-        public static async Task WaitUntilModelsDownloaded(Callback<float> downloadProgressCallback = null)
+        public static async Task<bool> WaitUntilModelsDownloaded(Callback<float> downloadProgressCallback = null)
         {
             if (downloadProgressCallback != null) LLMManager.downloadProgressCallbacks.Add(downloadProgressCallback);
-            while (!modelsDownloaded) await Task.Yield();
+            while (!downloadComplete) await Task.Yield();
+            return !downloadFailed;
         }
 
         /// <summary>

Runtime/LLMManager.cs

@@ -32,7 +32,7 @@ public class LLMManager
     {
         public static float downloadProgress = 1;
         public static List<Callback<float>> downloadProgressCallbacks = new List<Callback<float>>();
-        static Task downloadModelsTask;
+        static Task<bool> downloadModelsTask;
         static readonly object lockObject = new object();
         static long totalSize;
         static long currFileSize;
@@ -44,7 +44,7 @@ public static void SetDownloadProgress(float progress)
             foreach (Callback<float> downloadProgressCallback in downloadProgressCallbacks) downloadProgressCallback?.Invoke(downloadProgress);
         }
 
-        public static Task DownloadModels()
+        public static Task<bool> DownloadModels()
         {
             lock (lockObject)
             {
@@ -53,10 +53,10 @@ public static Task DownloadModels()
             return downloadModelsTask;
         }
 
-        public static async Task DownloadModelsOnce()
+        public static async Task<bool> DownloadModelsOnce()
         {
             if (Application.platform == RuntimePlatform.Android) await LLMUnitySetup.AndroidExtractFile(LLMUnitySetup.BuildFilename);
-            if (!File.Exists(LLMUnitySetup.BuildFile)) return;
+            if (!File.Exists(LLMUnitySetup.BuildFile)) return true;
 
             List<StringPair> downloads = new List<StringPair>();
             using (FileStream fs = new FileStream(LLMUnitySetup.BuildFile, FileMode.Open, FileAccess.Read))
@@ -71,7 +71,7 @@ public static async Task DownloadModelsOnce()
                     }
                 }
             }
-            if (downloads.Count == 0) return;
+            if (downloads.Count == 0) return true;
 
             try
             {
@@ -100,9 +100,10 @@ public static async Task DownloadModelsOnce()
             }
             catch (Exception ex)
             {
-                LLMUnitySetup.LogError($"Error downloading the models");
-                throw ex;
+                LLMUnitySetup.LogError($"Error downloading the models: {ex.Message}");
+                return false;
             }
+            return true;
         }
 
 #if UNITY_EDITOR