Skip to content

proper ruff

proper ruff #218

Triggered via pull request March 27, 2025 15:44
Status Failure
Total duration 7m 21s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors
Ruff (ANN201): app/build/lib/hope_country_report/api/serializers.py#L36
build/lib/hope_country_report/api/serializers.py:36:9: ANN201 Missing return type annotation for public function `get_office`
Ruff (PERF102): app/build/lib/hope_country_report/apps/admin/sites.py#L31
build/lib/hope_country_report/apps/admin/sites.py:31:25: PERF102 When using only the values of a dict use the `values()` method
Ruff (DJ007): app/build/lib/hope_country_report/apps/core/admin.py#L36
build/lib/hope_country_report/apps/core/admin.py:36:9: DJ007 Do not use `__all__` with `ModelForm`, use `fields` instead
Ruff (ERA001): app/build/lib/hope_country_report/apps/core/admin.py#L47
build/lib/hope_country_report/apps/core/admin.py:47:5: ERA001 Found commented-out code
Ruff (ANN201): app/build/lib/hope_country_report/apps/core/admin.py#L67
build/lib/hope_country_report/apps/core/admin.py:67:9: ANN201 Missing return type annotation for public function `get_queryset`
Ruff (ANN001): app/build/lib/hope_country_report/apps/core/admin.py#L67
build/lib/hope_country_report/apps/core/admin.py:67:28: ANN001 Missing type annotation for function argument `request`
Ruff (PLR1714): app/build/lib/hope_country_report/apps/core/dbrouters.py#L21
build/lib/hope_country_report/apps/core/dbrouters.py:21:12: PLR1714 Consider merging multiple comparisons: `db in {"hope", "hope_ro"}`.
Ruff (SIM118): app/build/lib/hope_country_report/apps/core/management/commands/demo.py#L36
build/lib/hope_country_report/apps/core/management/commands/demo.py:36:13: SIM118 Use `key in dict` instead of `key in dict.keys()`
Ruff (C408): app/build/lib/hope_country_report/apps/core/management/commands/demo.py#L48
build/lib/hope_country_report/apps/core/management/commands/demo.py:48:22: C408 Unnecessary `dict()` call (rewrite as a literal)
Ruff (C408): app/build/lib/hope_country_report/apps/core/management/commands/demo.py#L52
build/lib/hope_country_report/apps/core/management/commands/demo.py:52:22: C408 Unnecessary `dict()` call (rewrite as a literal)