Merge pull request #113 from unicef/feature/247635-userrole-check-program-matches-office

AB#247635: Check program matches office for UserRole

Author: sergey-misuk-valor

src/country_workspace/models/role.py

@@ -1,12 +1,17 @@
 from django.contrib.auth.models import Group
+from django.core.exceptions import ValidationError
 from django.db import models
+from django.utils.translation import gettext as _
 
 from .base import BaseModel
 from .office import Office
 from .program import Program
 from .user import User
 
 
+PROGRAM_DOES_NOT_BELONG_TO_OFFICE = "Program does not belong to country office"
+
+
 class UserRole(BaseModel):
     user = models.ForeignKey(User, on_delete=models.CASCADE, related_name="roles")
     country_office = models.ForeignKey(Office, on_delete=models.CASCADE)
@@ -21,3 +26,8 @@ class Meta:
                 fields=["user", "country_office", "group"],
             ),
         )
+
+    def clean(self) -> None:
+        super().clean()
+        if self.program and self.program.country_office != self.country_office:
+            raise ValidationError({"program": _(PROGRAM_DOES_NOT_BELONG_TO_OFFICE)})

tests/models/test_role.py

@@ -0,0 +1,36 @@
+import pytest
+from django.core.exceptions import ValidationError
+
+from country_workspace.models import Program, Office, UserRole
+from country_workspace.models.role import PROGRAM_DOES_NOT_BELONG_TO_OFFICE
+from testutils.factories import ProgramFactory, OfficeFactory
+
+
+@pytest.fixture
+def office() -> Office:
+    return OfficeFactory()
+
+
+@pytest.fixture
+def another_office() -> Office:
+    return OfficeFactory()
+
+
+@pytest.fixture
+def program(office: Office) -> Program:
+    return ProgramFactory(country_office=office)
+
+
+def test_clean_no_program(office: Office) -> None:
+    UserRole(country_office=office).clean()
+
+
+def test_clean_with_correct_office_and_program(office: Office, program: Program) -> None:
+    UserRole(country_office=office, program=program).clean()
+
+
+def test_clean_with_incorrect_office_and_program(another_office: Office, program: Program) -> None:
+    with pytest.raises(ValidationError) as e:
+        UserRole(country_office=another_office, program=program).clean()
+
+    assert e.value.messages == [PROGRAM_DOES_NOT_BELONG_TO_OFFICE]