Add fieldsets for document and account#149
Merged
domdinicola merged 3 commits intodevelopfrom Jun 26, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #149 +/- ##
===========================================
+ Coverage 95.37% 95.38% +0.01%
===========================================
Files 170 171 +1
Lines 5400 5415 +15
Branches 474 474
===========================================
+ Hits 5150 5165 +15
Misses 152 152
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
domdinicola
reviewed
Jun 23, 2025
| document_fields = [ | ||
| ("document_number", {"field_type": forms.CharField}, {}), | ||
| ("photo", {"field_type": Base64ImageField}, {}), | ||
| ("issuance_date", {"field_type": forms.DateField}, {}), |
Collaborator
There was a problem hiding this comment.
let's add country (former issuer)
domdinicola
reviewed
Jun 23, 2025
|
|
||
| account_fields = [ | ||
| ("number", {"field_type": forms.CharField}, {}), | ||
| ("data", {"field_type": forms.JSONField}, {}), |
Collaborator
There was a problem hiding this comment.
we need to add financial_institution (we need to sync them from HOPE)
datamik
force-pushed
the
feature/fieldsets-for-account-and-document
branch
from
e5e22dd to
856bfbb
Compare
datamik
force-pushed
the
feature/fieldsets-for-account-and-document
branch
from
856bfbb to
b7e5093
Compare
datamik
force-pushed
the
feature/fieldsets-for-account-and-document
branch
from
b7e5093 to
6873e0a
Compare
domdinicola
approved these changes
Jun 25, 2025
patsatsia
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legal Boilerplate
Look, I get it.
Contributing to HOPE Workspace, I retain all rights, title and interest in and to my contributions, and by keeping
this boilerplate intact I confirm that HOPE Workspace can use, modify, copy, and redistribute my contributions,
under HOPE's choice of terms.