use validate with choices when import instead of checkboxes#161
Merged
domdinicola merged 3 commits intodevelopfrom Jul 11, 2025
Merged
use validate with choices when import instead of checkboxes#161domdinicola merged 3 commits intodevelopfrom
domdinicola merged 3 commits intodevelopfrom
Conversation
vitali-yanushchyk-valor
force-pushed
the
feature/262502-fail_if_alien-default-as-true
branch
4 times, most recently
from
2acd034 to
2982e96
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #161 +/- ##
===========================================
- Coverage 95.40% 95.40% -0.01%
===========================================
Files 177 177
Lines 5550 5567 +17
Branches 492 493 +1
===========================================
+ Hits 5295 5311 +16
Misses 157 157
- Partials 98 99 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vitali-yanushchyk-valor
requested review from
datamik,
domdinicola,
patsatsia and
sergey-misuk-valor
Collaborator
|
@vitali-yanushchyk-valor pls fix conflicts |
vitali-yanushchyk-valor
force-pushed
the
feature/262502-fail_if_alien-default-as-true
branch
2 times, most recently
from
8c1ee73 to
411a861
Compare
domdinicola
approved these changes
Jul 10, 2025
vitali-yanushchyk-valor
force-pushed
the
feature/262502-fail_if_alien-default-as-true
branch
from
411a861 to
a8ba5cb
Compare
vitali-yanushchyk-valor
changed the title
vitali-yanushchyk-valor
force-pushed
the
feature/262502-fail_if_alien-default-as-true
branch
2 times, most recently
from
5fe05d4 to
7f01f5f
Compare
domdinicola
approved these changes
Jul 10, 2025
vitali-yanushchyk-valor
force-pushed
the
feature/262502-fail_if_alien-default-as-true
branch
from
7f01f5f to
62d55ab
Compare
|
|
||
|
|
||
| class ImportFileForm(forms.Form): | ||
| class ValidateMode(TextChoices): |
Contributor
There was a problem hiding this comment.
ValidationMode sounds more correct
sergey-misuk-valor
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#262502
AB#262236