Merged
Conversation
…ate program. Removed unused fail_if_alien checkbox from the import form Fix/add unit tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #331 +/- ##
===========================================
+ Coverage 96.51% 96.53% +0.02%
===========================================
Files 224 224
Lines 8745 8767 +22
Branches 887 895 +8
===========================================
+ Hits 8440 8463 +23
Misses 171 171
+ Partials 134 133 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| hh_aliens = _find_alien_fields(instance) | ||
| ind_aliens: set[str] = set() | ||
| for member in instance.members.all(): | ||
| ind_aliens = _find_alien_fields(member) |
Contributor
There was a problem hiding this comment.
According to the current flow, should validation stop at the first member with alien fields, or collect aliens from all members and report them together?
Contributor
Author
There was a problem hiding this comment.
Yes, we should stop at the first alien found. No need to check all the members.
vitali-yanushchyk-valor
approved these changes
Feb 16, 2026
arsen-vs
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#300008
Fix alien fields check for validate button, validate action and validate program.
Removed unused fail_if_alien checkbox from the import form
Fix/add unit tests