ut

Author: marekbiczysko

tests/unit/apps/core/test_core_celery_tasks.py

@@ -66,23 +66,29 @@ def test_upload_kobo_template_with_retry_sets_unsuccessful_when_failed_time_is_o
 
 
 def test_upload_kobo_template_with_retry_retries_when_failed_time_is_recent(xlsx_kobo_template):
-    # With CELERY_TASK_ALWAYS_EAGER=True, self.retry() re-runs the task eagerly.
-    # After max_retries are exhausted, the original exc (KoboRetriableError) is re-raised.
     xlsx_kobo_template.first_connection_failed_time = timezone.now() - timedelta(minutes=30)
     exc = KoboRetriableError(xlsx_kobo_template)
 
     mock_instance = MagicMock()
     mock_instance.execute.side_effect = exc
     mock_task_cls = MagicMock(return_value=mock_instance)
 
-    with patch(
-        "hope.apps.core.tasks.upload_new_template_and_update_flex_fields.UploadNewKoboTemplateAndUpdateFlexFieldsTask",
-        mock_task_cls,
+    with (
+        patch(
+            "hope.apps.core.tasks.upload_new_template_and_update_flex_fields.UploadNewKoboTemplateAndUpdateFlexFieldsTask",
+            mock_task_cls,
+        ),
+        patch(
+            "hope.apps.core.celery_tasks.upload_new_kobo_template_and_update_flex_fields_task_with_retry_async_task"
+        ) as mock_retry_task,
     ):
         job = AsyncRetryJob.objects.create(
             type="JOB_TASK",
             action="hope.apps.core.celery_tasks.upload_new_kobo_template_and_update_flex_fields_task_with_retry_async_task_action",
             config={"xlsx_kobo_template_id": str(xlsx_kobo_template.id)},
         )
-        with pytest.raises(KoboRetriableError):
-            upload_new_kobo_template_and_update_flex_fields_task_with_retry_async_task_action(job)
+        upload_new_kobo_template_and_update_flex_fields_task_with_retry_async_task_action(job)
+
+    job.refresh_from_db()
+    assert job.errors == {"exception": str(exc)}
+    mock_retry_task.assert_called_once_with(str(xlsx_kobo_template.id))