Skip to content

Commit bad4cec

Browse files
author
ArsenPidhoretskyi
committed
Refactor code for improved readability in biometric deduplication service and unit tests
- Cleaned up the formatting of list comprehensions in `biometric_deduplication.py` for better clarity. - Adjusted indentation in the test case for `test_create_single_individual_success` in `test_lax_individuals.py` to enhance readability.
1 parent d697c99 commit bad4cec

2 files changed

Lines changed: 14 additions & 11 deletions

File tree

src/hope/apps/registration_data/services/biometric_deduplication.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1+
from collections.abc import Iterable
12
import logging
23
from typing import cast
3-
from collections.abc import Iterable
44

55
from django.conf import settings
66
from django.db import transaction
@@ -371,12 +371,15 @@ def fetch_biometric_deduplication_results_and_process(
371371
pending_individuals = PendingIndividual.objects.filter(registration_data_import__in=rdis).only(
372372
"id", "deduplication_engine_reference_pk"
373373
)
374-
target_reference_pks = [self._reference_pk_for_individual(individual) for individual in pending_individuals]
374+
target_reference_pks = [
375+
self._reference_pk_for_individual(individual) for individual in pending_individuals
376+
]
375377
all_program_individuals = Individual.all_objects.filter(program=program, is_removed=False).only(
376378
"id", "deduplication_engine_reference_pk"
377379
)
378380
reference_to_individual_id = {
379-
self._reference_pk_for_individual(individual): str(individual.pk) for individual in all_program_individuals
381+
self._reference_pk_for_individual(individual): str(individual.pk)
382+
for individual in all_program_individuals
380383
}
381384

382385
data = self.get_deduplication_set_results(program, target_reference_pks)

tests/unit/api/test_lax_individuals.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -144,14 +144,14 @@ def test_create_single_individual_success(lax_api_client, lax_push_url, document
144144
assert response.data["errors"] == 0
145145
assert "IND001" in response.data["individual_id_mapping"]
146146

147-
individual = PendingIndividual.objects.get(unicef_id=list(response.data["individual_id_mapping"].values())[0])
148-
assert individual.full_name == "John Doe"
149-
assert individual.given_name == "John"
150-
assert individual.family_name == "Doe"
151-
assert individual.observed_disability == ["NONE"]
152-
assert individual.marital_status == "SINGLE"
153-
assert individual.originating_id == "AUR#123#123"
154-
assert individual.deduplication_engine_reference_pk == "IND001"
147+
individual = PendingIndividual.objects.get(unicef_id=list(response.data["individual_id_mapping"].values())[0])
148+
assert individual.full_name == "John Doe"
149+
assert individual.given_name == "John"
150+
assert individual.family_name == "Doe"
151+
assert individual.observed_disability == ["NONE"]
152+
assert individual.marital_status == "SINGLE"
153+
assert individual.originating_id == "AUR#123#123"
154+
assert individual.deduplication_engine_reference_pk == "IND001"
155155

156156

157157
def test_create_single_individual_account_with_explicit_fi(

0 commit comments

Comments
 (0)