review

Author: pavlo-mk

src/hope/apps/utils/age_at_registration.py

@@ -11,9 +11,10 @@ def calculate_age_at_registration(
     try:
         birth_date_parsed = parser.parse(birth_date).date()
         created_at_date = created_at.date()
-        # return None if birth_date is future date
-        if birth_date_parsed > created_at_date:
+        calculated_age_years = relativedelta(created_at_date, birth_date_parsed).years
+        # return None if age is less then 0
+        if calculated_age_years > 0:
             return None
-        return relativedelta(created_at_date, birth_date_parsed).years
+        return calculated_age_years
     except ValueError:
         return None

tests/unit/apps/utils/test_age_at_registration.py

@@ -3,14 +3,22 @@
 from hope.apps.utils.age_at_registration import calculate_age_at_registration
 
 
-def test_calculate_age_at_registration() -> None:
-    # ValueError
+def test_calculate_age_at_registration_value_error() -> None:
     result = calculate_age_at_registration(datetime(2026, 10, 10), "ValueErrorHere")
     assert result is None
 
+
+def test_calculate_age_at_registration_future_birthday() -> None:
     # birthdate in future
     result = calculate_age_at_registration(datetime(2026, 10, 10), "9999-10-10")
     assert result is None
 
+
+def test_calculate_age_at_registration_zero() -> None:
+    result = calculate_age_at_registration(datetime(2023, 12, 12), "2023-12-12")
+    assert result == 0
+
+
+def test_calculate_age_at_registration() -> None:
     result = calculate_age_at_registration(datetime(2025, 10, 10), "2000-10-10")
     assert result == 25