Remove the dropdown with quick links, fix formatting

Author: pkujawa

src/hope/apps/administration/admin_site.py

@@ -1,7 +1,6 @@
 from collections import OrderedDict
 from typing import TYPE_CHECKING, Any
 
-from constance import config
 from django.conf import settings
 from django.contrib import messages
 from django.contrib.admin.models import LogEntry
@@ -29,43 +28,6 @@ def dashboard_callback(request: Any, context: dict[str, Any]) -> dict[str, Any]:
     return context
 
 
-def clean(v: str) -> str:
-    return v.replace(r"\n", "").strip()
-
-
-def site_dropdown_callback(request: Any) -> list[dict[str, Any]]:
-    """Return Constance QUICK_LINKS as Unfold SITE_DROPDOWN items.
-
-    Replaces the smart_admin SMART_ADMIN_BOOKMARKS mechanism. Each non-empty
-    line in `QUICK_LINKS` becomes a dropdown entry. Supported formats:
-
-        title,url        → entry rendered as a link
-        url              → entry where title and url are the same
-        --               → ignored (smart_admin used this as a separator;
-                            Unfold's dropdown does not support separators)
-    """
-    items: list[dict[str, Any]] = []
-    for raw in config.QUICK_LINKS.split("\n"):
-        entry = clean(raw)
-        if not entry or entry == "--":
-            continue
-        parts = [p.strip() for p in entry.split(",") if p.strip()]
-        if not parts:
-            continue
-        if len(parts) == 1:
-            title = link = parts[0]
-        else:
-            title, link = parts[0], parts[1]
-        items.append(
-            {
-                "title": title,
-                "link": link,
-                "attrs": {"target": "_blank", "rel": "noopener"},
-            }
-        )
-    return items
-
-
 # admin view
 def clear_cache_view(request: "HttpRequest") -> "HttpResponse":
     template = "admin/clear_cache.html"

src/hope/apps/administration/templates/unfold/helpers/navigation_header.html

@@ -1,24 +1,15 @@
 {% load unfold %}
 
-<div class="border-b border-base-200 flex gap-3 items-center h-[65px] mb-6 dark:border-base-800 px-3 {% element_classes 'navigation_header' %}" {% if site_dropdown %}x-data="{ openDropdown: false }"{% endif %}>
-    <a href="{% url 'admin:index' %}" class="bg-transparent flex font-semibold gap-3 grow min-w-0 h-[64px] items-center px-3 transition-all hover:bg-base-100 dark:hover:bg-white/[.06] {% if site_dropdown %}-mx-3 px-6{% endif %}">
+<div class="border-b border-base-200 flex gap-3 items-center h-[65px] mb-6 dark:border-base-800 px-3 {% element_classes 'navigation_header' %}">
+    <a href="{% url 'admin:index' %}" class="bg-transparent flex font-semibold gap-3 grow min-w-0 h-[64px] items-center -mx-3 px-6 transition-all hover:bg-base-100 dark:hover:bg-white/[.06]">
         {% if site_logo %}
             {% include "unfold/helpers/site_logo.html" %}
         {% elif branding %}
             {% include "unfold/helpers/site_icon.html" %}
         {% endif %}
     </a>
 
-    {% if site_dropdown %}
-        <span class="material-symbols-outlined cursor-pointer select-none text-font-default-light dark:text-font-default-dark hover:text-base-700 dark:hover:text-base-200"
-              x-on:click="openDropdown = !openDropdown">
-            unfold_more
-        </span>
-    {% endif %}
-
     <span class="material-symbols-outlined block cursor-pointer h-[18px] xl:hidden! hover:text-base-700 dark:hover:text-base-200" x-on:click="sidebarMobileOpen = !sidebarMobileOpen">
         close
     </span>
-
-    {% include "unfold/helpers/site_dropdown.html" %}
 </div>

src/hope/apps/administration/templates/unfold/helpers/site_branding.html

@@ -0,0 +1,3 @@
+<div id="site-name">
+    {{ site_header|default:_('Django administration') }}
+</div>

src/hope/config/fragments/unfold.py

@@ -20,7 +20,6 @@
     "SHOW_HISTORY": True,
     "SHOW_VIEW_ON_SITE": True,
     "ENVIRONMENT": "hope.config.fragments.unfold.environment_callback",
-    "SITE_DROPDOWN": "hope.apps.administration.admin_site.site_dropdown_callback",
     "STYLES": [
         lambda request: static("admin/css/hope_admin.css"),
     ],
@@ -772,9 +771,7 @@
                 "items": [
                     {
                         "title": _("Universal updates"),
-                        "link": reverse_lazy(
-                            "admin:universal_update_script_universalupdate_changelist"
-                        ),
+                        "link": reverse_lazy("admin:universal_update_script_universalupdate_changelist"),
                         "icon": "update",
                     },
                 ],