fixing errors in tests

Author: johniak

src/hope/apps/generic_import/celery_tasks.py

@@ -1,8 +1,15 @@
+from sentry_sdk import capture_exception
+
 from hope.apps.core.celery import app
+from hope.apps.generic_import.generic_upload_service.importer import Importer
+from hope.apps.generic_import.generic_upload_service.parsers.xlsx_somalia_parser import (
+    XlsxSomaliaParser,
+)
+from hope.apps.registration_data.models import ImportData, RegistrationDataImport
 from hope.apps.registration_datahub.celery_tasks import locked_cache
 from hope.apps.registration_datahub.exceptions import AlreadyRunningError
 from hope.apps.utils.logs import log_start_and_end
-from hope.apps.utils.sentry import sentry_tags
+from hope.apps.utils.sentry import sentry_tags, set_sentry_business_area_tag
 
 SOFT_TIME_LIMIT = 30 * 60
 HARD_TIME_LIMIT = 35 * 60
@@ -71,13 +78,6 @@ def process_generic_import_task(
     """
     import logging
 
-    from hope.apps.generic_import.generic_upload_service.importer import Importer
-    from hope.apps.generic_import.generic_upload_service.parsers.xlsx_somalia_parser import (
-        XlsxSomaliaParser,
-    )
-    from hope.apps.registration_data.models import ImportData, RegistrationDataImport
-    from hope.apps.utils.sentry import set_sentry_business_area_tag
-
     logger = logging.getLogger(__name__)
 
     try:
@@ -162,8 +162,6 @@ def process_generic_import_task(
 
         # Update error status
         try:
-            from sentry_sdk import capture_exception
-
             sentry_id = capture_exception(e)
         except Exception as exc:
             logger.exception(exc)

tests/unit/apps/generic_import/test_celery_tasks.py

@@ -86,8 +86,8 @@ def test_task_success_flow(self, mock_parser_class, mock_importer_class):
         assert rdi.status == RegistrationDataImport.IN_REVIEW
 
         # Verify parser was called
-        mock_parser_class.assert_called_once_with(import_data.file.path)
-        mock_parser.parse.assert_called_once()
+        mock_parser_class.assert_called_once_with()
+        mock_parser.parse.assert_called_once_with(import_data.file.path)
 
         # Verify importer was created and called
         assert mock_importer_class.called

tests/unit/apps/generic_import/test_views.py

@@ -2,6 +2,7 @@
 from unittest.mock import patch
 
 from django.core.files.uploadedfile import SimpleUploadedFile
+from django.db import DatabaseError
 from django.test import TransactionTestCase
 from django.urls import reverse
 from django.utils import timezone
@@ -433,7 +434,7 @@ def test_database_error_prevents_task_trigger(self, mock_create, mock_delay):
         self.client.force_login(self.user, "django.contrib.auth.backends.ModelBackend")
 
         # Simulate database error
-        mock_create.side_effect = Exception("Database error")
+        mock_create.side_effect = DatabaseError("Database error")
 
         uploaded_file = self._create_upload_file()