Skip to content

Commit 4df8405

Browse files
committed
fix part 1: added unstable
1 parent bcf9a4a commit 4df8405

File tree

9 files changed

+32
-29
lines changed

9 files changed

+32
-29
lines changed

components/icu/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ unstable = [
128128
"icu_calendar/unstable",
129129
"icu_datetime/unstable",
130130
"icu_plurals/unstable",
131+
"icu_segmenter/unstable",
131132
"icu_time/unstable",
132133
"dep:icu_experimental",
133134
"dep:icu_pattern",

components/segmenter/src/provider/mod.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
#![allow(clippy::exhaustive_structs, clippy::exhaustive_enums)]
1717

1818
mod lstm;
19-
mod radical;
2019
pub use lstm::*;
21-
pub use radical::*;
20+
#[cfg(feature = "unstable")]
21+
pub mod radical;
2222

2323
use crate::options::WordType;
2424
use icu_collections::codepointtrie::CodePointTrie;
@@ -139,7 +139,8 @@ pub const MARKERS: &[DataMarkerInfo] = &[
139139
SegmenterDictionaryAutoV1::INFO,
140140
SegmenterDictionaryExtendedV1::INFO,
141141
SegmenterLstmAutoV1::INFO,
142-
SegmenterUnihanRadicalV1::INFO,
142+
#[cfg(feature = "unstable")]
143+
radical::SegmenterUnihanRadicalV1::INFO,
143144
];
144145

145146
/// Pre-processed Unicode data in the form of tables to be used for rule-based breaking.

components/segmenter/src/provider/radical.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use icu_provider::prelude::*;
1010
/// Data for Unihan IRG sources (Radicals).
1111
#[derive(Debug, PartialEq, Clone, yoke::Yokeable, zerofrom::ZeroFrom)]
1212
#[cfg_attr(feature = "datagen", derive(serde::Serialize, databake::Bake))]
13-
#[cfg_attr(feature = "datagen", databake(path = icu_segmenter::provider))]
13+
#[cfg_attr(feature = "datagen", databake(path = icu_segmenter::provider::radical))]
1414
#[cfg_attr(feature = "serde", derive(serde::Deserialize))]
1515
pub struct UnihanIrgData<'data> {
1616
/// Trie mapping code points to their IRG source radical ID (u8).
@@ -24,7 +24,7 @@ icu_provider::data_struct!(
2424
);
2525

2626
icu_provider::data_marker!(
27-
/// `SegmenterUnihanRadicalV1`
27+
/// Marker for the singleton trie mapping code points to their Unihan IRG source radical IDs.
2828
SegmenterUnihanRadicalV1,
2929
"segmenter/unihan/radical/v1",
3030
UnihanIrgData<'static>,

components/segmenter/tests/adaboost/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
#![allow(dead_code)]
66

7-
use icu_segmenter::provider::{Baked, UnihanIrgData};
7+
use icu_segmenter::provider::{radical::UnihanIrgData, Baked};
88
use std::collections::HashMap;
99

1010
fn load_irg_from_baked() -> &'static UnihanIrgData<'static> {

provider/data/segmenter/data/segmenter_unihan_radical_v1.rs.data

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

provider/data/segmenter/stubdata/segmenter_unihan_radical_v1.rs.data

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

provider/registry/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ macro_rules! registry(
341341
icu::experimental::transliterate::provider::TransliteratorRulesV1: TransliteratorRulesV1,
342342
icu::experimental::units::provider::UnitsInfoV1: UnitsInfoV1,
343343
icu::plurals::provider::PluralsRangesV1: PluralsRangesV1,
344-
icu::segmenter::provider::SegmenterUnihanRadicalV1: SegmenterUnihanRadicalV1,
344+
icu::segmenter::provider::radical::SegmenterUnihanRadicalV1: SegmenterUnihanRadicalV1,
345345
);
346346
}
347347
);

provider/source/src/segmenter/mod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ use zerovec::ZeroVec;
2828

2929
mod dictionary;
3030
mod lstm;
31+
#[cfg(feature = "unstable")]
3132
mod unihan;
3233

3334
// state machine name define by builtin name

provider/source/src/segmenter/unihan.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
77
use crate::{IterableDataProviderCached, SourceDataProvider};
88
use icu::collections::codepointtrie;
9-
use icu::segmenter::provider::{SegmenterUnihanRadicalV1, UnihanIrgData};
9+
use icu::segmenter::provider::radical::{SegmenterUnihanRadicalV1, UnihanIrgData};
1010
#[cfg(any(feature = "use_wasm", feature = "use_icu4c"))]
1111
use icu_codepointtrie_builder::CodePointTrieBuilder;
1212
use icu_provider::prelude::*;
@@ -60,7 +60,7 @@ impl IterableDataProviderCached<SegmenterUnihanRadicalV1> for SourceDataProvider
6060
#[cfg(test)]
6161
mod tests {
6262
use crate::SourceDataProvider;
63-
use icu::segmenter::provider::SegmenterUnihanRadicalV1;
63+
use icu::segmenter::provider::radical::SegmenterUnihanRadicalV1;
6464
use icu_provider::prelude::*;
6565

6666
#[test]

0 commit comments

Comments
 (0)