add enumerated property NumericType to icu_properties (#7157)

<!--
Thank you for your pull request to ICU4X!

Reminder: try to use [Conventional
Comments](https://conventionalcomments.org/) to make comments clearer.

Please see
https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for
general
information on contributing to ICU4X.
-->

did not find an existing issue issue, but i needed (wanted) to read this
property and found out it wasn't available, so here it is ...

---------

Co-authored-by: Robert Bastian <[email protected]>

Author: m4rch3n1ng

components/properties/src/names.rs

@@ -807,6 +807,14 @@ impl_value_getter! {
     }
 }
 
+impl_value_getter! {
+    impl NumericType {
+        PropertyNameParseNumericTypeV1 / SINGLETON_PROPERTY_NAME_PARSE_NUMERIC_TYPE_V1;
+        PropertyEnumToValueNameLinearMap / PropertyNameShortNumericTypeV1 / SINGLETON_PROPERTY_NAME_SHORT_NUMERIC_TYPE_V1;
+        PropertyEnumToValueNameLinearMap / PropertyNameLongNumericTypeV1 / SINGLETON_PROPERTY_NAME_LONG_NUMERIC_TYPE_V1;
+    }
+}
+
 impl_value_getter! {
     impl GeneralCategory {
         PropertyNameParseGeneralCategoryV1 / SINGLETON_PROPERTY_NAME_PARSE_GENERAL_CATEGORY_V1;

components/properties/src/props.rs

@@ -233,6 +233,73 @@ make_enumerated_property! {
     ule_ty: u8;
 }
 
+/// Enumerated property Numeric_Type.
+///
+/// See Section 4.6, Numeric Value in The Unicode Standard for the summary of
+/// each property value.
+///
+/// # Example
+///
+/// ```
+/// use icu::properties::{props::NumericType, CodePointMapData};
+///
+/// assert_eq!(
+///     CodePointMapData::<NumericType>::new().get('0'),
+///     NumericType::Decimal,
+/// ); // U+0030
+/// assert_eq!(
+///     CodePointMapData::<NumericType>::new().get('½'),
+///     NumericType::Numeric,
+/// ); // U+00BD
+/// ```
+#[derive(Copy, Clone, Debug, Eq, PartialEq, Ord, PartialOrd, Hash)]
+#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
+#[allow(clippy::exhaustive_structs)] // newtype
+#[repr(transparent)]
+pub struct NumericType(pub(crate) u8);
+
+impl NumericType {
+    /// Returns an ICU4C `UNumericType` value.
+    pub const fn to_icu4c_value(self) -> u8 {
+        self.0
+    }
+    /// Constructor from an ICU4C `UNumericType` value.
+    pub const fn from_icu4c_value(value: u8) -> Self {
+        Self(value)
+    }
+}
+
+create_const_array! {
+#[allow(non_upper_case_globals)]
+impl NumericType {
+    /// Characters without numeric value
+    pub const None: NumericType = NumericType(0);
+    /// (`De`) Characters of positional decimal systems
+    ///
+    /// These are coextensive with [`GeneralCategory::DecimalNumber`].
+    pub const Decimal: NumericType = NumericType(1);
+    /// (`Di`) Variants of positional or sequences thereof.
+    ///
+    /// The distinction between [`NumericType::Digit`] and [`NumericType::Numeric`]
+    /// has not proven to be useful, so no further characters will be added to
+    /// this type.
+    pub const Digit: NumericType = NumericType(2);
+    /// (`Nu`) Other characters with numeric value
+    pub const Numeric: NumericType = NumericType(3);
+}
+#[test]
+fn numeric_type_consts();
+}
+
+make_enumerated_property! {
+    name: "Numeric_Type";
+    short_name: "nt";
+    ident: NumericType;
+    data_marker: crate::provider::PropertyEnumNumericTypeV1;
+    singleton: SINGLETON_PROPERTY_ENUM_NUMERIC_TYPE_V1;
+    ule_ty: u8;
+}
+
 // This exists to encapsulate GeneralCategoryULE so that it can exist in the provider module rather than props
 pub(crate) mod gc {
     /// Enumerated property General_Category.
@@ -3404,6 +3471,14 @@ mod test_enumerated_property_completeness {
         );
     }
 
+    #[test]
+    fn test_nt() {
+        check_enum(
+            crate::provider::Baked::SINGLETON_PROPERTY_NAME_PARSE_NUMERIC_TYPE_V1,
+            NumericType::ALL_VALUES,
+        );
+    }
+
     #[test]
     fn test_hst() {
         check_enum(

components/properties/src/provider.rs

@@ -27,21 +27,23 @@ pub use names::{
     PropertyNameLongGeneralCategoryV1, PropertyNameLongGraphemeClusterBreakV1,
     PropertyNameLongHangulSyllableTypeV1, PropertyNameLongIndicConjunctBreakV1,
     PropertyNameLongIndicSyllabicCategoryV1, PropertyNameLongJoiningTypeV1,
-    PropertyNameLongLineBreakV1, PropertyNameLongScriptV1, PropertyNameLongSentenceBreakV1,
-    PropertyNameLongVerticalOrientationV1, PropertyNameLongWordBreakV1,
-    PropertyNameParseBidiClassV1, PropertyNameParseCanonicalCombiningClassV1,
-    PropertyNameParseEastAsianWidthV1, PropertyNameParseGeneralCategoryMaskV1,
-    PropertyNameParseGeneralCategoryV1, PropertyNameParseGraphemeClusterBreakV1,
-    PropertyNameParseHangulSyllableTypeV1, PropertyNameParseIndicConjunctBreakV1,
-    PropertyNameParseIndicSyllabicCategoryV1, PropertyNameParseJoiningTypeV1,
-    PropertyNameParseLineBreakV1, PropertyNameParseScriptV1, PropertyNameParseSentenceBreakV1,
+    PropertyNameLongLineBreakV1, PropertyNameLongNumericTypeV1, PropertyNameLongScriptV1,
+    PropertyNameLongSentenceBreakV1, PropertyNameLongVerticalOrientationV1,
+    PropertyNameLongWordBreakV1, PropertyNameParseBidiClassV1,
+    PropertyNameParseCanonicalCombiningClassV1, PropertyNameParseEastAsianWidthV1,
+    PropertyNameParseGeneralCategoryMaskV1, PropertyNameParseGeneralCategoryV1,
+    PropertyNameParseGraphemeClusterBreakV1, PropertyNameParseHangulSyllableTypeV1,
+    PropertyNameParseIndicConjunctBreakV1, PropertyNameParseIndicSyllabicCategoryV1,
+    PropertyNameParseJoiningTypeV1, PropertyNameParseLineBreakV1, PropertyNameParseNumericTypeV1,
+    PropertyNameParseScriptV1, PropertyNameParseSentenceBreakV1,
     PropertyNameParseVerticalOrientationV1, PropertyNameParseWordBreakV1,
     PropertyNameShortBidiClassV1, PropertyNameShortEastAsianWidthV1,
     PropertyNameShortGeneralCategoryV1, PropertyNameShortGraphemeClusterBreakV1,
     PropertyNameShortHangulSyllableTypeV1, PropertyNameShortIndicConjunctBreakV1,
     PropertyNameShortIndicSyllabicCategoryV1, PropertyNameShortJoiningTypeV1,
-    PropertyNameShortLineBreakV1, PropertyNameShortScriptV1, PropertyNameShortSentenceBreakV1,
-    PropertyNameShortVerticalOrientationV1, PropertyNameShortWordBreakV1,
+    PropertyNameShortLineBreakV1, PropertyNameShortNumericTypeV1, PropertyNameShortScriptV1,
+    PropertyNameShortSentenceBreakV1, PropertyNameShortVerticalOrientationV1,
+    PropertyNameShortWordBreakV1,
 };
 
 pub use crate::props::gc::GeneralCategoryULE;
@@ -156,6 +158,7 @@ const _: () = {
     impl_property_enum_indic_syllabic_category_v1!(Baked);
     impl_property_enum_joining_type_v1!(Baked);
     impl_property_enum_line_break_v1!(Baked);
+    impl_property_enum_numeric_type_v1!(Baked);
     impl_property_enum_script_v1!(Baked);
     impl_property_enum_sentence_break_v1!(Baked);
     impl_property_enum_vertical_orientation_v1!(Baked);
@@ -171,6 +174,7 @@ const _: () = {
     impl_property_name_long_indic_conjunct_break_v1!(Baked);
     impl_property_name_long_joining_type_v1!(Baked);
     impl_property_name_long_line_break_v1!(Baked);
+    impl_property_name_long_numeric_type_v1!(Baked);
     impl_property_name_long_script_v1!(Baked);
     impl_property_name_long_sentence_break_v1!(Baked);
     impl_property_name_long_vertical_orientation_v1!(Baked);
@@ -186,6 +190,7 @@ const _: () = {
     impl_property_name_parse_indic_conjunct_break_v1!(Baked);
     impl_property_name_parse_joining_type_v1!(Baked);
     impl_property_name_parse_line_break_v1!(Baked);
+    impl_property_name_parse_numeric_type_v1!(Baked);
     impl_property_name_parse_script_v1!(Baked);
     impl_property_name_parse_sentence_break_v1!(Baked);
     impl_property_name_parse_vertical_orientation_v1!(Baked);
@@ -201,6 +206,7 @@ const _: () = {
     impl_property_name_short_indic_conjunct_break_v1!(Baked);
     impl_property_name_short_joining_type_v1!(Baked);
     impl_property_name_short_line_break_v1!(Baked);
+    impl_property_name_short_numeric_type_v1!(Baked);
     impl_property_name_short_script_v1!(Baked);
     impl_property_name_short_sentence_break_v1!(Baked);
     impl_property_name_short_vertical_orientation_v1!(Baked);
@@ -682,6 +688,12 @@ icu_provider::data_marker!(
     PropertyCodePointMap<'static, crate::props::LineBreak>,
     is_singleton = true,
 );
+icu_provider::data_marker!(
+    /// Data marker for the 'NumericValue' Unicode property
+    PropertyEnumNumericTypeV1,
+    PropertyCodePointMap<'static, crate::props::NumericType>,
+    is_singleton = true,
+);
 icu_provider::data_marker!(
     /// Data marker for the 'Script' Unicode property
     PropertyEnumScriptV1,
@@ -738,6 +750,7 @@ pub const MARKERS: &[DataMarkerInfo] = &[
     PropertyNameLongIndicConjunctBreakV1::INFO,
     PropertyNameLongJoiningTypeV1::INFO,
     PropertyNameLongLineBreakV1::INFO,
+    PropertyNameLongNumericTypeV1::INFO,
     PropertyNameLongScriptV1::INFO,
     PropertyNameLongSentenceBreakV1::INFO,
     PropertyNameLongVerticalOrientationV1::INFO,
@@ -753,6 +766,7 @@ pub const MARKERS: &[DataMarkerInfo] = &[
     PropertyNameParseIndicConjunctBreakV1::INFO,
     PropertyNameParseJoiningTypeV1::INFO,
     PropertyNameParseLineBreakV1::INFO,
+    PropertyNameParseNumericTypeV1::INFO,
     PropertyNameParseScriptV1::INFO,
     PropertyNameParseSentenceBreakV1::INFO,
     PropertyNameParseVerticalOrientationV1::INFO,
@@ -768,6 +782,7 @@ pub const MARKERS: &[DataMarkerInfo] = &[
     PropertyNameShortIndicConjunctBreakV1::INFO,
     PropertyNameShortJoiningTypeV1::INFO,
     PropertyNameShortLineBreakV1::INFO,
+    PropertyNameShortNumericTypeV1::INFO,
     PropertyNameShortScriptV1::INFO,
     PropertyNameShortSentenceBreakV1::INFO,
     PropertyNameShortVerticalOrientationV1::INFO,
@@ -851,6 +866,7 @@ pub const MARKERS: &[DataMarkerInfo] = &[
     PropertyEnumIndicSyllabicCategoryV1::INFO,
     PropertyEnumJoiningTypeV1::INFO,
     PropertyEnumLineBreakV1::INFO,
+    PropertyEnumNumericTypeV1::INFO,
     PropertyEnumScriptV1::INFO,
     PropertyEnumSentenceBreakV1::INFO,
     PropertyEnumVerticalOrientationV1::INFO,

components/properties/src/provider/names.rs

@@ -85,6 +85,12 @@ icu_provider::data_marker!(
     PropertyValueNameToEnumMap<'static>,
     is_singleton = true
 );
+icu_provider::data_marker!(
+    /// `PropertyNameParseNumericTypeV1`
+    PropertyNameParseNumericTypeV1,
+    PropertyValueNameToEnumMap<'static>,
+    is_singleton = true
+);
 icu_provider::data_marker!(
     /// `PropertyNameParseScriptV1`
     PropertyNameParseScriptV1,
@@ -211,6 +217,18 @@ icu_provider::data_marker!(
     PropertyEnumToValueNameLinearMap<'static>,
     is_singleton = true
 );
+icu_provider::data_marker!(
+    /// `PropertyNameLongNumericTypeV1`
+    PropertyNameLongNumericTypeV1,
+    PropertyEnumToValueNameLinearMap<'static>,
+    is_singleton = true,
+);
+icu_provider::data_marker!(
+    /// `PropertyNameShortNumericTypeV1`
+    PropertyNameShortNumericTypeV1,
+    PropertyEnumToValueNameLinearMap<'static>,
+    is_singleton = true,
+);
 icu_provider::data_marker!(
     /// `PropertyNameShortLineBreakV1`
     PropertyNameShortLineBreakV1,

components/properties/src/trievalue.rs

@@ -6,7 +6,7 @@ use crate::bidi::BidiMirroringGlyph;
 use crate::props::{
     BidiClass, CanonicalCombiningClass, EastAsianWidth, GeneralCategory, GeneralCategoryGroup,
     GraphemeClusterBreak, HangulSyllableType, IndicConjunctBreak, IndicSyllabicCategory,
-    JoiningType, LineBreak, Script, SentenceBreak, VerticalOrientation, WordBreak,
+    JoiningType, LineBreak, NumericType, Script, SentenceBreak, VerticalOrientation, WordBreak,
 };
 use crate::script::ScriptWithExt;
 use core::convert::TryInto;
@@ -29,6 +29,18 @@ impl TrieValue for CanonicalCombiningClass {
     }
 }
 
+impl TrieValue for NumericType {
+    type TryFromU32Error = TryFromIntError;
+
+    fn try_from_u32(i: u32) -> Result<Self, Self::TryFromU32Error> {
+        u8::try_from(i).map(Self)
+    }
+
+    fn to_u32(self) -> u32 {
+        u32::from(self.0)
+    }
+}
+
 impl TrieValue for BidiClass {
     type TryFromU32Error = TryFromIntError;