Replace experimental features by unstable features (#7566)

This blocks #7565 as those markers go from experimental to unstable, but
those are two different features right now, which breaks the registry
and datagen.

#6659

Fixes #6618

Author: robertbastian

.github/workflows/artifacts-build.yml

@@ -647,7 +647,7 @@ jobs:
             include_data: false
     runs-on: ${{ matrix.os }}
     env:
-      FEATURES: ${{ matrix.include_data == true && 'default_components,experimental,buffer_provider,compiled_data' || 'default_components,experimental,buffer_provider' }}
+      FEATURES: ${{ matrix.include_data == true && 'default_components,experimental,unstable,buffer_provider,compiled_data' || 'default_components,experimental,unstable,buffer_provider' }}
       FILENAME_SUFFIX: ${{ matrix.include_data == true && '-with_data' || '' }}
 
     steps:

CONTRIBUTING.md

@@ -97,7 +97,7 @@ Practically, this means that new components or improvements to existing componen
 
 If working on a new component, start it in the `components/experimental` crate. We allow contributions to that crate even if they don't yet meet all of our code quality requirements. Once finished, the code can be moved into its own crate as a separate pull request.
 
-If working on an improvement to an existing component that you wish to split into multiple smaller pieces, consider hiding it under the `"experimental"` feature in the crate. Doing so gives a signal to users and tooling that the code is not yet production-ready. Once finished, the `"experimental"` feature can be removed from the crate.
+If working on an improvement to an existing component that you wish to split into multiple smaller pieces, consider hiding it under the `"unstable"` feature in the crate. Doing so gives a signal to users and tooling that the code is not yet production-ready. Once finished, the `"unstable"` feature can be removed from the crate.
 
 When adding non-experimental code to main, also update the "unreleased" section of the changelog. This simplifies releases and gives us a better overview of what unreleased features we have.
 
@@ -172,7 +172,7 @@ If the pull request is simple and short lived, it can be initialized with review
 If the pull request is more complex and is being developed over time, it may be beneficial to start it in a `Draft` state.
 This allows other contributors to monitor the progress and volunteer feedback while annotating that the pull request is not yet ready for review.
 
-If a pull request is particularly large in scope and not release-ready, consider either (1) reducing the scope of the pull request, (2) moving work to the `icu_experimental` crate, or (3) hiding the work behind the `"experimental"` feature flag. See the section above, "Release Readiness", for more details.
+If a pull request is particularly large in scope and not release-ready, consider either (1) reducing the scope of the pull request, (2) moving work to the `icu_experimental` crate, or (3) hiding the work behind the `"unstable"` feature flag. See the section above, "Release Readiness", for more details.
 
 By the end of this phase, and right before review is requested, it is helpful for the reviewers to have a clean list of commits in the pull request.
 

components/datetime/Cargo.toml

@@ -88,7 +88,6 @@ datagen = [
     "serde",
 ]
 logging = ["icu_calendar/logging"]
-experimental = []
 unstable = []
 compiled_data = ["dep:icu_datetime_data", "icu_calendar/compiled_data", "icu_decimal/compiled_data", "icu_plurals/compiled_data", "icu_time/compiled_data", "dep:icu_locale", "icu_locale?/compiled_data", "icu_provider/baked"]
 ixdtf = ["icu_time/ixdtf", "icu_calendar/ixdtf"]
@@ -102,28 +101,28 @@ skip_optional_dependencies = true
 [[bench]]
 name = "datetime"
 harness = false
-required-features = ["compiled_data", "serde", "experimental"]
+required-features = ["compiled_data", "serde", "unstable"]
 
 [[bench]]
 name = "pattern"
 harness = false
-required-features = ["serde", "experimental"]
+required-features = ["serde", "unstable"]
 
 [[test]]
 name = "datetime"
-required-features = ["experimental", "compiled_data", "serde"]
+required-features = ["unstable", "compiled_data", "serde"]
 
 [[test]]
 name = "resolved_components"
-required-features = ["experimental", "compiled_data"]
+required-features = ["unstable", "compiled_data"]
 
 [[test]]
 name = "simple_test"
 required-features = ["compiled_data"]
 
 [[test]]
 name = "skeleton_serialization"
-required-features = ["experimental"]
+required-features = ["unstable"]
 
 [package.metadata.cargo-semver-checks.lints]
 workspace = true

components/datetime/src/builder.rs

@@ -103,7 +103,7 @@ use crate::options::*;
 /// This is a builder enum. See [`builder`](crate::fieldsets::builder).
 #[derive(Debug, Copy, Clone, PartialEq, Eq)]
 #[cfg_attr(
-    all(feature = "serde", feature = "experimental"),
+    all(feature = "serde", feature = "unstable"),
     derive(serde::Serialize, serde::Deserialize)
 )]
 #[non_exhaustive]
@@ -177,7 +177,7 @@ impl DateFields {
 /// This is a builder enum. See [`builder`](crate::fieldsets::builder).
 #[derive(Debug, Copy, Clone, PartialEq, Eq)]
 #[cfg_attr(
-    all(feature = "serde", feature = "experimental"),
+    all(feature = "serde", feature = "unstable"),
     derive(serde::Serialize, serde::Deserialize)
 )]
 #[non_exhaustive]
@@ -298,7 +298,7 @@ impl core::error::Error for BuilderError {}
 
 /// Serde impls: We can't directly use `derive(Serialize)` and also hide null fields
 /// due to <https://github.com/serde-rs/serde/issues/2191>
-#[cfg(all(feature = "serde", feature = "experimental"))]
+#[cfg(all(feature = "serde", feature = "unstable"))]
 mod _serde {
     use super::*;
     use serde::{Deserialize, Serialize};
@@ -333,7 +333,7 @@ mod _serde {
 
     /// Serialization for [`FieldSetBuilder`].
     ///
-    /// ✨ *Enabled with the `serde` and `experimental` Cargo features.*
+    /// ✨ *Enabled with the `serde` and `unstable` Cargo features.*
     ///
     /// # Examples
     ///
@@ -397,7 +397,7 @@ mod _serde {
 
     /// Deserialization for [`FieldSetBuilder`].
     ///
-    /// ✨ *Enabled with the `serde` and `experimental` Cargo features.*
+    /// ✨ *Enabled with the `serde` and `unstable` Cargo features.*
     ///
     /// For an example, see the `Serialize` impl.
     impl<'de> Deserialize<'de> for FieldSetBuilder {
@@ -1108,7 +1108,7 @@ mod tests {
         ZoneStyle::ExemplarCity,
     ];
 
-    #[cfg(all(feature = "serde", feature = "experimental"))]
+    #[cfg(all(feature = "serde", feature = "unstable"))]
     fn check_serde(value: &FieldSetBuilder) {
         let json_str = serde_json::to_string(value).unwrap();
         let json_parsed: FieldSetBuilder = serde_json::from_str(&json_str).unwrap();
@@ -1130,7 +1130,7 @@ mod tests {
             builder.clone().build_date_and_time().unwrap_err();
             builder.clone().build_composite_datetime().unwrap();
             builder.clone().build_composite().unwrap();
-            #[cfg(all(feature = "serde", feature = "experimental"))]
+            #[cfg(all(feature = "serde", feature = "unstable"))]
             check_serde(&builder);
         }
     }
@@ -1147,7 +1147,7 @@ mod tests {
             builder.clone().build_date_and_time().unwrap_err();
             builder.clone().build_composite_datetime().unwrap();
             builder.clone().build_composite().unwrap();
-            #[cfg(all(feature = "serde", feature = "experimental"))]
+            #[cfg(all(feature = "serde", feature = "unstable"))]
             check_serde(&builder);
         }
     }
@@ -1163,7 +1163,7 @@ mod tests {
         builder.clone().build_date_and_time().unwrap_err();
         builder.clone().build_composite_datetime().unwrap();
         builder.clone().build_composite().unwrap();
-        #[cfg(all(feature = "serde", feature = "experimental"))]
+        #[cfg(all(feature = "serde", feature = "unstable"))]
         check_serde(&builder);
     }
 
@@ -1179,7 +1179,7 @@ mod tests {
             builder.clone().build_date_and_time().unwrap_err();
             builder.clone().build_composite_datetime().unwrap_err();
             builder.clone().build_composite().unwrap();
-            #[cfg(all(feature = "serde", feature = "experimental"))]
+            #[cfg(all(feature = "serde", feature = "unstable"))]
             check_serde(&builder);
         }
     }
@@ -1197,7 +1197,7 @@ mod tests {
             builder.clone().build_date_and_time().unwrap();
             builder.clone().build_composite_datetime().unwrap();
             builder.clone().build_composite().unwrap();
-            #[cfg(all(feature = "serde", feature = "experimental"))]
+            #[cfg(all(feature = "serde", feature = "unstable"))]
             check_serde(&builder);
         }
     }
@@ -1216,7 +1216,7 @@ mod tests {
             builder.clone().build_date_and_time().unwrap_err();
             builder.clone().build_composite_datetime().unwrap_err();
             builder.clone().build_composite().unwrap_err();
-            #[cfg(all(feature = "serde", feature = "experimental"))]
+            #[cfg(all(feature = "serde", feature = "unstable"))]
             check_serde(&builder);
         }
     }
@@ -1235,7 +1235,7 @@ mod tests {
                 builder.clone().build_date_and_time().unwrap_err();
                 builder.clone().build_composite_datetime().unwrap_err();
                 builder.clone().build_composite().unwrap();
-                #[cfg(all(feature = "serde", feature = "experimental"))]
+                #[cfg(all(feature = "serde", feature = "unstable"))]
                 check_serde(&builder);
             }
         }
@@ -1256,7 +1256,7 @@ mod tests {
                 builder.clone().build_date_and_time().unwrap_err();
                 builder.clone().build_composite_datetime().unwrap_err();
                 builder.clone().build_composite().unwrap_err();
-                #[cfg(all(feature = "serde", feature = "experimental"))]
+                #[cfg(all(feature = "serde", feature = "unstable"))]
                 check_serde(&builder);
             }
         }
@@ -1275,7 +1275,7 @@ mod tests {
             builder.clone().build_date_and_time().unwrap_err();
             builder.clone().build_composite_datetime().unwrap_err();
             builder.clone().build_composite().unwrap();
-            #[cfg(all(feature = "serde", feature = "experimental"))]
+            #[cfg(all(feature = "serde", feature = "unstable"))]
             check_serde(&builder);
         }
     }
@@ -1295,7 +1295,7 @@ mod tests {
                 builder.clone().build_date_and_time().unwrap_err();
                 builder.clone().build_composite_datetime().unwrap_err();
                 builder.clone().build_composite().unwrap();
-                #[cfg(all(feature = "serde", feature = "experimental"))]
+                #[cfg(all(feature = "serde", feature = "unstable"))]
                 check_serde(&builder);
             }
         }
@@ -1317,7 +1317,7 @@ mod tests {
                 builder.clone().build_date_and_time().unwrap_err();
                 builder.clone().build_composite_datetime().unwrap_err();
                 builder.clone().build_composite().unwrap_err();
-                #[cfg(all(feature = "serde", feature = "experimental"))]
+                #[cfg(all(feature = "serde", feature = "unstable"))]
                 check_serde(&builder);
             }
         }

components/datetime/src/options/mod.rs

@@ -57,11 +57,11 @@ use icu_time::scaffold::IntoOption;
 /// ```
 #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash, Default)]
 #[cfg_attr(
-    all(feature = "serde", feature = "experimental"),
+    all(feature = "serde", feature = "unstable"),
     derive(serde::Serialize, serde::Deserialize)
 )]
 #[cfg_attr(
-    all(feature = "serde", feature = "experimental"),
+    all(feature = "serde", feature = "unstable"),
     serde(rename_all = "lowercase")
 )]
 #[non_exhaustive]
@@ -129,11 +129,11 @@ impl IntoOption<Length> for Length {
 /// ```
 #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash, Default)]
 #[cfg_attr(
-    all(feature = "serde", feature = "experimental"),
+    all(feature = "serde", feature = "unstable"),
     derive(serde::Serialize, serde::Deserialize)
 )]
 #[cfg_attr(
-    all(feature = "serde", feature = "experimental"),
+    all(feature = "serde", feature = "unstable"),
     serde(rename_all = "lowercase")
 )]
 #[non_exhaustive]
@@ -259,11 +259,11 @@ impl IntoOption<Alignment> for Alignment {
 /// ```
 #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash, Default)]
 #[cfg_attr(
-    all(feature = "serde", feature = "experimental"),
+    all(feature = "serde", feature = "unstable"),
     derive(serde::Serialize, serde::Deserialize)
 )]
 #[cfg_attr(
-    all(feature = "serde", feature = "experimental"),
+    all(feature = "serde", feature = "unstable"),
     serde(rename_all = "camelCase")
 )]
 #[non_exhaustive]
@@ -383,11 +383,11 @@ impl IntoOption<YearStyle> for YearStyle {
 /// ```
 #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash, Default)]
 #[cfg_attr(
-    all(feature = "serde", feature = "experimental"),
+    all(feature = "serde", feature = "unstable"),
     derive(serde::Serialize, serde::Deserialize)
 )]
 #[cfg_attr(
-    all(feature = "serde", feature = "experimental"),
+    all(feature = "serde", feature = "unstable"),
     serde(from = "TimePrecisionSerde", into = "TimePrecisionSerde")
 )]
 #[non_exhaustive]
@@ -445,7 +445,7 @@ impl IntoOption<TimePrecision> for TimePrecision {
     }
 }
 
-#[cfg(all(feature = "serde", feature = "experimental"))]
+#[cfg(all(feature = "serde", feature = "unstable"))]
 #[derive(Copy, Clone, serde::Serialize, serde::Deserialize)]
 #[serde(rename_all = "camelCase")]
 enum TimePrecisionSerde {
@@ -464,7 +464,7 @@ enum TimePrecisionSerde {
     MinuteOptional,
 }
 
-#[cfg(all(feature = "serde", feature = "experimental"))]
+#[cfg(all(feature = "serde", feature = "unstable"))]
 impl From<TimePrecision> for TimePrecisionSerde {
     fn from(value: TimePrecision) -> Self {
         match value {
@@ -485,7 +485,7 @@ impl From<TimePrecision> for TimePrecisionSerde {
     }
 }
 
-#[cfg(all(feature = "serde", feature = "experimental"))]
+#[cfg(all(feature = "serde", feature = "unstable"))]
 impl From<TimePrecisionSerde> for TimePrecision {
     fn from(value: TimePrecisionSerde) -> Self {
         match value {