Skip to content

Commit bed58ee

Browse files
authored
Dense ZeroTrie: Add issues for the TODO items (#7304)
Resolves #6920 by making smaller follow-up issues.
1 parent b57d797 commit bed58ee

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

utils/zerotrie/src/builder/dense.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ impl<'a> DenseSparse2dAsciiWithFixedDelimiterBuilder<'a> {
3434
prefix: &'a str,
3535
values: &BTreeMap<&'a str, usize>,
3636
) -> Result<(), ZeroTrieBuildError> {
37-
// TODO: Is there a more Rusty way to compute min and max together?
37+
// Is there a more Rusty way to compute min and max together?
3838
let mut min = usize::MAX;
3939
let mut max = 0;
4040
for value in values.values() {
@@ -43,7 +43,7 @@ impl<'a> DenseSparse2dAsciiWithFixedDelimiterBuilder<'a> {
4343
}
4444
// >= because DenseType::MAX is the sentinel
4545
if max - min >= usize::from(DenseType::MAX) {
46-
// How to implement this when we need it:
46+
// TODO(#7303): How to implement this when we need it:
4747
// 1. Select the row offset that gets the greatest number of values into the dense matrix.
4848
// 2. Put all out-of-range values into the primary trie, as we do with sparse rows.
4949
todo!("values in row are not in a sufficiently compact range");
@@ -54,7 +54,7 @@ impl<'a> DenseSparse2dAsciiWithFixedDelimiterBuilder<'a> {
5454
.iter()
5555
.map(|(suffix, value)| (*suffix, *value))
5656
.partition::<BTreeMap<&'a str, usize>, _>(|(suffix, _value)| {
57-
// TODO: Also filter for suffixes that are out of range of the dense row offset
57+
// TODO(#7303): Also filter for suffixes that are out of range of the dense row offset
5858
self.suffixes.contains(suffix)
5959
});
6060
// Check whether the sparse trie is smaller than the dense row
@@ -161,7 +161,7 @@ impl ZeroAsciiDenseSparse2dTrieOwned {
161161
delimiter,
162162
..Default::default()
163163
};
164-
// TODO: Prune low-frequency suffixes.
164+
// TODO(#7302): Prune low-frequency suffixes.
165165
// For now, build with all suffixes.
166166
builder.suffixes = entries
167167
.values()

0 commit comments

Comments
 (0)