Skip to content

Plural rule parsing and handling code cleanup #2623

Open
@echeran

Description

@echeran

In #1091, we recently discussed and concluded next steps that are specific to the immediate short-term needs of the imminent v1.0 release. In the process of working on #2598 to implement those specific changes, some difficulties arose due to the code needing some cleanup.

Issue(s):

  • One of the original tasks is to make icu_plurals::rules experimental. However, this is not fully possible
  • The existing submodules icu_plurals::rules::reference and icu_plurals::rules::runtime had to be marked as #[doc(hidden)] because they could not be put behind the "experimental" attribute
  • The reason that icu_plurals::rules::{reference, runtime} could not be marked as "experimental" is because runtime has serde implementations for JSON, and runtime depends on reference

Instead, what we want is code that we discussed as experimental code -- not currently intended for stable API and intended for further discussion -- to be properly put behind the "experimental" attribute accordingly.

@zbraniecki

Metadata

Metadata

Assignees

Labels

C-pluralrulesComponent: Plural rulesS-mediumSize: Less than a week (larger bug fix or enhancement)T-techdebtType: ICU4X code health and tech debt

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions