Skip to content

Make Vec yokeable #4789

Open
Open
@ChayimFriedman2

Description

@ChayimFriedman2

Yokeable is implemented for Vec, but it does not forward the yoking and instead just treat them as owned values that do not borrow from the cart. This is inconsistent with the implementation of Yokeable for arrays, which does forward to the items.

I don't see any inherent reason why Vec couldn't do the same. This is a breaking change, but with the current situation it is impossible (safely) to use Vec as a yokeable, while if we change it it is easily possible to restore the old behavior by deriving Yokeable on non-yoked structs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-zerovecComponent: Yoke, ZeroVec, DataBakeT-enhancementType: Nice-to-have but not required

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions